From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Liao Subject: Re: [PATCH v9 1/4] soc: mediatek: Refine scpsys to support multiple platform Date: Fri, 28 Oct 2016 17:36:48 +0800 Message-ID: <1477647408.24014.6.camel@mtksdaap41> References: <1476953798-23263-1-git-send-email-jamesjj.liao@mediatek.com> <1476953798-23263-2-git-send-email-jamesjj.liao@mediatek.com> <1d5cda95-467a-4f95-1cc9-b8f156271a54@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1d5cda95-467a-4f95-1cc9-b8f156271a54-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matthias Brugger Cc: Sascha Hauer , Rob Herring , srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kevin Hilman , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Matthias, Sorry for late reply due to our email service. On Tue, 2016-10-25 at 16:04 +0200, Matthias Brugger wrote: > Hi James, > > On 10/20/2016 10:56 AM, James Liao wrote: > > -static int scpsys_probe(struct platform_device *pdev) > > +static void init_clks(struct platform_device *pdev, struct clk *clk[CLK_MAX]) > > I prefer struct clk **clk. Okay. > > +{ > > + int i; > > + > > + for (i = CLK_NONE + 1; i < CLK_MAX; i++) > > + clk[i] = devm_clk_get(&pdev->dev, clk_names[i]); > > +} > > + > > +static struct scp *init_scp(struct platform_device *pdev, > > + const struct scp_domain_data *scp_domain_data, int num) > > { > > struct genpd_onecell_data *pd_data; > > struct resource *res; > > - int i, j, ret; > > + int i, j; > > struct scp *scp; > > - struct clk *clk[MT8173_CLK_MAX]; > > + struct clk *clk[CLK_MAX]; > > should be *[CLK_MAX - 1] but I would prefer to define in the enum: > CLK_MAX = CLK_VENC_LT, After init_clks() the clk[] will have valid contents between clk[1]..clk[CLK_MAX-1], so it's necessary to declare clk[] with CLK_MAX elements. > If you are ok with it, I can fix both of my comments when applying. Yes. struct clk **clk can be applied directly. But I think clk[CLK_MAX] should be kept in current implementation. Best regards, James -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html