* [PATCH 1/2] dt-bindings: ahci-fsl-qoriq: added explanation for reg-names
@ 2016-11-17 7:59 yuantian.tang
2016-11-17 7:59 ` [PATCH 2/2] arm64: dts: updated sata node on ls1046a dts yuantian.tang
2016-11-18 14:21 ` [PATCH 1/2] dt-bindings: ahci-fsl-qoriq: added explanation for reg-names Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: yuantian.tang @ 2016-11-17 7:59 UTC (permalink / raw)
To: tj
Cc: robh+dt, mark.rutland, catalin.marinas, will.deacon, shawnguo,
linux-ide, devicetree, linux-kernel, linux-arm-kernel,
Tang Yuantian, Tang Yuantian
From: Tang Yuantian <Yuantian.Tang@nxp.com>
Added explanation for reg-names to make it more clear.
Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
---
Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
index fc33ca0..80cf10c 100644
--- a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
+++ b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
@@ -10,6 +10,8 @@ Required properties:
Optional properties:
- dma-coherent: Enable AHCI coherent DMA operation.
- reg-names: register area names when there are more than 1 register area.
+ example: 'ahci' is for sata controller register.
+ 'sata-ecc' is for sata ecc register.
Examples:
sata@3200000 {
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] arm64: dts: updated sata node on ls1046a dts
2016-11-17 7:59 [PATCH 1/2] dt-bindings: ahci-fsl-qoriq: added explanation for reg-names yuantian.tang
@ 2016-11-17 7:59 ` yuantian.tang
[not found] ` <1479369560-9188-2-git-send-email-yuantian.tang-3arQi8VN3Tc@public.gmane.org>
2016-11-18 14:21 ` [PATCH 1/2] dt-bindings: ahci-fsl-qoriq: added explanation for reg-names Rob Herring
1 sibling, 1 reply; 4+ messages in thread
From: yuantian.tang @ 2016-11-17 7:59 UTC (permalink / raw)
To: tj
Cc: robh+dt, mark.rutland, catalin.marinas, will.deacon, shawnguo,
linux-ide, devicetree, linux-kernel, linux-arm-kernel,
Tang Yuantian, Tang Yuantian
From: Tang Yuantian <Yuantian.Tang@nxp.com>
On ls1046a soc, sata ecc should be disabled. So added sata ecc
register address so that driver can get this information.
Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 38806ca..88aaaf1 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -507,7 +507,9 @@
sata: sata@3200000 {
compatible = "fsl,ls1046a-ahci";
- reg = <0x0 0x3200000 0x0 0x10000>;
+ reg = <0x0 0x3200000 0x0 0x10000>,
+ <0x0 0x20140520 0x0 0x4>;
+ reg-names = "ahci", "sata-ecc";
interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clockgen 4 1>;
};
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] dt-bindings: ahci-fsl-qoriq: added explanation for reg-names
2016-11-17 7:59 [PATCH 1/2] dt-bindings: ahci-fsl-qoriq: added explanation for reg-names yuantian.tang
2016-11-17 7:59 ` [PATCH 2/2] arm64: dts: updated sata node on ls1046a dts yuantian.tang
@ 2016-11-18 14:21 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2016-11-18 14:21 UTC (permalink / raw)
To: yuantian.tang
Cc: mark.rutland, devicetree, catalin.marinas, will.deacon,
linux-kernel, linux-ide, tj, shawnguo, linux-arm-kernel
On Thu, Nov 17, 2016 at 03:59:19PM +0800, yuantian.tang@nxp.com wrote:
> From: Tang Yuantian <Yuantian.Tang@nxp.com>
>
> Added explanation for reg-names to make it more clear.
>
> Signed-off-by: Tang Yuantian <yuantian.tang@nxp.com>
> ---
> Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
> index fc33ca0..80cf10c 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-fsl-qoriq.txt
> @@ -10,6 +10,8 @@ Required properties:
> Optional properties:
> - dma-coherent: Enable AHCI coherent DMA operation.
> - reg-names: register area names when there are more than 1 register area.
> + example: 'ahci' is for sata controller register.
> + 'sata-ecc' is for sata ecc register.
This is not an example, but should be exactly what names are used.
When is there more than one area? That should be defined by the
compatible string and spelled out here.
Rob
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-12-30 2:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-17 7:59 [PATCH 1/2] dt-bindings: ahci-fsl-qoriq: added explanation for reg-names yuantian.tang
2016-11-17 7:59 ` [PATCH 2/2] arm64: dts: updated sata node on ls1046a dts yuantian.tang
[not found] ` <1479369560-9188-2-git-send-email-yuantian.tang-3arQi8VN3Tc@public.gmane.org>
2016-12-30 2:36 ` Shawn Guo
2016-11-18 14:21 ` [PATCH 1/2] dt-bindings: ahci-fsl-qoriq: added explanation for reg-names Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).