Re: [PATCH 3/3] arm64: dts: mediatek: Add Acelink EW-7886CAX

["Rafał Miłecki" <zajec5@gmail.com>]

On 21.11.2023 11:31, AngeloGioacchino Del Regno wrote:
> Il 20/11/23 18:27, Rafał Miłecki ha scritto:
>> On 20.11.2023 15:17, AngeloGioacchino Del Regno wrote:
>>> Il 17/11/23 11:43, Rafał Miłecki ha scritto:
>>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>>
>>>> Acelink EW-7886CAX is an MT7986A (AKA Filogic 830) based access point.
>>>> It has 512 MiB of RAM, one 2.5 Gbps PoE (802.3at) Ethernet port and
>>>> on-SoC Wi-Fi.
>>>>
>>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>>>> ---
>>>>   arch/arm64/boot/dts/mediatek/Makefile         |   1 +
>>>>   .../mediatek/mt7986a-acelink-ew-7886cax.dts   | 175 ++++++++++++++++++
>>>>   2 files changed, 176 insertions(+)
>>>>   create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-acelink-ew-7886cax.dts
>>>>
>>>> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
>>>> index e6e7592a3645..9ff2ab6c5e4d 100644
>>>> --- a/arch/arm64/boot/dts/mediatek/Makefile
>>>> +++ b/arch/arm64/boot/dts/mediatek/Makefile
>>>> @@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-evb.dtb
>>>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb
>>>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb
>>>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb
>>>> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-acelink-ew-7886cax.dtb
>>>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb
>>>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo
>>>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo
>>>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-acelink-ew-7886cax.dts b/arch/arm64/boot/dts/mediatek/mt7986a-acelink-ew-7886cax.dts
>>>> new file mode 100644
>>>> index 000000000000..18d19281dfdb
>>>> --- /dev/null
>>>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-acelink-ew-7886cax.dts
>>>> @@ -0,0 +1,175 @@
>>>> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
>>>> +
>>>> +/dts-v1/;
>>>> +#include <dt-bindings/input/input.h>
>>>> +#include <dt-bindings/gpio/gpio.h>
>>>> +#include <dt-bindings/leds/common.h>
>>>> +
>>>> +#include "mt7986a.dtsi"
>>>> +
>>>> +/ {
>>>> +    model = "Acelink EW-7886CAX";
>>>> +    compatible = "acelink,ew-7886cax", "mediatek,mt7986a";
>>>> +
>>>> +    aliases {
>>>> +        serial0 = &uart0;
>>>> +    };
>>>> +
>>>> +    chosen {
>>>> +        stdout-path = "serial0:115200n8";
>>>> +    };
>>>> +
>>>> +    memory@40000000 {
>>>> +        reg = <0 0x40000000 0 0x20000000>;
>>>> +        device_type = "memory";
>>>> +    };
>>>> +
>>>> +    keys {
>>>> +        compatible = "gpio-keys";
>>>> +
>>>> +        key-restart {
>>>> +            label = "Reset";
>>>> +            gpios = <&pio 7 GPIO_ACTIVE_LOW>;
>>>> +            linux,code = <KEY_RESTART>;
>>>> +        };
>>>> +    };
>>>> +
>>>> +    leds {
>>>> +        compatible = "gpio-leds";
>>>> +
>>>> +        led-0 {
>>>
>>> Please, reorder by name
>>>
>>>              color =    ...
>>>              function = ...
>>>              gpios = ...
>>
>> Can you explain why and if there is a place I can find rules to follow
>> regarding such aspects? I really would like to just be aware of all
>> rules and don't waste anyone's time for such details.
>>
>> FWIW I checked Documentation/devicetree/bindings/*.rst (after few years
>> I admit) but I couldn't find anything there about properties order.
>>
>> If we currently don't have rules I don't really think we should enforce
>> following per-maintainer preferences. I really don't object your
>> suggestions but there is simply no way to remember each maintainer's
>> rules. We simply have too many subsystems and architectures boards.
>>
>>
> 
> What I said is not a maintainer preference but more of a general rule, which is
> in the process of being documented.
> 
> Check the patch there, at the time of writing, v2:
> https://lore.kernel.org/all/20231120084044.23838-1-krzysztof.kozlowski@linaro.org/

That is exactly what I was looking for (except I didn't assume it may we
WIP). Thank you!