From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LETWIfgL" Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F36A2F4 for ; Tue, 21 Nov 2023 03:15:48 -0800 (PST) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-5079f6efd64so7080217e87.2 for ; Tue, 21 Nov 2023 03:15:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700565347; x=1701170147; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ureO+uz+HH3VWTrrGTWXTia0TXwq9jc/nCIjnx/zm8E=; b=LETWIfgLgbmBU83PDME68L/BBnmfNK7YeHRERhAdxeH6fHCsr9BGC9Wl2ebH6gQnQ+ OilOi/t4gYCEKh6TzJ2/K566qGeVIh+BkCx4wDfu4nPkvGSBI7xZkw+MMtZ6rx1h+mdS Wp04O3fcnRMfbdEu/QzD8kM8tv/O4W0wOgfcI8XZAeZZi953A6qozeqMPdn2ydP5XJHh aEdRuSl1wbTB+5bjtirPtaZ4pJgWhcLzMu/pYmsaTjTQNWAd3lCaMgTsJ2B1KgvOD+3r iuYNT/p8Wf/fHxaCIreqM47BpBSGeleUFJtlZtIgRqNFKLCzlLdyhvmWdnCKvDu1scZq Luiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700565347; x=1701170147; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ureO+uz+HH3VWTrrGTWXTia0TXwq9jc/nCIjnx/zm8E=; b=k7abz/7GqFmqj5gO7OG0sOAZQmsqgIs6WfX6K7CPyRJHI4zlzGsr/hsZXuntL8lThl MieuG7JfCl4LbrjxZPG38E/SctrNYWe0o+UAAjuCPH6OTR936mWs2GWCy+rviqrIexuG 7K10zR3ZkfEMFgqLKOrTmlq0lfou53TcUuIY3uUOMFsFaqN9sC8WCauG13PcUErixx05 pIqo1QJOLpROOXslPFzXzfogifQ2Zsfz1n/AB1F1rGEpwl4SeJMpDo+qsZBdn7V4iUGB fmK3+Xt5tDOzbEHND2g3Xl/1hJMuAU/VmhDXLXNs4lRRxaVbIgkJ6OelQeYOQxadp1YP rEsA== X-Gm-Message-State: AOJu0YwMeyxLQ51NvueTe2NzNLJnIYX23hV1GOMa6EKKYkTSEfsMUVkx Mza7cR2MUwGcwqhBqW9tSJrQFS3mp1I= X-Google-Smtp-Source: AGHT+IF+ca+iA+AgWJJxG336wPchy8U1lzUCfl4fZu0x93tY+S/cX8tc1q5hjP9nQBcoID876FPrYg== X-Received: by 2002:a05:6512:110d:b0:50a:a82c:a5f2 with SMTP id l13-20020a056512110d00b0050aa82ca5f2mr8673055lfg.66.1700565346890; Tue, 21 Nov 2023 03:15:46 -0800 (PST) Received: from [192.168.26.149] (031011218106.poznan.vectranet.pl. [31.11.218.106]) by smtp.googlemail.com with ESMTPSA id q25-20020a19a419000000b005056422d204sm1495561lfc.158.2023.11.21.03.15.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Nov 2023 03:15:46 -0800 (PST) Message-ID: <147af53c-1695-4c83-a83d-b6460b332f63@gmail.com> Date: Tue, 21 Nov 2023 12:15:44 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] arm64: dts: mediatek: Add Acelink EW-7886CAX To: AngeloGioacchino Del Regno , Matthias Brugger , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: =?UTF-8?Q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= , Macpaul Lin , =?UTF-8?Q?Bernhard_Rosenkr=C3=A4nzer?= , Heiko Stuebner , Jernej Skrabec , Chris Morgan , Linus Walleij , Sean Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20231117104315.9718-2-zajec5@gmail.com> <20231117104315.9718-3-zajec5@gmail.com> <0c3267e5-5371-4fd8-a0f6-360ff28c9dda@collabora.com> <94165a35-4ce9-4624-938f-00545562fee4@collabora.com> Content-Language: en-US From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: <94165a35-4ce9-4624-938f-00545562fee4@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 21.11.2023 11:31, AngeloGioacchino Del Regno wrote: > Il 20/11/23 18:27, Rafał Miłecki ha scritto: >> On 20.11.2023 15:17, AngeloGioacchino Del Regno wrote: >>> Il 17/11/23 11:43, Rafał Miłecki ha scritto: >>>> From: Rafał Miłecki >>>> >>>> Acelink EW-7886CAX is an MT7986A (AKA Filogic 830) based access point. >>>> It has 512 MiB of RAM, one 2.5 Gbps PoE (802.3at) Ethernet port and >>>> on-SoC Wi-Fi. >>>> >>>> Signed-off-by: Rafał Miłecki >>>> --- >>>>   arch/arm64/boot/dts/mediatek/Makefile         |   1 + >>>>   .../mediatek/mt7986a-acelink-ew-7886cax.dts   | 175 ++++++++++++++++++ >>>>   2 files changed, 176 insertions(+) >>>>   create mode 100644 arch/arm64/boot/dts/mediatek/mt7986a-acelink-ew-7886cax.dts >>>> >>>> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile >>>> index e6e7592a3645..9ff2ab6c5e4d 100644 >>>> --- a/arch/arm64/boot/dts/mediatek/Makefile >>>> +++ b/arch/arm64/boot/dts/mediatek/Makefile >>>> @@ -8,6 +8,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-evb.dtb >>>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt6797-x20-dev.dtb >>>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-rfb1.dtb >>>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7622-bananapi-bpi-r64.dtb >>>> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-acelink-ew-7886cax.dtb >>>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3.dtb >>>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-emmc.dtbo >>>>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt7986a-bananapi-bpi-r3-nand.dtbo >>>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-acelink-ew-7886cax.dts b/arch/arm64/boot/dts/mediatek/mt7986a-acelink-ew-7886cax.dts >>>> new file mode 100644 >>>> index 000000000000..18d19281dfdb >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-acelink-ew-7886cax.dts >>>> @@ -0,0 +1,175 @@ >>>> +// SPDX-License-Identifier: GPL-2.0-only OR MIT >>>> + >>>> +/dts-v1/; >>>> +#include >>>> +#include >>>> +#include >>>> + >>>> +#include "mt7986a.dtsi" >>>> + >>>> +/ { >>>> +    model = "Acelink EW-7886CAX"; >>>> +    compatible = "acelink,ew-7886cax", "mediatek,mt7986a"; >>>> + >>>> +    aliases { >>>> +        serial0 = &uart0; >>>> +    }; >>>> + >>>> +    chosen { >>>> +        stdout-path = "serial0:115200n8"; >>>> +    }; >>>> + >>>> +    memory@40000000 { >>>> +        reg = <0 0x40000000 0 0x20000000>; >>>> +        device_type = "memory"; >>>> +    }; >>>> + >>>> +    keys { >>>> +        compatible = "gpio-keys"; >>>> + >>>> +        key-restart { >>>> +            label = "Reset"; >>>> +            gpios = <&pio 7 GPIO_ACTIVE_LOW>; >>>> +            linux,code = ; >>>> +        }; >>>> +    }; >>>> + >>>> +    leds { >>>> +        compatible = "gpio-leds"; >>>> + >>>> +        led-0 { >>> >>> Please, reorder by name >>> >>>              color =    ... >>>              function = ... >>>              gpios = ... >> >> Can you explain why and if there is a place I can find rules to follow >> regarding such aspects? I really would like to just be aware of all >> rules and don't waste anyone's time for such details. >> >> FWIW I checked Documentation/devicetree/bindings/*.rst (after few years >> I admit) but I couldn't find anything there about properties order. >> >> If we currently don't have rules I don't really think we should enforce >> following per-maintainer preferences. I really don't object your >> suggestions but there is simply no way to remember each maintainer's >> rules. We simply have too many subsystems and architectures boards. >> >> > > What I said is not a maintainer preference but more of a general rule, which is > in the process of being documented. > > Check the patch there, at the time of writing, v2: > https://lore.kernel.org/all/20231120084044.23838-1-krzysztof.kozlowski@linaro.org/ That is exactly what I was looking for (except I didn't assume it may we WIP). Thank you!