devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] cache: qcom,llcc: Add llcc support for SC8380XP
@ 2023-10-25 13:46 Sibi Sankar
  2023-10-25 13:46 ` [PATCH 1/2] dt-bindings: cache: qcom,llcc: Add SC8380XP compatible Sibi Sankar
  2023-10-25 13:46 ` [PATCH 2/2] soc: qcom: llcc: Add configuration data for SC8380XP Sibi Sankar
  0 siblings, 2 replies; 6+ messages in thread
From: Sibi Sankar @ 2023-10-25 13:46 UTC (permalink / raw)
  To: andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt
  Cc: agross, conor+dt, quic_rjendra, abel.vesa, linux-arm-msm,
	devicetree, linux-kernel, quic_tsoni, neil.armstrong, Sibi Sankar

This series adds llcc support for the Qualcomm SC8380XP platform, aka Snapdragon X Elite.

Dependencies: None
Release Link: https://www.qualcomm.com/news/releases/2023/10/qualcomm-unleashes-snapdragon-x-elite--the-ai-super-charged-plat

Rajendra Nayak (2):
  dt-bindings: cache: qcom,llcc: Add SC8380XP compatible
  soc: qcom: llcc: Add configuration data for SC8380XP

 .../devicetree/bindings/cache/qcom,llcc.yaml  |  2 +
 drivers/soc/qcom/llcc-qcom.c                  | 39 +++++++++++++++++++
 2 files changed, 41 insertions(+)

-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] dt-bindings: cache: qcom,llcc: Add SC8380XP compatible
  2023-10-25 13:46 [PATCH 0/2] cache: qcom,llcc: Add llcc support for SC8380XP Sibi Sankar
@ 2023-10-25 13:46 ` Sibi Sankar
  2023-10-27  8:22   ` Krzysztof Kozlowski
  2023-10-25 13:46 ` [PATCH 2/2] soc: qcom: llcc: Add configuration data for SC8380XP Sibi Sankar
  1 sibling, 1 reply; 6+ messages in thread
From: Sibi Sankar @ 2023-10-25 13:46 UTC (permalink / raw)
  To: andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt
  Cc: agross, conor+dt, quic_rjendra, abel.vesa, linux-arm-msm,
	devicetree, linux-kernel, quic_tsoni, neil.armstrong, Sibi Sankar

From: Rajendra Nayak <quic_rjendra@quicinc.com>

Add the compatible for SC8380XP platforms.

Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---
 Documentation/devicetree/bindings/cache/qcom,llcc.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
index 580f9a97ddf7..96453f15c8a5 100644
--- a/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
+++ b/Documentation/devicetree/bindings/cache/qcom,llcc.yaml
@@ -25,6 +25,7 @@ properties:
       - qcom,sc7280-llcc
       - qcom,sc8180x-llcc
       - qcom,sc8280xp-llcc
+      - qcom,sc8380xp-llcc
       - qcom,sdm845-llcc
       - qcom,sm6350-llcc
       - qcom,sm7150-llcc
@@ -104,6 +105,7 @@ allOf:
               - qcom,qdu1000-llcc
               - qcom,sc8180x-llcc
               - qcom,sc8280xp-llcc
+              - qcom,sc8380xp-llcc
     then:
       properties:
         reg:
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] soc: qcom: llcc: Add configuration data for SC8380XP
  2023-10-25 13:46 [PATCH 0/2] cache: qcom,llcc: Add llcc support for SC8380XP Sibi Sankar
  2023-10-25 13:46 ` [PATCH 1/2] dt-bindings: cache: qcom,llcc: Add SC8380XP compatible Sibi Sankar
@ 2023-10-25 13:46 ` Sibi Sankar
  2023-10-25 16:50   ` Bryan O'Donoghue
  2023-10-26 11:02   ` Konrad Dybcio
  1 sibling, 2 replies; 6+ messages in thread
From: Sibi Sankar @ 2023-10-25 13:46 UTC (permalink / raw)
  To: andersson, konrad.dybcio, robh+dt, krzysztof.kozlowski+dt
  Cc: agross, conor+dt, quic_rjendra, abel.vesa, linux-arm-msm,
	devicetree, linux-kernel, quic_tsoni, neil.armstrong, Sibi Sankar

From: Rajendra Nayak <quic_rjendra@quicinc.com>

Add LLCC configuration data for SC8380XP SoC.

Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---
 drivers/soc/qcom/llcc-qcom.c | 39 ++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
index 674abd0d6700..e232dcf382e9 100644
--- a/drivers/soc/qcom/llcc-qcom.c
+++ b/drivers/soc/qcom/llcc-qcom.c
@@ -392,6 +392,29 @@ static const struct llcc_slice_config qdu1000_data_8ch[] = {
 	{ LLCC_WRCACHE, 31, 512,  1, 1, 0x3,   0x0, 0, 0, 0, 0, 1, 0, 0 },
 };
 
+static const struct llcc_slice_config sc8380xp_data[] = {
+	{LLCC_CPUSS,	 1, 6144, 1, 1, 0xFFF, 0x0, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_VIDSC0,	 2,  512, 3, 1, 0xFFF, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_AUDIO,	 6, 3072, 1, 1, 0xFFF, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_CMPT,     10, 6144, 1, 1, 0xFFF, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_GPUHTW,   11, 1024, 1, 1, 0xFFF, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_GPU,       9, 4096, 1, 1, 0xFFF, 0x0, 0, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_MMUHWT,   18,  512, 1, 1, 0xFFF, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_AUDHW,    22, 1024, 1, 1, 0xFFF, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_CVP,       8,  512, 3, 1, 0xFFF, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_WRCACHE,  31,  512, 1, 1, 0xFFF, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_CAMEXP1,   7, 3072, 2, 1, 0xFFF, 0x0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_LCPDARE,  30,  512, 3, 1, 0xFFF, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_AENPU,     3, 3072, 1, 1, 0xFFF, 0x0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_ISLAND1,  12,  512, 7, 1,   0x1, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_ISLAND2,  13,  512, 7, 1,   0x2, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_ISLAND3,  14,  512, 7, 1,   0x3, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_ISLAND4,  15,  512, 7, 1,   0x4, 0x0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_CAMEXP2,  19, 3072, 3, 1, 0xFFF, 0x0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_CAMEXP3,  20, 3072, 3, 1, 0xFFF, 0x0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+	{LLCC_CAMEXP4,  21, 3072, 3, 1, 0xFFF, 0x0, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},
+};
+
 static const struct llcc_edac_reg_offset llcc_v1_edac_reg_offset = {
 	.trp_ecc_error_status0 = 0x20344,
 	.trp_ecc_error_status1 = 0x20348,
@@ -529,6 +552,16 @@ static const struct qcom_llcc_config sc8280xp_cfg[] = {
 	},
 };
 
+static const struct qcom_llcc_config sc8380xp_cfg[] = {
+	{
+		.sct_data	= sc8380xp_data,
+		.size		= ARRAY_SIZE(sc8380xp_data),
+		.need_llcc_cfg	= true,
+		.reg_offset	= llcc_v2_1_reg_offset,
+		.edac_reg_offset = &llcc_v2_1_edac_reg_offset,
+	},
+};
+
 static const struct qcom_llcc_config sdm845_cfg[] = {
 	{
 		.sct_data	= sdm845_data,
@@ -635,6 +668,11 @@ static const struct qcom_sct_config sc8280xp_cfgs = {
 	.num_config	= ARRAY_SIZE(sc8280xp_cfg),
 };
 
+static const struct qcom_sct_config sc8380xp_cfgs = {
+	.llcc_config	= sc8380xp_cfg,
+	.num_config	= ARRAY_SIZE(sc8380xp_cfg),
+};
+
 static const struct qcom_sct_config sdm845_cfgs = {
 	.llcc_config	= sdm845_cfg,
 	.num_config	= ARRAY_SIZE(sdm845_cfg),
@@ -1241,6 +1279,7 @@ static const struct of_device_id qcom_llcc_of_match[] = {
 	{ .compatible = "qcom,sc7280-llcc", .data = &sc7280_cfgs },
 	{ .compatible = "qcom,sc8180x-llcc", .data = &sc8180x_cfgs },
 	{ .compatible = "qcom,sc8280xp-llcc", .data = &sc8280xp_cfgs },
+	{ .compatible = "qcom,sc8380xp-llcc", .data = &sc8380xp_cfgs },
 	{ .compatible = "qcom,sdm845-llcc", .data = &sdm845_cfgs },
 	{ .compatible = "qcom,sm6350-llcc", .data = &sm6350_cfgs },
 	{ .compatible = "qcom,sm7150-llcc", .data = &sm7150_cfgs },
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] soc: qcom: llcc: Add configuration data for SC8380XP
  2023-10-25 13:46 ` [PATCH 2/2] soc: qcom: llcc: Add configuration data for SC8380XP Sibi Sankar
@ 2023-10-25 16:50   ` Bryan O'Donoghue
  2023-10-26 11:02   ` Konrad Dybcio
  1 sibling, 0 replies; 6+ messages in thread
From: Bryan O'Donoghue @ 2023-10-25 16:50 UTC (permalink / raw)
  To: Sibi Sankar, andersson, konrad.dybcio, robh+dt,
	krzysztof.kozlowski+dt
  Cc: agross, conor+dt, quic_rjendra, abel.vesa, linux-arm-msm,
	devicetree, linux-kernel, quic_tsoni, neil.armstrong

On 25/10/2023 14:46, Sibi Sankar wrote:
> From: Rajendra Nayak <quic_rjendra@quicinc.com>
> 
> Add LLCC configuration data for SC8380XP SoC.
> 
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---

LGTM

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] soc: qcom: llcc: Add configuration data for SC8380XP
  2023-10-25 13:46 ` [PATCH 2/2] soc: qcom: llcc: Add configuration data for SC8380XP Sibi Sankar
  2023-10-25 16:50   ` Bryan O'Donoghue
@ 2023-10-26 11:02   ` Konrad Dybcio
  1 sibling, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-10-26 11:02 UTC (permalink / raw)
  To: Sibi Sankar, andersson, robh+dt, krzysztof.kozlowski+dt
  Cc: agross, conor+dt, quic_rjendra, abel.vesa, linux-arm-msm,
	devicetree, linux-kernel, quic_tsoni, neil.armstrong



On 10/25/23 15:46, Sibi Sankar wrote:
> From: Rajendra Nayak <quic_rjendra@quicinc.com>
> 
> Add LLCC configuration data for SC8380XP SoC.
> 
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---
Just double-checking, has this been updated for R2?

Konrad

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: cache: qcom,llcc: Add SC8380XP compatible
  2023-10-25 13:46 ` [PATCH 1/2] dt-bindings: cache: qcom,llcc: Add SC8380XP compatible Sibi Sankar
@ 2023-10-27  8:22   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-10-27  8:22 UTC (permalink / raw)
  To: Sibi Sankar, andersson, konrad.dybcio, robh+dt,
	krzysztof.kozlowski+dt
  Cc: agross, conor+dt, quic_rjendra, abel.vesa, linux-arm-msm,
	devicetree, linux-kernel, quic_tsoni, neil.armstrong

On 25/10/2023 15:46, Sibi Sankar wrote:
> From: Rajendra Nayak <quic_rjendra@quicinc.com>
> 
> Add the compatible for SC8380XP platforms.
> 
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2023-10-27  8:22 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-25 13:46 [PATCH 0/2] cache: qcom,llcc: Add llcc support for SC8380XP Sibi Sankar
2023-10-25 13:46 ` [PATCH 1/2] dt-bindings: cache: qcom,llcc: Add SC8380XP compatible Sibi Sankar
2023-10-27  8:22   ` Krzysztof Kozlowski
2023-10-25 13:46 ` [PATCH 2/2] soc: qcom: llcc: Add configuration data for SC8380XP Sibi Sankar
2023-10-25 16:50   ` Bryan O'Donoghue
2023-10-26 11:02   ` Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).