From: Matt Ranostay <matt@ranostay.consulting>
To: devicetree@vger.kernel.org, linux-mmc@vger.kernel.org
Cc: Matt Ranostay <matt@ranostay.consulting>,
Tony Lindgren <tony@atomide.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: [PATCH 2/4] mmc: pwrseq-simple: add support for power down GPIO pins
Date: Thu, 1 Dec 2016 22:17:40 -0800 [thread overview]
Message-ID: <1480659462-29536-3-git-send-email-matt@ranostay.consulting> (raw)
In-Reply-To: <1480659462-29536-1-git-send-email-matt@ranostay.consulting>
Some devices have additional pins that control power but need to
asserted separately from reset-gpios using a defined time delay.
Cc: Tony Lindgren <tony@atomide.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Matt Ranostay <matt@ranostay.consulting>
---
.../devicetree/bindings/mmc/mmc-pwrseq-simple.txt | 2 ++
drivers/mmc/core/pwrseq_simple.c | 26 +++++++++++++---------
2 files changed, 18 insertions(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt
index 88826f7d1d38..703a714201d8 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt
+++ b/Documentation/devicetree/bindings/mmc/mmc-pwrseq-simple.txt
@@ -12,6 +12,8 @@ Optional properties:
at initialization and prior we start the power up procedure of the card.
They will be de-asserted right after the power has been provided to the
card.
+- pwrdn-gpios : contains a list of GPIO specifiers. The pwrdn GPIOs are asserted
+ at initialization and prior we start the power up procedure of the card.
- clocks : Must contain an entry for the entry in clock-names.
See ../clocks/clock-bindings.txt for details.
- clock-names : Must include the following entry:
diff --git a/drivers/mmc/core/pwrseq_simple.c b/drivers/mmc/core/pwrseq_simple.c
index cb2ba7b11383..adf1f7161fe3 100644
--- a/drivers/mmc/core/pwrseq_simple.c
+++ b/drivers/mmc/core/pwrseq_simple.c
@@ -30,24 +30,23 @@ struct mmc_pwrseq_simple {
u32 post_power_on_delay_ms;
struct clk *ext_clk;
struct gpio_descs *reset_gpios;
+ struct gpio_descs *pwrdn_gpios;
};
#define to_pwrseq_simple(p) container_of(p, struct mmc_pwrseq_simple, pwrseq)
static void mmc_pwrseq_simple_set_gpios_value(struct mmc_pwrseq_simple *pwrseq,
+ struct gpio_descs *gpios,
int value)
{
- struct gpio_descs *reset_gpios = pwrseq->reset_gpios;
-
- if (!IS_ERR(reset_gpios)) {
+ if (!IS_ERR(gpios)) {
int i;
- int values[reset_gpios->ndescs];
+ int values[gpios->ndescs];
- for (i = 0; i < reset_gpios->ndescs; i++)
+ for (i = 0; i < gpios->ndescs; i++)
values[i] = value;
- gpiod_set_array_value_cansleep(
- reset_gpios->ndescs, reset_gpios->desc, values);
+ gpiod_set_array_value_cansleep(gpios->ndescs, gpios->desc, values);
}
}
@@ -60,17 +59,19 @@ static void mmc_pwrseq_simple_pre_power_on(struct mmc_host *host)
pwrseq->clk_enabled = true;
}
- mmc_pwrseq_simple_set_gpios_value(pwrseq, 1);
+ mmc_pwrseq_simple_set_gpios_value(pwrseq, pwrseq->reset_gpios, 1);
if (pwrseq->pre_power_on_delay_ms)
msleep(pwrseq->pre_power_on_delay_ms);
+
+ mmc_pwrseq_simple_set_gpios_value(pwrseq, pwrseq->pwrdn_gpios, 1);
}
static void mmc_pwrseq_simple_post_power_on(struct mmc_host *host)
{
struct mmc_pwrseq_simple *pwrseq = to_pwrseq_simple(host->pwrseq);
- mmc_pwrseq_simple_set_gpios_value(pwrseq, 0);
+ mmc_pwrseq_simple_set_gpios_value(pwrseq, pwrseq->reset_gpios, 0);
if (pwrseq->post_power_on_delay_ms)
msleep(pwrseq->post_power_on_delay_ms);
@@ -80,12 +81,14 @@ static void mmc_pwrseq_simple_power_off(struct mmc_host *host)
{
struct mmc_pwrseq_simple *pwrseq = to_pwrseq_simple(host->pwrseq);
- mmc_pwrseq_simple_set_gpios_value(pwrseq, 1);
+ mmc_pwrseq_simple_set_gpios_value(pwrseq, pwrseq->reset_gpios, 1);
+ mmc_pwrseq_simple_set_gpios_value(pwrseq, pwrseq->pwrdn_gpios, 1);
if (!IS_ERR(pwrseq->ext_clk) && pwrseq->clk_enabled) {
clk_disable_unprepare(pwrseq->ext_clk);
pwrseq->clk_enabled = false;
}
+
}
static const struct mmc_pwrseq_ops mmc_pwrseq_simple_ops = {
@@ -121,6 +124,9 @@ static int mmc_pwrseq_simple_probe(struct platform_device *pdev)
return PTR_ERR(pwrseq->reset_gpios);
}
+ pwrseq->pwrdn_gpios = devm_gpiod_get_array(dev, "pwrdn",
+ GPIOD_OUT_HIGH);
+
device_property_read_u32(dev, "pre-power-on-delay-ms",
&pwrseq->pre_power_on_delay_ms);
--
2.7.4
next prev parent reply other threads:[~2016-12-02 6:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 6:17 [PATCH 0/4] mmc: pwrseq-simple: add various functionality for devices Matt Ranostay
2016-12-02 6:17 ` Matt Ranostay [this message]
2016-12-02 6:47 ` [PATCH 2/4] mmc: pwrseq-simple: add support for power down GPIO pins Ulf Hansson
[not found] ` <1480659462-29536-1-git-send-email-matt-sk+viVC6FLCDq+mSdOJa79kegs52MxvZ@public.gmane.org>
2016-12-02 6:17 ` [PATCH 1/4] mmc: pwrseq-simple: add an optional pre-power-on-delay Matt Ranostay
2016-12-02 6:17 ` [PATCH 3/4] mmc: pwrseq-simple: allow inverting of off state logic Matt Ranostay
[not found] ` <1480659462-29536-4-git-send-email-matt-sk+viVC6FLCDq+mSdOJa79kegs52MxvZ@public.gmane.org>
2016-12-02 6:57 ` Ulf Hansson
2016-12-02 7:28 ` Matt Ranostay
[not found] ` <313A249C-2BB9-487E-AF75-02ADB8AE83CC-sk+viVC6FLCDq+mSdOJa79kegs52MxvZ@public.gmane.org>
2016-12-02 8:24 ` Matt Ranostay
2016-12-02 6:17 ` [PATCH 4/4] mmc: pwrseq-simple: add disable-post-power-on option Matt Ranostay
2016-12-02 7:13 ` Ulf Hansson
[not found] ` <B85DDAB6-D86B-4DD9-BF2C-BCB9FA09CD15@ranostay.consulting>
[not found] ` <CAPDyKFp9t1SEwQZ=uTHegbpgxxevQEy4kC=wPkc8Bo16030MNg@mail.gmail.com>
[not found] ` <CAPDyKFp9t1SEwQZ=uTHegbpgxxevQEy4kC=wPkc8Bo16030MNg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-12-02 9:06 ` Matt Ranostay
2016-12-09 18:09 ` Rob Herring
2016-12-10 5:47 ` Matt Ranostay
2016-12-13 8:01 ` Ulf Hansson
2016-12-15 1:46 ` Matt Ranostay
2016-12-19 0:01 ` Matt Ranostay
2016-12-30 8:05 ` Linus Walleij
2017-01-09 4:53 ` Matt Ranostay
[not found] ` <CAJ_EiSQYz2aEGiCv2npxmby0nHwmJJyR_jzY5wJOK98zp6Bvzg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-11 22:55 ` Ulf Hansson
[not found] ` <CAPDyKFp5j5ZqJkavCSYwWQ7nKtjOqCTv=ubhjYRsSEJUw07e3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-12 4:43 ` Matt Ranostay
2017-01-12 15:57 ` Ulf Hansson
2017-01-13 3:12 ` Matt Ranostay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480659462-29536-3-git-send-email-matt@ranostay.consulting \
--to=matt@ranostay.consulting \
--cc=devicetree@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).