devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sean Wang <sean.wang@mediatek.com>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: kbuild test robot <lkp@intel.com>,
	kbuild-all@01.org, mchehab@osg.samsung.com, hdegoede@redhat.com,
	hkallweit1@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
	matthias.bgg@gmail.com, hverkuil@xs4all.nl, sean@mess.org,
	ivo.g.dimitrov.75@gmail.com, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, keyhaede@gmail.com
Subject: Re: [PATCH v2 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC
Date: Wed, 11 Jan 2017 17:27:19 +0800	[thread overview]
Message-ID: <1484126839.4057.32.camel@mtkswgap22> (raw)
In-Reply-To: <20170110224543.uuoa7ofkvolz6inp@gangnam.samsung>

okay, I will continue to work based on your changes unless someone else
has concerns

On Wed, 2017-01-11 at 07:45 +0900, Andi Shyti wrote:
> Hi Sean,
> 
> >    include/linux/compiler.h:253:8: sparse: attribute 'no_sanitize_address': unknown attribute
> > >> drivers/media/rc/mtk-cir.c:215:41: sparse: too many arguments for function devm_rc_allocate_device
> >    drivers/media/rc/mtk-cir.c: In function 'mtk_ir_probe':
> >    drivers/media/rc/mtk-cir.c:215:11: error: too many arguments to function 'devm_rc_allocate_device'
> >      ir->rc = devm_rc_allocate_device(dev, RC_DRIVER_IR_RAW);
> >               ^~~~~~~~~~~~~~~~~~~~~~~
> >    In file included from drivers/media/rc/mtk-cir.c:22:0:
> >    include/media/rc-core.h:213:16: note: declared here
> >     struct rc_dev *devm_rc_allocate_device(struct device *dev);
> >                    ^~~~~~~~~~~~~~~~~~~~~~~
> > 
> > vim +/devm_rc_allocate_device +215 drivers/media/rc/mtk-cir.c
> > 
> >    209		ir->base = devm_ioremap_resource(dev, res);
> >    210		if (IS_ERR(ir->base)) {
> >    211			dev_err(dev, "failed to map registers\n");
> >    212			return PTR_ERR(ir->base);
> >    213		}
> >    214	
> >  > 215		ir->rc = devm_rc_allocate_device(dev, RC_DRIVER_IR_RAW);
> 
> this error comes because the patches I pointed out have not been
> applied yet. I guess you can ignore them as long as you tested
> yours on top those patches.
> 
> Andi

      reply	other threads:[~2017-01-11  9:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10  9:13 [PATCH v2 0/2] media: rc: add support for IR receiver on MT7623 SoC sean.wang
2017-01-10  9:13 ` [PATCH v2 1/2] Documentation: devicetree: Add document bindings for mtk-cir sean.wang
2017-01-10  9:13 ` [PATCH v2 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC sean.wang
     [not found]   ` <1484039631-25120-3-git-send-email-sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-01-10 11:09     ` Sean Young
2017-01-10 13:59       ` Sean Wang
2017-01-10 17:23         ` Sean Young
     [not found]           ` <20170110172355.GA27008-3XSxi2G4b3iXFJAUJl40Xg@public.gmane.org>
2017-01-11  9:19             ` Sean Wang
2017-01-10 12:07   ` kbuild test robot
     [not found]     ` <201701102015.fSM15CvI%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-01-10 22:45       ` Andi Shyti
2017-01-11  9:27         ` Sean Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484126839.4057.32.camel@mtkswgap22 \
    --to=sean.wang@mediatek.com \
    --cc=andi.shyti@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=hkallweit1@gmail.com \
    --cc=hverkuil@xs4all.nl \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=kbuild-all@01.org \
    --cc=keyhaede@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lkp@intel.com \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@osg.samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@mess.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).