From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v3 3/6] dts: exynos: add device tree support for exynos5 hdmiphy Date: Tue, 16 Oct 2012 11:03:33 +0200 Message-ID: <1484284.KGFpnYrRLi@amdc1227> References: <1350343834-23992-1-git-send-email-rahul.sharma@samsung.com> <1350343834-23992-4-git-send-email-rahul.sharma@samsung.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5357967859695393208==" Return-path: In-reply-to: <1350343834-23992-4-git-send-email-rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Rahul Sharma Cc: t.stanislaws-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, jy0922.shim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, sw0312.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, joshi-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, inki.dae-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, thomas.ab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, r.sh.open-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, prashanth.g-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, s.shirish-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org List-Id: devicetree@vger.kernel.org This is a multi-part message in MIME format. --===============5357967859695393208== Content-type: multipart/alternative; boundary=nextPart1388434.5mgOFYW2eY Content-transfer-encoding: 7Bit This is a multi-part message in MIME format. --nextPart1388434.5mgOFYW2eY Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi, On Tuesday 16 of October 2012 05:00:31 Rahul Sharma wrote: > This patch adds support for device tree based discovery for exynos5 > hdmiphy. > > Signed-off-by: Rahul Sharma > --- > .../devicetree/bindings/drm/exynos/hdmiphy.txt | 12 ++++++++++++ > arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 ++++++++++ > arch/arm/boot/dts/exynos5250.dtsi | 8 ++++++++ > arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++ > 4 files changed, 32 insertions(+), 0 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt > > diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt > b/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt new file > mode 100644 > index 0000000..c4face5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt > @@ -0,0 +1,12 @@ > +Device-Tree bindings for hdmiphy driver > + > +Required properties: > +- compatible: value should be "samsung,exynos5-hdmiphy". > +- reg: I2C address of the hdmiphy device. > + > +Example: > + > + hdmiphy { > + compatible = "samsung,exynos5-hdmiphy"; > + reg = <0x38>; > + }; > \ No newline at end of file > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts > b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 0d51678..18ac213 > 100644 > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts > @@ -79,6 +79,16 @@ > status = "disabled"; > }; > > + i2c@12CE0000 { > + samsung,i2c-sda-delay = <100>; > + samsung,i2c-max-bus-freq = <66000>; > + > + hdmiphy@38 { > + compatible = "samsung,exynos5-hdmiphy"; > + reg = <0x38>; > + }; > + }; > + > dwmmc_0: dwmmc0@12200000 { > num-slots = <1>; > supports-highspeed; > diff --git a/arch/arm/boot/dts/exynos5250.dtsi > b/arch/arm/boot/dts/exynos5250.dtsi index 4064b6a..242079a 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -152,6 +152,14 @@ > #size-cells = <0>; > }; > > + i2c@12CE0000 { > + compatible = "samsung,s3c2440-hdmiphy-i2c"; > + reg = <0x12CE0000 0x1000>; > + interrupts = <0 64 0>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + > spi_0: spi@12d20000 { > compatible = "samsung,exynos4210-spi"; > reg = <0x12d20000 0x100>; > diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c > b/arch/arm/mach-exynos/mach-exynos5-dt.c index cdad7c1..3f129db 100644 > --- a/arch/arm/mach-exynos/mach-exynos5-dt.c > +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c > @@ -47,6 +47,8 @@ static const struct of_dev_auxdata > exynos5250_auxdata_lookup[] __initconst = { "s3c2440-i2c.0", NULL), > OF_DEV_AUXDATA("samsung,s3c2440-i2c", EXYNOS5_PA_IIC(1), > "s3c2440-i2c.1", NULL), > + OF_DEV_AUXDATA("samsung,s3c2440-hdmiphy-i2c", EXYNOS5_PA_IIC(8), > + "s3c2440-hdmiphy-i2c", NULL), > OF_DEV_AUXDATA("samsung,exynos5250-dw-mshc", EXYNOS5_PA_DWMCI0, > "dw_mmc.0", NULL), > OF_DEV_AUXDATA("samsung,exynos5250-dw-mshc", EXYNOS5_PA_DWMCI1, Looks fine. Reviewed-by: Tomasz Figa Best regards, -- Tomasz Figa Samsung Poland R&D Center --nextPart1388434.5mgOFYW2eY Content-Transfer-Encoding: 7Bit Content-Type: text/html; charset="us-ascii"

Hi,

 

On Tuesday 16 of October 2012 05:00:31 Rahul Sharma wrote:

> This patch adds support for device tree based discovery for exynos5

> hdmiphy.

>

> Signed-off-by: Rahul Sharma <rahul.sharma-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

> ---

> .../devicetree/bindings/drm/exynos/hdmiphy.txt | 12 ++++++++++++

> arch/arm/boot/dts/exynos5250-smdk5250.dts | 10 ++++++++++

> arch/arm/boot/dts/exynos5250.dtsi | 8 ++++++++

> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++

> 4 files changed, 32 insertions(+), 0 deletions(-)

> create mode 100644

> Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt

>

> diff --git a/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt

> b/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt new file

> mode 100644

> index 0000000..c4face5

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/drm/exynos/hdmiphy.txt

> @@ -0,0 +1,12 @@

> +Device-Tree bindings for hdmiphy driver

> +

> +Required properties:

> +- compatible: value should be "samsung,exynos5-hdmiphy".

> +- reg: I2C address of the hdmiphy device.

> +

> +Example:

> +

> + hdmiphy {

> + compatible = "samsung,exynos5-hdmiphy";

> + reg = <0x38>;

> + };

> \ No newline at end of file

> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts

> b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 0d51678..18ac213

> 100644

> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts

> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts

> @@ -79,6 +79,16 @@

> status = "disabled";

> };

>

> + i2c@12CE0000 {

> + samsung,i2c-sda-delay = <100>;

> + samsung,i2c-max-bus-freq = <66000>;

> +

> + hdmiphy@38 {

> + compatible = "samsung,exynos5-hdmiphy";

> + reg = <0x38>;

> + };

> + };

> +

> dwmmc_0: dwmmc0@12200000 {

> num-slots = <1>;

> supports-highspeed;

> diff --git a/arch/arm/boot/dts/exynos5250.dtsi

> b/arch/arm/boot/dts/exynos5250.dtsi index 4064b6a..242079a 100644

> --- a/arch/arm/boot/dts/exynos5250.dtsi

> +++ b/arch/arm/boot/dts/exynos5250.dtsi

> @@ -152,6 +152,14 @@

> #size-cells = <0>;

> };

>

> + i2c@12CE0000 {

> + compatible = "samsung,s3c2440-hdmiphy-i2c";

> + reg = <0x12CE0000 0x1000>;

> + interrupts = <0 64 0>;

> + #address-cells = <1>;

> + #size-cells = <0>;

> + };

> +

> spi_0: spi@12d20000 {

> compatible = "samsung,exynos4210-spi";

> reg = <0x12d20000 0x100>;

> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c

> b/arch/arm/mach-exynos/mach-exynos5-dt.c index cdad7c1..3f129db 100644

> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c

> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c

> @@ -47,6 +47,8 @@ static const struct of_dev_auxdata

> exynos5250_auxdata_lookup[] __initconst = { "s3c2440-i2c.0", NULL),

> OF_DEV_AUXDATA("samsung,s3c2440-i2c", EXYNOS5_PA_IIC(1),

> "s3c2440-i2c.1", NULL),

> + OF_DEV_AUXDATA("samsung,s3c2440-hdmiphy-i2c", EXYNOS5_PA_IIC(8),

> + "s3c2440-hdmiphy-i2c", NULL),

> OF_DEV_AUXDATA("samsung,exynos5250-dw-mshc", EXYNOS5_PA_DWMCI0,

> "dw_mmc.0", NULL),

> OF_DEV_AUXDATA("samsung,exynos5250-dw-mshc", EXYNOS5_PA_DWMCI1,

 

Looks fine.

 

Reviewed-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

 

Best regards,

--

Tomasz Figa

Samsung Poland R&D Center

 

--nextPart1388434.5mgOFYW2eY-- --===============5357967859695393208== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ devicetree-discuss mailing list devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org https://lists.ozlabs.org/listinfo/devicetree-discuss --===============5357967859695393208==--