From: Philipp Zabel <p.zabel@pengutronix.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] reset: uniphier: add compatible string for LD11 SD-reset block
Date: Tue, 17 Jan 2017 11:07:28 +0100 [thread overview]
Message-ID: <1484647648.4087.7.camel@pengutronix.de> (raw)
In-Reply-To: <1484420686-28911-1-git-send-email-yamada.masahiro@socionext.com>
On Sun, 2017-01-15 at 04:04 +0900, Masahiro Yamada wrote:
> The LD11 SoC is equipped with not only MIO-reset but also SD-reset
> for controlling RST_n pin of the eMMC device.
>
> Update the binding document and remove unneeded "." from each line
> in itemization.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied, thank you.
regards
Philipp
> ---
>
> .../devicetree/bindings/reset/uniphier-reset.txt | 47 +++++++++++-----------
> drivers/reset/reset-uniphier.c | 4 ++
> 2 files changed, 28 insertions(+), 23 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/uniphier-reset.txt b/Documentation/devicetree/bindings/reset/uniphier-reset.txt
> index 5020524..83ab0f5 100644
> --- a/Documentation/devicetree/bindings/reset/uniphier-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/uniphier-reset.txt
> @@ -6,14 +6,14 @@ System reset
>
> Required properties:
> - compatible: should be one of the following:
> - "socionext,uniphier-sld3-reset" - for sLD3 SoC.
> - "socionext,uniphier-ld4-reset" - for LD4 SoC.
> - "socionext,uniphier-pro4-reset" - for Pro4 SoC.
> - "socionext,uniphier-sld8-reset" - for sLD8 SoC.
> - "socionext,uniphier-pro5-reset" - for Pro5 SoC.
> - "socionext,uniphier-pxs2-reset" - for PXs2/LD6b SoC.
> - "socionext,uniphier-ld11-reset" - for LD11 SoC.
> - "socionext,uniphier-ld20-reset" - for LD20 SoC.
> + "socionext,uniphier-sld3-reset" - for sLD3 SoC
> + "socionext,uniphier-ld4-reset" - for LD4 SoC
> + "socionext,uniphier-pro4-reset" - for Pro4 SoC
> + "socionext,uniphier-sld8-reset" - for sLD8 SoC
> + "socionext,uniphier-pro5-reset" - for Pro5 SoC
> + "socionext,uniphier-pxs2-reset" - for PXs2/LD6b SoC
> + "socionext,uniphier-ld11-reset" - for LD11 SoC
> + "socionext,uniphier-ld20-reset" - for LD20 SoC
> - #reset-cells: should be 1.
>
> Example:
> @@ -37,14 +37,15 @@ Media I/O (MIO) reset, SD reset
>
> Required properties:
> - compatible: should be one of the following:
> - "socionext,uniphier-sld3-mio-reset" - for sLD3 SoC.
> - "socionext,uniphier-ld4-mio-reset" - for LD4 SoC.
> - "socionext,uniphier-pro4-mio-reset" - for Pro4 SoC.
> - "socionext,uniphier-sld8-mio-reset" - for sLD8 SoC.
> - "socionext,uniphier-pro5-sd-reset" - for Pro5 SoC.
> - "socionext,uniphier-pxs2-sd-reset" - for PXs2/LD6b SoC.
> - "socionext,uniphier-ld11-mio-reset" - for LD11 SoC.
> - "socionext,uniphier-ld20-sd-reset" - for LD20 SoC.
> + "socionext,uniphier-sld3-mio-reset" - for sLD3 SoC
> + "socionext,uniphier-ld4-mio-reset" - for LD4 SoC
> + "socionext,uniphier-pro4-mio-reset" - for Pro4 SoC
> + "socionext,uniphier-sld8-mio-reset" - for sLD8 SoC
> + "socionext,uniphier-pro5-sd-reset" - for Pro5 SoC
> + "socionext,uniphier-pxs2-sd-reset" - for PXs2/LD6b SoC
> + "socionext,uniphier-ld11-mio-reset" - for LD11 SoC (MIO)
> + "socionext,uniphier-ld11-sd-reset" - for LD11 SoC (SD)
> + "socionext,uniphier-ld20-sd-reset" - for LD20 SoC
> - #reset-cells: should be 1.
>
> Example:
> @@ -68,13 +69,13 @@ Peripheral reset
>
> Required properties:
> - compatible: should be one of the following:
> - "socionext,uniphier-ld4-peri-reset" - for LD4 SoC.
> - "socionext,uniphier-pro4-peri-reset" - for Pro4 SoC.
> - "socionext,uniphier-sld8-peri-reset" - for sLD8 SoC.
> - "socionext,uniphier-pro5-peri-reset" - for Pro5 SoC.
> - "socionext,uniphier-pxs2-peri-reset" - for PXs2/LD6b SoC.
> - "socionext,uniphier-ld11-peri-reset" - for LD11 SoC.
> - "socionext,uniphier-ld20-peri-reset" - for LD20 SoC.
> + "socionext,uniphier-ld4-peri-reset" - for LD4 SoC
> + "socionext,uniphier-pro4-peri-reset" - for Pro4 SoC
> + "socionext,uniphier-sld8-peri-reset" - for sLD8 SoC
> + "socionext,uniphier-pro5-peri-reset" - for Pro5 SoC
> + "socionext,uniphier-pxs2-peri-reset" - for PXs2/LD6b SoC
> + "socionext,uniphier-ld11-peri-reset" - for LD11 SoC
> + "socionext,uniphier-ld20-peri-reset" - for LD20 SoC
> - #reset-cells: should be 1.
>
> Example:
> diff --git a/drivers/reset/reset-uniphier.c b/drivers/reset/reset-uniphier.c
> index 968c3ae..9c11be3 100644
> --- a/drivers/reset/reset-uniphier.c
> +++ b/drivers/reset/reset-uniphier.c
> @@ -390,6 +390,10 @@ static const struct of_device_id uniphier_reset_match[] = {
> .data = uniphier_sld3_mio_reset_data,
> },
> {
> + .compatible = "socionext,uniphier-ld11-sd-reset",
> + .data = uniphier_pro5_sd_reset_data,
> + },
> + {
> .compatible = "socionext,uniphier-ld20-sd-reset",
> .data = uniphier_pro5_sd_reset_data,
> },
prev parent reply other threads:[~2017-01-17 10:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-14 19:04 [PATCH] reset: uniphier: add compatible string for LD11 SD-reset block Masahiro Yamada
2017-01-17 10:07 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484647648.4087.7.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).