From: Krzysztof Kozlowski <krzk@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>,
florin.leotescu@oss.nxp.com, Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Shych <michaelsh@nvidia.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: viorel.suman@nxp.com, carlos.song@nxp.com,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
Florin Leotescu <florin.leotescu@nxp.com>
Subject: Re: [PATCH v2 3/3] dt-bindings: hwmon: emc2305: Add YAML binding documentation for emc2305 driver
Date: Thu, 20 Feb 2025 09:31:20 +0100 [thread overview]
Message-ID: <14863a52-f2ab-42ef-be86-b9da2a8d76df@kernel.org> (raw)
In-Reply-To: <ae40d143-a5ca-4a38-844f-ca58a06834a5@roeck-us.net>
On 19/02/2025 16:52, Guenter Roeck wrote:
> On 2/19/25 06:01, Krzysztof Kozlowski wrote:
> [ ... ]
>
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - hwmon,emc2301
>>> + - hwmon,emc2302
>>> + - hwmon,emc2303
>>> + - hwmon,emc2305
>>
>> Nope.
>>
>> Was it ever internally reviewed?
>>
> No. I intentionally do not review bindings because I notoriously get it wrong,
> and instead rely on DT maintainers.
>
> I agree though that this one is really bad :-(
Wait, my comment was not towards you, but towards NXP and their internal
review. NXP is a big company, not individual contributor, so they should
use internal review to catch obvious issues instead of using community
resources for such trivial tasks.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-20 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 13:32 [PATCH v2 0/3] emc2305 driver updates florin.leotescu
2025-02-19 13:32 ` [PATCH v2 1/3] hwmon: emc2305: Update cooling device registration to include device node florin.leotescu
2025-02-19 13:32 ` [PATCH v2 2/3] hwmon: emc2305: Add device tree support for polarity and pwm output florin.leotescu
2025-02-19 13:32 ` [PATCH v2 3/3] dt-bindings: hwmon: emc2305: Add YAML binding documentation for emc2305 driver florin.leotescu
2025-02-19 13:53 ` Fabio Estevam
2025-02-19 14:01 ` Krzysztof Kozlowski
2025-02-19 15:52 ` Guenter Roeck
2025-02-20 8:31 ` Krzysztof Kozlowski [this message]
2025-02-19 14:30 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14863a52-f2ab-42ef-be86-b9da2a8d76df@kernel.org \
--to=krzk@kernel.org \
--cc=carlos.song@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florin.leotescu@nxp.com \
--cc=florin.leotescu@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=michaelsh@nvidia.com \
--cc=robh@kernel.org \
--cc=viorel.suman@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).