From: Peter Chen <peter.chen@nxp.com>
To: gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
ulf.hansson@linaro.org, broonie@kernel.org, sre@kernel.org,
robh+dt@kernel.org, shawnguo@kernel.org, rjw@rjwysocki.net,
dbaryshkov@gmail.com
Cc: heiko@sntech.de, linux-arm-kernel@lists.infradead.org,
p.zabel@pengutronix.de, devicetree@vger.kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
linux-usb@vger.kernel.org, arnd@arndb.de, s.hauer@pengutronix.de,
mail@maciej.szmigiero.name, troy.kisky@boundarydevices.com,
festevam@gmail.com, oscar@naiandei.net, stephen.boyd@linaro.org,
linux-pm@vger.kernel.org, stillcompiling@gmail.com,
linux-kernel@vger.kernel.org, mka@chromium.org,
vaibhav.hiremath@linaro.org, gary.bisson@boundarydevices.com,
hverkuil@xs4all.nl, krzk@kernel.org, frank.li@nxp.com,
jun.li@nxp.com, Peter Chen <peter.chen@nxp.com>
Subject: [PATCH v13 11/12] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property
Date: Sat, 11 Feb 2017 09:27:22 +0800 [thread overview]
Message-ID: <1486776443-2280-12-git-send-email-peter.chen@nxp.com> (raw)
In-Reply-To: <1486776443-2280-1-git-send-email-peter.chen@nxp.com>
The current dts describes USB HUB's property at USB controller's
entry, it is improper. The USB HUB should be the child node
under USB controller, and power sequence properties are under
it. Besides, using gpio pinctrl setting for USB2415's reset pin.
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
---
arch/arm/boot/dts/imx6qdl-udoo.dtsi | 26 ++++++++++++--------------
1 file changed, 12 insertions(+), 14 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl-udoo.dtsi b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
index c96c91d..a173de2 100644
--- a/arch/arm/boot/dts/imx6qdl-udoo.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-udoo.dtsi
@@ -9,6 +9,8 @@
*
*/
+#include <dt-bindings/gpio/gpio.h>
+
/ {
aliases {
backlight = &backlight;
@@ -58,17 +60,6 @@
#address-cells = <1>;
#size-cells = <0>;
- reg_usb_h1_vbus: regulator@0 {
- compatible = "regulator-fixed";
- reg = <0>;
- regulator-name = "usb_h1_vbus";
- regulator-min-microvolt = <5000000>;
- regulator-max-microvolt = <5000000>;
- enable-active-high;
- startup-delay-us = <2>; /* USB2415 requires a POR of 1 us minimum */
- gpio = <&gpio7 12 0>;
- };
-
reg_panel: regulator@1 {
compatible = "regulator-fixed";
reg = <1>;
@@ -188,7 +179,7 @@
pinctrl_usbh: usbhgrp {
fsl,pins = <
- MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x80000000
+ MX6QDL_PAD_GPIO_17__GPIO7_IO12 0x1b0b0
MX6QDL_PAD_NANDF_CS2__CCM_CLKO2 0x130b0
>;
};
@@ -259,9 +250,16 @@
&usbh1 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_usbh>;
- vbus-supply = <®_usb_h1_vbus>;
- clocks = <&clks IMX6QDL_CLK_CKO>;
status = "okay";
+
+ usb2415: hub@1 {
+ compatible = "usb424,2514";
+ reg = <1>;
+
+ clocks = <&clks IMX6QDL_CLK_CKO>;
+ reset-gpios = <&gpio7 12 GPIO_ACTIVE_LOW>;
+ reset-duration-us = <3000>;
+ };
};
&usdhc3 {
--
2.7.4
next prev parent reply other threads:[~2017-02-11 1:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-11 1:27 [PATCH v13 00/12] power: add power sequence library Peter Chen
2017-02-11 1:27 ` [PATCH v13 01/12] binding-doc: power: pwrseq-generic: add binding doc for generic " Peter Chen
2017-02-11 1:27 ` [PATCH v13 02/12] power: add " Peter Chen
2017-02-11 1:27 ` [PATCH v13 03/12] usb: separate out sysdev pointer from usb_bus Peter Chen
2017-02-11 1:27 ` [PATCH v13 04/12] usb: chipidea: use bus->sysdev for DMA configuration Peter Chen
[not found] ` <1486776443-2280-1-git-send-email-peter.chen-3arQi8VN3Tc@public.gmane.org>
2017-02-11 1:27 ` [PATCH v13 05/12] usb: ehci: fsl: " Peter Chen
2017-02-13 12:22 ` [PATCH v13 00/12] power: add power sequence library Rafael J. Wysocki
2017-02-11 1:27 ` [PATCH v13 06/12] usb: xhci: use bus->sysdev for DMA configuration Peter Chen
2017-02-13 8:25 ` Alexander Sverdlin
2017-02-14 5:33 ` Vivek Gautam
2017-02-14 10:36 ` Roger Quadros
2017-02-14 11:44 ` Arnd Bergmann
2017-02-14 12:26 ` Roger Quadros
2017-02-14 12:58 ` Arnd Bergmann
2017-02-15 1:35 ` Peter Chen
2017-02-15 8:18 ` Roger Quadros
[not found] ` <cb3ee971-6d97-fff1-64f7-1b527559b047-l0cyMroinI0@public.gmane.org>
2017-02-15 8:51 ` Peter Chen
2017-02-15 10:10 ` Roger Quadros
2017-02-15 11:51 ` Felipe Balbi
[not found] ` <87mvdnoenw.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-02-16 1:23 ` Peter Chen
2017-02-11 1:27 ` [PATCH v13 07/12] usb: ehci: " Peter Chen
2017-02-11 1:27 ` [PATCH v13 08/12] binding-doc: usb: usb-device: add optional properties for power sequence Peter Chen
2017-02-11 1:27 ` [PATCH v13 09/12] usb: core: add power sequence handling for USB devices Peter Chen
2017-02-11 1:27 ` [PATCH v13 10/12] ARM: dts: imx6qdl: Enable usb node children with <reg> Peter Chen
2017-02-11 1:27 ` Peter Chen [this message]
2017-02-11 1:27 ` [PATCH v13 12/12] ARM: dts: imx6q-evi: Fix onboard hub reset line Peter Chen
2017-02-14 10:21 ` [PATCH v13 00/12] power: add power sequence library Roger Quadros
2017-02-15 1:38 ` Peter Chen
2017-05-16 17:28 ` Krzysztof Kozlowski
2017-05-17 1:18 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486776443-2280-12-git-send-email-peter.chen@nxp.com \
--to=peter.chen@nxp.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=gary.bisson@boundarydevices.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=hverkuil@xs4all.nl \
--cc=jun.li@nxp.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=oscar@naiandei.net \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
--cc=stephen.boyd@linaro.org \
--cc=stern@rowland.harvard.edu \
--cc=stillcompiling@gmail.com \
--cc=troy.kisky@boundarydevices.com \
--cc=ulf.hansson@linaro.org \
--cc=vaibhav.hiremath@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).