devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-acpi@vger.kernel.org, devicetree@vger.kernel.org
Cc: sudeep.holla@arm.com, lorenzo.pieralisi@arm.com,
	mika.westerberg@linux.intel.com, rafael@kernel.org,
	mark.rutland@arm.com, broonie@kernel.org, robh@kernel.org,
	ahs3@redhat.com
Subject: [PATCH v1.1 05/20] device property: Add macros for calling fwnode operations
Date: Fri, 24 Feb 2017 11:36:31 +0200	[thread overview]
Message-ID: <1487928991-14959-1-git-send-email-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <1487869276-25244-6-git-send-email-sakari.ailus@linux.intel.com>

Not all implementations may implement all fwnode operations. Instead of
leaving this up to the caller to figure out, add a few macros for the
purpose.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
since v1:

- Use correct return codes for ops returning integers. -ENXIO is returned if an op
  does not exist and -EINVAL is returned if fwnode is NULL.

 include/linux/fwnode.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/include/linux/fwnode.h b/include/linux/fwnode.h
index ede74fb..75e2a00 100644
--- a/include/linux/fwnode.h
+++ b/include/linux/fwnode.h
@@ -82,4 +82,19 @@ struct fwnode_operations {
 				    struct fwnode_endpoint *endpoint);
 };
 
+#define fwnode_has_op(fwnode, op)				\
+	((fwnode) && (fwnode)->ops && (fwnode)->ops->op)
+#define fwnode_call_int_op(fwnode, op, ...)				\
+	(fwnode ? (fwnode_has_op(fwnode, op) ?				\
+		   (fwnode)->ops->op(fwnode, ## __VA_ARGS__) : -ENXIO) : \
+	 -EINVAL)
+#define fwnode_call_ptr_op(fwnode, op, ...)		\
+	(fwnode_has_op(fwnode, op) ?			\
+	 (fwnode)->ops->op(fwnode, ## __VA_ARGS__) : NULL)
+#define fwnode_call_void_op(fwnode, op, ...)				\
+	do {								\
+		if (fwnode_has_op(fwnode, op))				\
+			(fwnode)->ops->op(fwnode, ## __VA_ARGS__);	\
+	} while (false)
+
 #endif
-- 
2.7.4


  reply	other threads:[~2017-02-24  9:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 17:00 [PATCH 00/20] Move firmware specific code to firmware specific locations Sakari Ailus
2017-02-23 17:00 ` [PATCH 01/20] device property: fwnode_property_read_string_array() may return -EILSEQ Sakari Ailus
2017-02-23 17:00 ` [PATCH 02/20] device property: Fix reading pset strings using array access functions Sakari Ailus
2017-02-23 17:00 ` [PATCH 03/20] device property: of_property_read_string_array() returns number of strings Sakari Ailus
2017-02-23 23:42   ` Rob Herring
2017-02-24  8:15     ` Sakari Ailus
2017-02-23 17:01 ` [PATCH 04/20] device property: Add operations struct for fwnode operations Sakari Ailus
2017-02-23 17:01 ` [PATCH 05/20] device property: Add macros for calling " Sakari Ailus
2017-02-24  9:36   ` Sakari Ailus [this message]
2017-02-23 17:01 ` [PATCH 06/20] device property: Introduce firmware property operations, set them Sakari Ailus
2017-02-23 17:01 ` [PATCH 07/20] device property: Use fwnode_operations for fwnode_handle_{get,put} Sakari Ailus
2017-02-23 17:01 ` [PATCH 08/20] device property: Use fwnode_operations for fwnode_property_present() Sakari Ailus
2017-02-23 17:01 ` [PATCH 09/20] device property: Use fwnode_operations for reading integer arrays Sakari Ailus
2017-02-23 17:01 ` [PATCH 10/20] device property: Read strings using string array reading functions Sakari Ailus
2017-02-23 17:01 ` [PATCH 13/20] device property: Use fwnode_operations for obtaining next child node Sakari Ailus
2017-02-23 17:01 ` [PATCH 14/20] device property: Use fwnode_operations for obtaining a named " Sakari Ailus
     [not found] ` <1487869276-25244-1-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-02-23 17:01   ` [PATCH 11/20] device property: Use fwnode_operations for reading string arrays Sakari Ailus
2017-02-23 17:01   ` [PATCH 12/20] device property: Use fwnode_operations for obtaining parent node Sakari Ailus
2017-02-23 17:01   ` [PATCH 15/20] device property: Use fwnode_operations for obtaining next graph endpoint Sakari Ailus
2017-02-23 17:01   ` [PATCH 17/20] device property: Use fwnode_operations for obtaining the remote port Sakari Ailus
2017-02-23 17:01 ` [PATCH 16/20] device property: Use fwnode_operations for obtaining the remote endpoint Sakari Ailus
2017-02-23 17:01 ` [PATCH 18/20] device property: Use fwnode_operations for obtaining the remote port parent Sakari Ailus
2017-02-23 17:01 ` [PATCH 19/20] device property: Use fwnode_operations for parsing graph endpoint Sakari Ailus
2017-02-23 17:01 ` [PATCH 20/20] device property: Implement fwnode_get_next_parent() using fwnode interface Sakari Ailus
2017-02-23 22:37 ` [PATCH 00/20] Move firmware specific code to firmware specific locations Rafael J. Wysocki
     [not found]   ` <2915459.fDeP2CYj8T-yvgW3jdyMHm1GS7QM15AGw@public.gmane.org>
2017-02-24  8:25     ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1487928991-14959-1-git-send-email-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=ahs3@redhat.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).