From: Florian Vaussard <florian.vaussard@gmail.com>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Florian Vaussard <florian.vaussard@heig-vd.ch>
Subject: [PATCH 5/6] ARM: dts: socfpga: Remove unit name for LEDs in EBV SOCrates
Date: Sat, 25 Feb 2017 06:54:28 +0100 [thread overview]
Message-ID: <1488002069-22404-6-git-send-email-florian.vaussard@heig-vd.ch> (raw)
In-Reply-To: <1488002069-22404-1-git-send-email-florian.vaussard@heig-vd.ch>
GPIO LEDs in the Cyclone5 EBV SOCrates board have a unit name but no reg
property. Indeed, GPIO LEDs do not need such a property. They do not
need a unit name neither. This will trigger the following warnings when
compiled with W=1:
Node /gpio-leds/led@0 has a unit name, but no reg property
Node /gpio-leds/led@1 has a unit name, but no reg property
Node /gpio-leds/led@2 has a unit name, but no reg property
The solution is to remove the unit name. In order to have unique node
names, a rename is necessary. This should be harmless as all the LEDs
have a 'label' property, hence their name do not derive from the node
name and will stay the same after this patch.
Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch>
---
arch/arm/boot/dts/socfpga_cyclone5_socrates.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts b/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
index 8e3b017..53bf99e 100644
--- a/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
+++ b/arch/arm/boot/dts/socfpga_cyclone5_socrates.dts
@@ -60,18 +60,18 @@
&leds {
compatible = "gpio-leds";
- led@0 {
+ led0 {
label = "led:green:heartbeat";
gpios = <&porta 28 1>;
linux,default-trigger = "heartbeat";
};
- led@1 {
+ led1 {
label = "led:green:D7";
gpios = <&portb 19 1>;
};
- led@2 {
+ led2 {
label = "led:green:D8";
gpios = <&portb 25 1>;
};
--
2.7.4
next prev parent reply other threads:[~2017-02-25 5:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-25 5:54 [PATCH 0/6] ARM: dts: socfpga: Fix dtc warnings Florian Vaussard
2017-02-25 5:54 ` [PATCH 1/6] ARM: dts: socfpga: Add unit name to clock nodes Florian Vaussard
2017-02-25 5:54 ` [PATCH 2/6] ARM: dts: socfpga: Add unit name to memory nodes Florian Vaussard
2017-02-25 5:54 ` [PATCH 3/6] ARM: dts: socfpga: Remove unneeded unit names Florian Vaussard
2017-02-25 5:54 ` [PATCH 4/6] ARM: dts: socfpga: Remove unneeded reg from stmpe_touchscreen Florian Vaussard
2017-02-25 5:54 ` Florian Vaussard [this message]
[not found] ` <1488002069-22404-1-git-send-email-florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
2017-02-25 5:54 ` [PATCH 6/6] ARM: dts: socfpga: Do not include skeleton.dtsi Florian Vaussard
2017-02-27 16:45 ` [PATCH 0/6] ARM: dts: socfpga: Fix dtc warnings Dinh Nguyen
2017-02-28 10:56 ` Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488002069-22404-6-git-send-email-florian.vaussard@heig-vd.ch \
--to=florian.vaussard@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=florian.vaussard@heig-vd.ch \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).