From mboxrd@z Thu Jan 1 00:00:00 1970 From: Priit Laes Subject: Re: [PATCH 3/4] ARM: sun7i: Convert to CCU Date: Wed, 01 Mar 2017 21:41:55 +0200 Message-ID: <1488397315.29650.1.camel@plaes.org> References: <20170227210914.18954-1-plaes@plaes.org> <20170227210914.18954-4-plaes@plaes.org> Reply-To: plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org Cc: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , Russell King , Icenowy Zheng , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, 2017-02-28 at 14:01 -0300, Emilio L=C3=B3pez wrote: > Hi, >=20 > I spotted a couple of things here on a quick look, see below >=20 > El 27/02/17 a las 18:09, Priit Laes escribi=C3=B3: > > Convert sun7i-a20.dtsi to new CCU driver. > >=20 > > > > Signed-off-by: Priit Laes > > --- > > =C2=A0arch/arm/boot/dts/sun7i-a20.dtsi | 719 +++++---------------------= ------------- > > =C2=A01 file changed, 86 insertions(+), 633 deletions(-) > >=20 > > diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i= -a20.dtsi > > index 04c9977..6f80cb8 100644 > > --- a/arch/arm/boot/dts/sun7i-a20.dtsi > > +++ b/arch/arm/boot/dts/sun7i-a20.dtsi > > @@ -47,7 +47,8 @@ > > =C2=A0#include > > =C2=A0#include > > =C2=A0 > > -#include > > +#include > > +#include > > =C2=A0#include > > =C2=A0#include > > =C2=A0 > > @@ -67,19 +68,19 @@ > > > > =C2=A0 compatible =3D "allwinner,simple-framebuffer", > > > > =C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0"simple-framebuffer"; > > > > =C2=A0 allwinner,pipeline =3D "de_be0-lcd0-hdmi"; > > > > - clocks =3D <&ahb_gates 36>, <&ahb_gates 43>, > > > > - =C2=A0<&ahb_gates 44>, <&de_be0_clk>, > > > > - =C2=A0<&tcon0_ch1_clk>, <&dram_gates 26>; > > > > + clocks =3D <&ccu CLK_AHB_LCD0>, <&ccu CLK_AHB_HDMI1>, > > > > + =C2=A0<&ccu CLK_AHB_DE_BE0>, <&ccu CLK_DE_BE0>, > > > > + =C2=A0<&ccu CLK_TCON0_CH1>, <&ccu CLK_DRAM_DE_BE0>; > > > > =C2=A0 status =3D "disabled"; > > > > =C2=A0 }; > > =C2=A0 > > > > - framebuffer@1 { > > + framebuffer@0 { >=20 > This looks like an unrelated change Yup, that 's leftover from changes made during initial debugging. Will fix in v2. >=20 > > @@ -184,21 +185,11 @@ > > =C2=A0 > > > > > > =C2=A0 osc24M: clk@01c20050 { > > > > =C2=A0 #clock-cells =3D <0>; > > > > - compatible =3D "allwinner,sun4i-a10-osc-clk"; > > > > - reg =3D <0x01c20050 0x4>; > > > > + compatible =3D "fixed-clock"; > > > > =C2=A0 clock-frequency =3D <24000000>; > > > > =C2=A0 clock-output-names =3D "osc24M"; > > =C2=A0 }; >=20 > allwinner,sun4i-a10-osc-clk implements a gate apart from a fixed clock, > is the feature loss intended? This is how most of the existing drivers handle it (A13, A31, A33) so I didn't want to do anything fancy..=20 Besides, the code for clock actually configures gate: static SUNXI_CCU_GATE(hosc_clk, "hosc", "osc24M", 0x050, BIT(0), 0); P=C3=A4ikest, Priit=20 --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.