From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v7 2/6] mfd: syscon: add a DT property to set value width Date: Fri, 04 Dec 2015 17:02:53 +0100 Message-ID: <1488444.chqN1XL3OQ@wuerfel> References: <1448899191-13891-1-git-send-email-damien.riegel@savoirfairelinux.com> <20151130190015.GA31006@rob-hp-laptop> <20151202232102.GB6055@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20151202232102.GB6055@localhost> Sender: linux-kernel-owner@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: Damien Riegel , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Russell King , linux-watchdog@vger.kernel.org, Pawel Moll , Ian Campbell , Shawn Guo , linux-kernel@vger.kernel.org, Wim Van Sebroeck , Guenter Roeck , Sascha Hauer , Kumar Gala , kernel@savoirfairelinux.com, Lee Jones , Samuel Ortiz List-Id: devicetree@vger.kernel.org On Wednesday 02 December 2015 18:21:02 Damien Riegel wrote: > Lee, Arnd, > > I had to make changes in this patch to address Rob's comments. > reg-io-width is now in bytes while bus-width was a value in bits. Could > you please review this patch ? Ok, that's fine. > > On Mon, Nov 30, 2015 at 01:00:15PM -0600, Rob Herring wrote: > > On Mon, Nov 30, 2015 at 10:59:47AM -0500, Damien Riegel wrote: > > > Currently syscon has a fixed configuration of 32 bits for register and > > > values widths. In some cases, it would be desirable to be able to > > > customize the value width. > > > > > > For example, certain boards (like the ones manufactured by Technologic > > > Systems) have a FPGA that is memory-mapped, but its registers are only > > > 16-bit wide. > > > > > > This patch adds an optional "reg-io-width" DT binding for syscon that > > > allows to change the width for the data bus (i.e. val_bits). If this > > > property is provided, it will also set the register stride to > > > reg-io-width's value. If not provided, the default configuration is > > > used. > > > > > > Signed-off-by: Damien Riegel > > > > Acked-by: Rob Herring > > > Acked-by: Arnd Bergmann