Re: [PATCH] drm/arcpgu: Get rid of "encoder-slave" property

[Alexey Brodkin <Alexey.Brodkin@synopsys.com>]

Hi Liviu,

On Fri, 2017-03-03 at 16:28 +0000, Liviu Dudau wrote:
> On Fri, Mar 03, 2017 at 06:19:24PM +0300, Alexey Brodkin wrote:
> > 
> > -	/* find the encoder node and initialize it */
> > -	encoder_node = of_parse_phandle(drm->dev->of_node, "encoder-slave", 0);
> > -	if (encoder_node) {
> > -		ret = arcpgu_drm_hdmi_init(drm, encoder_node);
> > -		of_node_put(encoder_node);
> > +	/* There is only one output port inside each device, find it */
> > +	port = of_graph_get_next_endpoint(pdev->dev.of_node, NULL);
> > +
> > +	if (port) {
> > +		if (of_device_is_available(port))
> > +			encoder = of_graph_get_remote_port_parent(port);
> > +		of_node_put(port);
> > +	}
> 
> You must've been looking at some old version. Current version in -next uses
> of_graph_get_remote_node() to replace all those lines you have added (see Rob
> Herring's series to introduce of_graph_get_remote_node() function)

Hm, I'm not on Linus' master tree [1] and so I thought I was quite up to date :)
Still I made a check of linux-next and don't see any changes in
"drivers/gpu/drm/arm" compared to Linus' tree.

[1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642
[2] http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/gpu/drm/arm?id=e4563f6ba71792c77aeccb2092cc23149b44e642

Could you please clarify which exact tree did you mean?

Anyways I just tried to rebase my patch on top of linux-next tree and now
video output is broken for me - I only see some garbage on top of the screen
so I'll need to investigate it first before moving forward with stuff you
proposed :)

-Alexey
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc