From: Philipp Zabel <p.zabel@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
patchwork-lst@pengutronix.de, Rob Herring <robh+dt@kernel.org>,
kernel@pengutronix.de
Subject: Re: [PATCH 3/9] gpu: ipu-v3: add driver for Prefetch Resolve Engine
Date: Mon, 06 Mar 2017 09:42:38 +0100 [thread overview]
Message-ID: <1488789758.2464.13.camel@pengutronix.de> (raw)
In-Reply-To: <1488565539.11464.1.camel@pengutronix.de>
On Fri, 2017-03-03 at 19:25 +0100, Lucas Stach wrote:
[...]
> > > +int ipu_pre_get(struct ipu_pre *pre)
> > > +{
> > > + u32 val;
> > > +
> > > + if (pre->in_use)
> > > + return -EBUSY;
> >
> > This could race for in_use ...
>
> All the PRE/PRG configuration functions are thread unsafe, with the
> premise that they are only used during an atomic commit, [...]
Oh, okay. It would be nice to point this out in a comment.
regards
Philipp
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-03-06 8:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 18:28 [PATCH 0/9] ipu-v3/imx-drm PRG/PRE extension Lucas Stach
[not found] ` <20170217182830.32618-1-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-02-17 18:28 ` [PATCH 1/9] gpu: ipu-v3: remove AXI ID setting for IC channel Lucas Stach
2017-02-20 13:04 ` Philipp Zabel
2017-02-17 18:28 ` [PATCH 2/9] gpu: ipu-v3: add DT binding for the Prefetch Resolve Engine Lucas Stach
[not found] ` <20170217182830.32618-3-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-02-20 15:01 ` Philipp Zabel
2017-02-27 17:00 ` Rob Herring
2017-02-17 18:28 ` [PATCH 3/9] gpu: ipu-v3: add driver for " Lucas Stach
[not found] ` <20170217182830.32618-4-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2017-02-20 15:20 ` Philipp Zabel
2017-03-03 18:25 ` Lucas Stach
2017-03-06 8:42 ` Philipp Zabel [this message]
2017-02-17 18:28 ` [PATCH 4/9] gpu: ipu-v3: add DT binding for the Prefetch Resolve Gasket Lucas Stach
2017-02-27 17:02 ` Rob Herring
2017-02-17 18:28 ` [PATCH 5/9] gpu: ipu-v3: add driver for " Lucas Stach
2017-02-20 15:31 ` Philipp Zabel
2017-02-17 18:28 ` [PATCH 6/9] gpu: ipu-v3: extend the IPUv3 DT binding for i.MX6 QuadPlus Lucas Stach
2017-02-27 17:04 ` Rob Herring
2017-02-17 18:28 ` [PATCH 7/9] gpu: ipu-v3: hook up PRG unit Lucas Stach
2017-02-17 18:28 ` [PATCH 8/9] drm/imx: enable/disable PRG on CRTC enable/disable Lucas Stach
2017-02-17 18:28 ` [PATCH 9/9] drm/imx: use PRG/PRE when possible Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488789758.2464.13.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=patchwork-lst@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).