From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97C2B72628; Sun, 23 Nov 2025 15:23:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763911395; cv=none; b=qFQeG2Ft4DcOXjmfu3BNuAHsFo5PcGfUbpA5AQn3Y6/PUPIFP66/vfZmXFtD0/k4PyLbssqNWxA9LLpid3eBjOtewHsFPx1YcNbrHqRtOszEtfZHzhrLUxeXc0bv/qTW0pAaKNYU1JIaE8dxjVOlesuDFekbNwifGSyFZAFWUqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763911395; c=relaxed/simple; bh=bV9VdnDHAk6ZDSrSZtDedSV3EdxNwVB7Nso4BHeAruo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=awTNgNHT22RVKZyiV4phH/UmSSAGRyY1IegIDpPi7qi7UDukkeut/vTqEby++RS/9saRqz6uCR5+pMISCxHTHnuTR05FgYxeFN5+c7lfNW0wX5ruyXGIlLjewE36J2C9dgwo+27KvjcNzY6lnhPYfZPy+E/30p9HQVeJGdsoxtQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=r/vrN2cx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="r/vrN2cx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F0666C113D0; Sun, 23 Nov 2025 15:23:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763911395; bh=bV9VdnDHAk6ZDSrSZtDedSV3EdxNwVB7Nso4BHeAruo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=r/vrN2cxXj2WcqpJ3uDxA9fa+KOhHks/Qkhg8c2OzsShHOjKUfutKQfrdQylBoujR z31I1VQjgjenCiU9r2vDpEi9hwEaabTcBFyDnGq9/0J/kHq8Ig/YTQefaU04C5c4JG 2+1tqUVLZA/lGAJiuu0VousXqm+pb5+rv6fYAbGfGZ1laAuleR4aBReD5f97VitGx1 25S49UZi5CglLcAJmcG4Uz3FpX6FrUhc/563+Zbk+jp/ZyJ6atdsgDr/7jBENHskGH +MdXNqwXCmeAlSTLvw2SA7zx5x6YyZ3w3rWwG5u63RgGM0bdH/poMVgzJQ0h5snkLb wo2IQFm/72W2A== Message-ID: <148f0db8-1c86-479f-9a21-5b9d882fec8b@kernel.org> Date: Sun, 23 Nov 2025 16:23:10 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: can: renesas,rcar-canfd: Document renesas,fd-only property To: Biju Das , "biju.das.au" , Marc Kleine-Budde , Vincent Mailhol , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , "magnus.damm" Cc: Fabrizio Castro , "linux-can@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Prabhakar Mahadev Lad References: <20251123112326.128448-1-biju.das.jz@bp.renesas.com> <20251123112326.128448-2-biju.das.jz@bp.renesas.com> <3928e893-66e1-4873-a78b-75e38e746661@kernel.org> <24a71741-df53-4726-81d1-38c9eb3ad12a@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23/11/2025 16:15, Biju Das wrote: > Hi Krzysztof Kozlowski, > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: 23 November 2025 14:22 >> Subject: Re: [PATCH v2 1/2] dt-bindings: can: renesas,rcar-canfd: Document renesas,fd-only property >> >> On 23/11/2025 15:17, Biju Das wrote: >>> Hi Krzysztof Kozlowski, >>> >>>> -----Original Message----- >>>> From: Biju Das >>>> Sent: 23 November 2025 14:06 >>>> Subject: RE: [PATCH v2 1/2] dt-bindings: can: renesas,rcar-canfd: >>>> Document renesas,fd-only property >>>> >>>> >>>> >>>>> -----Original Message----- >>>>> From: Krzysztof Kozlowski >>>>> Sent: 23 November 2025 13:26 >>>>> Subject: Re: [PATCH v2 1/2] dt-bindings: can: renesas,rcar-canfd: >>>>> Document renesas,fd-only property >>>>> >>>>> On 23/11/2025 12:23, Biju wrote: >>>>>> From: Biju Das >>>>>> >>>>>> The CANFD on RZ/{G2L,G3E} and R-Car Gen4 support 3 modes FD-Only >>>>>> mode, Classical CAN mode and CAN-FD mode. In FD-Only mode, >>>>>> communication in Classical CAN frame format is disabled. Document >>>>>> renesas,fd-only to handle this mode. As these SoCs support 3 modes, >>>>>> update the description of renesas,no-can-fd property and disallow it for R-Car Gen3. >>>>>> >>>>>> Signed-off-by: Biju Das >>>>>> --- >>>>>> v1->v2: >>>>>> * Added conditional check to disallow fd-only mode for R-Car Gen3. >>>>>> --- >>>>>> .../bindings/net/can/renesas,rcar-canfd.yaml | 24 >>>>>> ++++++++++++++++--- >>>>>> 1 file changed, 21 insertions(+), 3 deletions(-) >>>>>> >>>>>> diff --git >>>>>> a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml >>>>>> b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml >>>>>> index f4ac21c68427..a52244f0b5d1 100644 >>>>>> --- >>>>>> a/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd.yaml >>>>>> +++ b/Documentation/devicetree/bindings/net/can/renesas,rcar-canfd. >>>>>> +++ y >>>>>> +++ am >>>>>> +++ l >>>>>> @@ -125,9 +125,17 @@ properties: >>>>>> renesas,no-can-fd: >>>>>> $ref: /schemas/types.yaml#/definitions/flag >>>>>> description: >>>>>> - The controller can operate in either CAN FD only mode (default) or >>>>>> - Classical CAN only mode. The mode is global to all channels. >>>>>> - Specify this property to put the controller in Classical CAN only mode. >>>>>> + The controller can operate in either CAN-FD mode (default) or FD-Only >>>>>> + mode (RZ/{G2L,G3E} and R-Car Gen4) or Classical CAN mode. Specify this >>>>>> + property to put the controller in Classical CAN mode. >>>>>> + >>>>>> + renesas,fd-only: >>>>>> + $ref: /schemas/types.yaml#/definitions/flag >>>>>> + description: >>>>>> + The CANFD on RZ/{G2L,G3E} and R-Car Gen4 SoCs support 3 modes FD-Only >>>>>> + mode, Classical CAN mode and CAN-FD mode (default). In FD-Only mode, >>>>>> + communication in Classical CAN frame format is disabled. Specify this >>>>>> + property to put the controller in FD-Only mode. >>>>>> >>>>>> assigned-clocks: >>>>>> description: >>>>>> @@ -267,6 +275,16 @@ allOf: >>>>>> patternProperties: >>>>>> "^channel[6-7]$": false >>>>>> >>>>>> + - if: >>>>>> + properties: >>>>>> + compatible: >>>>>> + contains: >>>>>> + enum: >>>>>> + - renesas,rcar-gen3-canfd >>>>>> + then: >>>>>> + properties: >>>>>> + renesas,fd-only: false >>>>>> + >>>>> >>>>> You did not respond to my first paragraph from previous version. As >>>>> I said, you now need oneOf to restrict these, since you are not using simple enum. >>>> >>>> This is restricting for R-Car Gen3. DT binding check returns error if 'renesas,fd-only" >>>> is defined for R-Car Gen3. >>>> >>>> Am I missing anything here? >> >> Add on G2L no-can-fd and fd-only. What do you see? What is expected? > > Can you please point me to an example where two boolean properties handled > like this? I did not find one. > > In my case, oneOf check is not valid under allOf?? > > For eg: RS485, We cannot set both boolean properties active-high and active-low together. > I none of them are required then indeed not oneOf, but some if:then:. https://elixir.bootlin.com/linux/v6.4-rc7/source/Documentation/devicetree/bindings/net/qcom,ipa.yaml#L174 And that's why you should have used enum in the first place for the first property. Best regards, Krzysztof