devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: rockchip: increase SD clock frequency on Radxa Rock
@ 2017-03-21 15:40 Alexander Kochetkov
  2017-03-22 16:47 ` Heiko Stuebner
  0 siblings, 1 reply; 5+ messages in thread
From: Alexander Kochetkov @ 2017-03-21 15:40 UTC (permalink / raw)
  To: Heiko Stuebner, Rob Herring, Mark Rutland, Russell King,
	linux-arm-kernel, linux-rockchip, devicetree, linux-kernel
  Cc: Alexander Kochetkov

The patch set SD clock frequency to maximum possible to SD-card
(50MHz). This change actual clock frequency from 32MHz to 48MHz
(speedup 1.5X).

Banner line before patch: 'mmc_host mmc0: Bus speed (slot 0) = 32000000Hz
(slot req 50000000Hz, actual 32000000HZ div = 0)'.
Banner line after patch: 'mmc_host mmc0: Bus speed (slot 0) = 96000000Hz
(slot req 50000000Hz, actual 48000000HZ div = 1)'

Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>
---
 arch/arm/boot/dts/rk3188-radxarock.dts |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts b/arch/arm/boot/dts/rk3188-radxarock.dts
index 1da46d1..5b7daa4 100644
--- a/arch/arm/boot/dts/rk3188-radxarock.dts
+++ b/arch/arm/boot/dts/rk3188-radxarock.dts
@@ -302,6 +302,7 @@
 	pinctrl-0 = <&sd0_clk>, <&sd0_cmd>, <&sd0_cd>, <&sd0_bus4>;
 	vmmc-supply = <&vcc_sd0>;
 
+	clock-frequency = <50000000>;
 	bus-width = <4>;
 	cap-mmc-highspeed;
 	cap-sd-highspeed;
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: rockchip: increase SD clock frequency on Radxa Rock
  2017-03-21 15:40 [PATCH] ARM: dts: rockchip: increase SD clock frequency on Radxa Rock Alexander Kochetkov
@ 2017-03-22 16:47 ` Heiko Stuebner
  2017-03-22 17:04   ` Alexander Kochetkov
  0 siblings, 1 reply; 5+ messages in thread
From: Heiko Stuebner @ 2017-03-22 16:47 UTC (permalink / raw)
  To: Alexander Kochetkov
  Cc: Rob Herring, Mark Rutland, Russell King, linux-arm-kernel,
	linux-rockchip, devicetree, linux-kernel

Hi,

Am Dienstag, 21. März 2017, 18:40:22 CET schrieb Alexander Kochetkov:
> The patch set SD clock frequency to maximum possible to SD-card
> (50MHz). This change actual clock frequency from 32MHz to 48MHz
> (speedup 1.5X).
> 
> Banner line before patch: 'mmc_host mmc0: Bus speed (slot 0) = 32000000Hz
> (slot req 50000000Hz, actual 32000000HZ div = 0)'.
> Banner line after patch: 'mmc_host mmc0: Bus speed (slot 0) = 96000000Hz
> (slot req 50000000Hz, actual 48000000HZ div = 1)'
> 
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>

sorry, but I will not apply this patch at this time.

When testing on my radxarock with the card I always use upon entering the 
rootfs everything explodes with -110 errors, while without that patch the card 
runs stable as far as I can tell.

I also don't have the time to investigate further right now though.


Heiko

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: rockchip: increase SD clock frequency on Radxa Rock
  2017-03-22 16:47 ` Heiko Stuebner
@ 2017-03-22 17:04   ` Alexander Kochetkov
       [not found]     ` <FCE5C7E0-7BED-4600-952A-E1EBC900F814-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Alexander Kochetkov @ 2017-03-22 17:04 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Rob Herring, Mark Rutland, Russell King, LAK,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA


> 22 марта 2017 г., в 19:47, Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> написал(а):
> 
> sorry, but I will not apply this patch at this time.

> When testing on my radxarock with the card I always use upon entering the 
> rootfs everything explodes with -110 errors, while without that patch the card 
> runs stable as far as I can tell.

> I also don't have the time to investigate further right now though.

Ok. Let leave as is for now.

My radxa worked stable for a year with this settings.
And my custom rk3188 based board also has this setting. Kernel 4.8.
And I saw -110 errors only then I disconnect SD-card from board.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: rockchip: increase SD clock frequency on Radxa Rock
       [not found]     ` <FCE5C7E0-7BED-4600-952A-E1EBC900F814-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2017-03-22 17:14       ` Alexander Kochetkov
       [not found]         ` <BDFC28D2-5C1F-4406-9F0E-BF089048F7DB-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
  0 siblings, 1 reply; 5+ messages in thread
From: Alexander Kochetkov @ 2017-03-22 17:14 UTC (permalink / raw)
  To: Heiko Stuebner
  Cc: Rob Herring, Mark Rutland, Russell King, LAK,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA


> 22 марта 2017 г., в 20:04, Alexander Kochetkov <al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> написал(а):
> 
> Ok. Let leave as is for now.
> 
> My radxa worked stable for a year with this settings.

Ok, I not sure what my radxa worked stable with this settings.
Hieko, thanks for catching that.

Sorry for your time.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] ARM: dts: rockchip: increase SD clock frequency on Radxa Rock
       [not found]         ` <BDFC28D2-5C1F-4406-9F0E-BF089048F7DB-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2017-03-22 17:19           ` Heiko Stuebner
  0 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2017-03-22 17:19 UTC (permalink / raw)
  To: Alexander Kochetkov
  Cc: Rob Herring, Mark Rutland, Russell King, LAK,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Am Mittwoch, 22. März 2017, 20:14:36 CET schrieb Alexander Kochetkov:
> 
> > 22 марта 2017 г., в 20:04, Alexander Kochetkov <al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> написал(а):
> > 
> > Ok. Let leave as is for now.
> > 
> > My radxa worked stable for a year with this settings.
> 
> Ok, I not sure what my radxa worked stable with this settings.
> Hieko, thanks for catching that.
> 
> Sorry for your time.

no problem :-)
Hopefully some time in the future we'll be able to figure out where
the instability on my rock came from.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-03-22 17:19 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-21 15:40 [PATCH] ARM: dts: rockchip: increase SD clock frequency on Radxa Rock Alexander Kochetkov
2017-03-22 16:47 ` Heiko Stuebner
2017-03-22 17:04   ` Alexander Kochetkov
     [not found]     ` <FCE5C7E0-7BED-4600-952A-E1EBC900F814-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-22 17:14       ` Alexander Kochetkov
     [not found]         ` <BDFC28D2-5C1F-4406-9F0E-BF089048F7DB-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-22 17:19           ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).