From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 213CB171CD; Sat, 15 Jun 2024 19:49:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718480996; cv=none; b=qtKv+YW4pMmuaPyBg6RBl/q0VZA+hj1cykievLYS3v+Yg6u7mcZw+eCyYouRjykhT/MAIMtNvZMcvoBX3Xy4TuEE/WWZd77vK1cww5xklOWFKxLoTIS5LxPasv4P8kqjLiqbDJ3ivDlAtpgGIarsDAfEtuBmn5SpsdruENkOCtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718480996; c=relaxed/simple; bh=M+EquCU77vpXNsiviw2+UdszY5nLQ9w+gp/15wunGTg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=MAVATowO8C2fIV8HK3FtYMKAYIOuH7pcoPeoPyyx7COgBbqpoaYYMCMGf2IGSlCObdTYjlfyar6Q9K9oBpAeAa1BeY7EzDozHHfgEa4nWq0yjOnzoVl2xugRPP824RrZknsbZ26DJzh7T7QQ7DzcauSUoinle/70dBkTHmGyDLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=WiS3IJjx; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="WiS3IJjx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1718480992; bh=M+EquCU77vpXNsiviw2+UdszY5nLQ9w+gp/15wunGTg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WiS3IJjxIqpI3wnJOQAsXcTRGOLGzgKCy3vCvLo5yYy9WkkHrSqeRWNC6cf1g8DOA GxTEab6bgHxPPMpW4fpRDAlSdeWUyIxuiYfAKM+7SrsZIh8rCfOnUjE5dydXIbMnmL +ctcNx4tAhjz7ayPeqrNvg+DMf/z29cXy/7fVx3vOh2HCzloqImaR0q9Ncr+2cesVI 0YCRXBxEsJNMHUK+vF+gpXQ+JKIDGOAisL73GCh1XD+Sr+DuVePn+2+VEUBxU6tI0u NRQeJ1UFNeQ0QBU7s7GsN5Hw8MvpwSs3iTKR2BIMJFUFjrVsK9jF3w4Jj0xJekjTUD BapoExQN38+4A== Received: from arisu.localnet (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 7A88537806BA; Sat, 15 Jun 2024 19:49:49 +0000 (UTC) From: Detlev Casanova To: Jonas Karlman Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Greg Kroah-Hartman , Sebastian Reichel , Dragan Simic , Alexey Charkov , Cristian Ciocaltea , Diederik de Haas , Andy Yan , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 2/3] media: dt-bindings: rockchip: Document RK3588 Video Decoder 2 bindings Date: Sat, 15 Jun 2024 15:49:21 -0400 Message-ID: <14930500.uLZWGnKmhe@arisu> Organization: Collabora In-Reply-To: <442bbb41-40ed-4e6c-b854-02b636f09fc3@kwiboo.se> References: <20240615015734.1612108-1-detlev.casanova@collabora.com> <20240615015734.1612108-3-detlev.casanova@collabora.com> <442bbb41-40ed-4e6c-b854-02b636f09fc3@kwiboo.se> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4336728.e9J7NaK4W3"; micalg="pgp-sha256"; protocol="application/pgp-signature" --nextPart4336728.e9J7NaK4W3 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Detlev Casanova To: Jonas Karlman Date: Sat, 15 Jun 2024 15:49:21 -0400 Message-ID: <14930500.uLZWGnKmhe@arisu> Organization: Collabora In-Reply-To: <442bbb41-40ed-4e6c-b854-02b636f09fc3@kwiboo.se> MIME-Version: 1.0 On Saturday, June 15, 2024 4:11:00 A.M. EDT Jonas Karlman wrote: > Hi Detlev, > > On 2024-06-15 03:56, Detlev Casanova wrote: > > Document the Rockchip RK3588 Video Decoder 2 bindings. > > Why the need for a new schema file and not just extending existing > rockchip,vdec.yaml with a new compatible and the new clock? Yes, that can work as well indeed. I wasn't sure if different drivers could share a schema file. > > Signed-off-by: Detlev Casanova > > --- > > > > .../bindings/media/rockchip,vdec2.yaml | 80 +++++++++++++++++++ > > 1 file changed, 80 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/media/rockchip,vdec2.yaml> > > diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec2.yaml > > b/Documentation/devicetree/bindings/media/rockchip,vdec2.yaml new file > > mode 100644 > > index 000000000000..e54891b46986 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/rockchip,vdec2.yaml > > @@ -0,0 +1,80 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/media/rockchip,vdec2.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Rockchip Video Decoder 2 (VDec2) > > + > > +maintainers: > > + - Heiko Stuebner > > + > > +description: |- > > + The Rockchip rk3588 has a stateless Video Decoder that can decodes > > H.264, + HEVC, VP9 and AVS2 streams. > > + > > +properties: > > + compatible: > > + const: rockchip,rk3588-vdec2 > > I fail to see the need to call this vdec2 instead of established vdec. > > Suggest this is changed to rockchip,rk3588-vdec. Wouldn't that be misleading if rockchip,rk3399-vdec and rockchip,rk3588-vdec use different drivers ? > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + items: > > + - description: The Video decoder AXI interface clock > > + - description: The Video decoder AHB interface clock > > + - description: The Video decoder core clock > > + - description: The Video decoder CABAC clock > > + - description: The Video decoder HEVC CABAC clock > > + > > + clock-names: > > + items: > > + - const: axi > > + - const: ahb > > + - const: core > > + - const: cabac > > + - const: hevc_cabac > > + > > + assigned-clocks: true > > + > > + assigned-clock-rates: true > > + > > + power-domains: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - clocks > > + - clock-names > > + - power-domains > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + #include > > + #include > > + > > + vdec2: video-codec@fdc38100 { > > + compatible = "rockchip,rk3588-vdec2"; > > + reg = <0x0 0xfdc38100 0x0 0x500>; > > + interrupts = ; > > + clocks = <&cru ACLK_RKVDEC0>, <&cru HCLK_RKVDEC0>, <&cru > > CLK_RKVDEC0_CORE>, + <&cru CLK_RKVDEC0_CA>, <&cru > > CLK_RKVDEC0_HEVC_CA>; + clock-names = "axi", "ahc", "core", > > + "cabac", "hevc_cabac"; > > + assigned-clocks = <&cru ACLK_RKVDEC0>, <&cru CLK_RKVDEC0_CORE>, > > + <&cru CLK_RKVDEC0_CA>, <&cru > > CLK_RKVDEC0_HEVC_CA>; + assigned-clock-rates = <800000000>, > > <600000000>, > > + <600000000>, <1000000000>; > > + power-domains = <&power RK3588_PD_RKVDEC0>; > > iommus and resets seem to be missing? Indeed, even if their are not used yet, I'd make sens to already have them here to stabilize the device tree, right ? > Regards, > Jonas > > > + }; > > + > > +... --nextPart4336728.e9J7NaK4W3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEonF9IvGrXNkDg+CX5EFKUk4x7bYFAmZt8EEACgkQ5EFKUk4x 7bYTjwf/WIXcKCh+lwWCSb/nP+Pedu5hxyDwmSu0tAWPxXIRAiy4tZ74YAE4B18G /LVHurAn3+ohMhynIYmtVUIBlMPm/NMWF4MCFNVSzF9m1zoTFnmifEfuxtTz/a1S yrsSVzsHcXQXPjBPEFbGPuKUtt38sNzPt7SoFDe57C61m3h6XIliaqTgwo3yPUbA I1l4GJ7RfH6b1qLTMT6fyMwxmBBRVnp7RyidYfV5ZTD1asMESeYVY0rh/eamTAIo J7NQYopY0Cdf58Tm2MvTWRDVygr155SBVAo/t9gnnhbKPgI4h5mLOekQ8HMNlrAx TVWFJm/9LkkH52jhjBJu6Fqc0TQiZA== =GMcL -----END PGP SIGNATURE----- --nextPart4336728.e9J7NaK4W3--