From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 2/3] mmc: usdhi6rol0: add support for UHS modes Date: Thu, 21 Apr 2016 11:52:40 +0200 Message-ID: <14935418.cYIzx5HmZZ@wuerfel> References: <4129305.Ka9B8YpEaI@wuerfel> <57188ECF.70101@axis.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <57188ECF.70101@axis.com> Sender: linux-mmc-owner@vger.kernel.org To: Lars Persson Cc: Lars Persson , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, g.liakhovetski@gmx.de, ulf.hansson@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org List-Id: devicetree@vger.kernel.org On Thursday 21 April 2016 10:26:55 Lars Persson wrote: > > It is a common pattern in all upstream mmc drivers to not make the call > to mmc_regulator_set_vqmmc() when a regulator is missing. We basically > want to log errors except for the EINVAL returned in case of a missing > regulator. > > I see what you mean here: two out of four drivers calling mmc_regulator_set_vqmmc() log errors to the console. If we want all drivers to behave consistently here, how about moving that error output into the mmc_regulator_set_vqmmc() function itself? Arnd