devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
To: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC
Date: Sun, 30 Apr 2017 13:45:28 -0700	[thread overview]
Message-ID: <1493585128-12716-1-git-send-email-frowand.list@gmail.com> (raw)

From: Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org>

An undeclared variable was used in a macro that evaluates to nothing
when CONFIG_DEBUG_LOCK_ALLOC is not defined.  Change to use the correct
variable that does exist.

---

reported by kbuild test robot on on robh/for-next
   https://lkml.org/lkml/2017/4/29/134

   drivers/of/base.c: In function '__of_add_phandle_sysfs':
>> drivers/of/base.c:198:23: error: 'pp' undeclared (first use in this function)
     sysfs_bin_attr_init(&pp->attr);

Signed-off-by: Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org>
---
 drivers/of/base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index 9fe42346925b..8a7ca2a49ba8 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -195,7 +195,7 @@ int __of_add_phandle_sysfs(struct device_node *np)
 	if (!np->phandle || np->phandle == 0xffffffff)
 		return 0;
 
-	sysfs_bin_attr_init(&pp->attr);
+	sysfs_bin_attr_init(&np->attr_phandle);
 	np->attr_phandle.attr.name = "phandle";
 	np->attr_phandle.attr.mode = 0444;
 	np->attr_phandle.size = sizeof(np->phandle);
-- 
Frank Rowand <frank.rowand-7U/KSKJipcs@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2017-04-30 20:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-30 20:45 frowand.list-Re5JQEeQqe8AvxtiuMwx3w [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-04-30 20:00 [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC Frank Rowand
     [not found] ` <1493582403-12291-1-git-send-email-frank.rowand-7U/KSKJipcs@public.gmane.org>
2017-05-01 20:13   ` Rob Herring
     [not found]     ` <CAL_JsqKMB4exBFTDNFAio87JeOF0sXjMBkueizgfoiG38Mb_8A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-01 21:20       ` Rowand, Frank
     [not found]         ` <ED290C750E1B324E972B0017C9D4BAB01FDD5370-t8YLG9SB9XQEb75RT/aEbJZPSYnAH24X@public.gmane.org>
2017-05-01 22:23           ` Frank Rowand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1493585128-12716-1-git-send-email-frowand.list@gmail.com \
    --to=frowand.list-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=stephen.boyd-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).