From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1494555074.9244.2.camel@mtksdaap41> Subject: Re: [PATCH] [media] mtk-mdp: Fix g_/s_selection capture/compose logic From: Minghsiu Tsai Date: Fri, 12 May 2017 10:11:14 +0800 In-Reply-To: References: <1492057130-1194-1-git-send-email-minghsiu.tsai@mediatek.com> Content-Type: multipart/alternative; boundary="=-rnpVXM6MvLGcXpQKhNNh" MIME-Version: 1.0 To: Stanimir Varbanov Cc: Hans Verkuil , daniel.thompson@linaro.org, "Rob Herring , Mauro Carvalho Chehab" , Matthias Brugger , Daniel Kurtz , Pawel Osciak , Houlong Wei , srv_heupstream@mediatek.com, Eddie Huang , Yingjoe Chen , Wu-Cheng Li , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org List-ID: --=-rnpVXM6MvLGcXpQKhNNh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Hi Stan, On Thu, 2017-04-27 at 17:42 +0300, Stanimir Varbanov wrote: > Hi, > > On 04/13/2017 07:18 AM, Minghsiu Tsai wrote: > > From: Daniel Kurtz > > > > Experiments show that the: > > (1) mtk-mdp uses the _MPLANE form of CAPTURE/OUTPUT > > (2) CAPTURE types use CROP targets, and OUTPUT types use COMPOSE targets > > > > Signed-off-by: Daniel Kurtz > > Signed-off-by: Minghsiu Tsai > > > > --- > > drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c > > index 13afe48..8ab7ca0 100644 > > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c > > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c > > @@ -837,12 +837,12 @@ static int mtk_mdp_m2m_g_selection(struct file *file, void *fh, > > struct mtk_mdp_ctx *ctx = fh_to_ctx(fh); > > bool valid = false; > > > > - if (s->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) { > > - if (mtk_mdp_is_target_compose(s->target)) > > - valid = true; > > - } else if (s->type == V4L2_BUF_TYPE_VIDEO_OUTPUT) { > > + if (s->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) { > > if (mtk_mdp_is_target_crop(s->target)) > > valid = true; > > + } else if (s->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) { > > + if (mtk_mdp_is_target_compose(s->target)) > > + valid = true; > > } > > Using MPLANE formats in g/s_selection violates the v4l2 spec. See [1]. > Sorry for reply too late. I will fix it soon. Thanks. > > --=-rnpVXM6MvLGcXpQKhNNh Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit Hi Stan,

On Thu, 2017-04-27 at 17:42 +0300, Stanimir Varbanov wrote: 
Hi,

On 04/13/2017 07:18 AM, Minghsiu Tsai wrote:
> From: Daniel Kurtz <djkurtz@chromium.org>
> 
> Experiments show that the:
>  (1) mtk-mdp uses the _MPLANE form of CAPTURE/OUTPUT
>  (2) CAPTURE types use CROP targets, and OUTPUT types use COMPOSE targets
> 
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
> Signed-off-by: Minghsiu Tsai <minghsiu.tsai@mediatek.com>
> 
> ---
>  drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
> index 13afe48..8ab7ca0 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_m2m.c
> @@ -837,12 +837,12 @@ static int mtk_mdp_m2m_g_selection(struct file *file, void *fh,
>  	struct mtk_mdp_ctx *ctx = fh_to_ctx(fh);
>  	bool valid = false;
>  
> -	if (s->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
> -		if (mtk_mdp_is_target_compose(s->target))
> -			valid = true;
> -	} else if (s->type == V4L2_BUF_TYPE_VIDEO_OUTPUT) {
> +	if (s->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE) {
>  		if (mtk_mdp_is_target_crop(s->target))
>  			valid = true;
> +	} else if (s->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
> +		if (mtk_mdp_is_target_compose(s->target))
> +			valid = true;
>  	}

Using MPLANE formats in g/s_selection violates the v4l2 spec. See [1].

Sorry for reply too late. I will fix it soon. Thanks.


<snip>

--=-rnpVXM6MvLGcXpQKhNNh--