devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jerome Brunet <jbrunet@baylibre.com>
To: Heiner Kallweit <hkallweit1@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org,
	linux-gpio@vger.kernel.org,
	"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	Thierry Reding <treding@nvidia.com>
Subject: Re: [PATCH v2 2/6] pintrl: meson: document GPIO IRQ DT binding
Date: Wed, 17 May 2017 01:28:59 +0200	[thread overview]
Message-ID: <1494977339.2728.8.camel@baylibre.com> (raw)
In-Reply-To: <c5ea65c5-f604-d890-4e73-f53bdd47bd31@gmail.com>

On Fri, 2017-05-12 at 21:13 +0200, Heiner Kallweit wrote:
> Document the DT binding for GPIO IRQ support on Amlogic Meson SoC's.
> 
> This documentation is intentionally not placed under
> interrupt-controllers as GPIO IRQ support on these SoC's acts more
> like an interrupt multiplexer.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - remove syscon
> ---
>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index 436b8750..44422b85 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -312,6 +312,19 @@
>  				status = "disabled";
>  			};
>  
> +			gpio_irq@9880 {
> +				compatible = "amlogic,meson-gpio-interrupt";
> +				reg = <0x0 0x09880 0x0 0x10>;
> +				interrupts = <GIC_SPI 64 IRQ_TYPE_NONE>,
> +					     <GIC_SPI 65 IRQ_TYPE_NONE>,
> +					     <GIC_SPI 66 IRQ_TYPE_NONE>,
> +					     <GIC_SPI 67 IRQ_TYPE_NONE>,
> +					     <GIC_SPI 68 IRQ_TYPE_NONE>,
> +					     <GIC_SPI 69 IRQ_TYPE_NONE>,
> +					     <GIC_SPI 70 IRQ_TYPE_NONE>,
> +					     <GIC_SPI 71 IRQ_TYPE_NONE>;
> +			};
> +

Already tried the same thing:
https://marc.info/?l=devicetree&m=147758174404359&w=2

Irq maintainers reminded me that this is not correct as the device is not able
to generate these particular irqs (it is merely routing the signal) and the
flags are meaning less here


>  			watchdog@98d0 {
>  				compatible = "amlogic,meson-gx-wdt",
> "amlogic,meson-gxbb-wdt";
>  				reg = <0x0 0x098d0 0x0 0x10>;

  reply	other threads:[~2017-05-16 23:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-12 19:01 [PATCH v2 0/6] pintrl: meson: add support for GPIO IRQs Heiner Kallweit
2017-05-12 19:13 ` [PATCH v2 1/6] pintrl: meson: add interrupts to pinctrl data Heiner Kallweit
2017-05-12 19:13 ` [PATCH v2 2/6] pintrl: meson: document GPIO IRQ DT binding Heiner Kallweit
2017-05-16 23:28   ` Jerome Brunet [this message]
2017-05-17 21:02     ` Heiner Kallweit
     [not found]       ` <ec9310f1-10eb-789f-e6f7-67e0340f4c64-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-23  8:35         ` Jerome Brunet
2017-05-12 19:13 ` [PATCH v2 3/6] pintrl: meson: add DT node for GPIO IRQ on Meson GX Heiner Kallweit
2017-05-12 19:14 ` [PATCH v2 5/6] pintrl: meson: improve meson_get_bank and export it Heiner Kallweit
     [not found] ` <36164ed8-aa59-2a77-b7fc-9adce03a2fc1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-12 19:13   ` [PATCH v2 4/6] pintrl: meson: add DT node for GPIO IRQ on Meson 8 / 8b Heiner Kallweit
2017-05-12 19:14   ` [PATCH v2 6/6] pintrl: meson: add support for GPIO interrupts Heiner Kallweit
2017-05-15  8:05     ` Neil Armstrong
2017-05-15 19:00       ` Heiner Kallweit
2017-05-16  7:54         ` Neil Armstrong
2017-05-16 18:31           ` Heiner Kallweit
     [not found]             ` <fbaf536e-3416-3c4a-4902-05b56783f9c2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-16 23:16               ` Jerome Brunet
2017-05-17 20:36                 ` Heiner Kallweit
     [not found]                   ` <3dccae17-f811-bc26-e125-7ff3f0bffa7d-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-23  8:38                     ` Jerome Brunet
2017-05-28 16:01                       ` Heiner Kallweit
     [not found]     ` <dc23b800-fe69-8143-6367-d3cd801cd6db-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-05-16 23:07       ` Jerome Brunet
2017-05-17 20:20         ` Heiner Kallweit
2017-05-14 10:19 ` [PATCH v2 0/6] pintrl: meson: add support for GPIO IRQs Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1494977339.2728.8.camel@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=khilman@baylibre.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).