devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-kernel@vger.kernel.org, Jassi Brar <jassisinghbrar@gmail.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
	devicetree@vger.kernel.org, Alexey Klimov <alexey.klimov@arm.com>,
	Jassi Brar <jaswinder.singh@linaro.org>
Subject: [PATCH v2 6/6] mailbox: arm_mhu: add support to read and record mbox-name
Date: Wed, 24 May 2017 11:16:43 +0100	[thread overview]
Message-ID: <1495621003-4291-7-git-send-email-sudeep.holla@arm.com> (raw)
In-Reply-To: <1495621003-4291-1-git-send-email-sudeep.holla@arm.com>

It's sometimes useful to identify the mailbox controller with the name
as specified in the devicetree via mbox-name property especially in a
system with multiple controllers.

This patch adds support to read and record the mailbox controller name.

Cc: Alexey Klimov <alexey.klimov@arm.com>
Cc: Jassi Brar <jaswinder.singh@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/mailbox/arm_mhu.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/drivers/mailbox/arm_mhu.c b/drivers/mailbox/arm_mhu.c
index 79d2392d7f3b..08ed22e9e347 100644
--- a/drivers/mailbox/arm_mhu.c
+++ b/drivers/mailbox/arm_mhu.c
@@ -47,6 +47,7 @@ struct arm_mhu {
 	struct mhu_link mlink[MHU_NUM_PCHANS];
 	struct mbox_controller mbox;
 	struct device *dev;
+	const char *name;
 };
 
 /**
@@ -257,8 +258,8 @@ static struct mbox_chan *mhu_mbox_xlate(struct mbox_controller *mbox,
 
 	chan->con_priv = chan_info;
 
-	dev_dbg(mbox->dev, "mbox: created channel phys: %d doorbell: %d\n",
-		pchan, doorbell);
+	dev_dbg(mbox->dev, "mbox: %s, created channel phys: %d doorbell: %d\n",
+		mhu->name, pchan, doorbell);
 
 	return chan;
 }
@@ -366,6 +367,7 @@ static int mhu_probe(struct amba_device *adev, const struct amba_id *id)
 	struct mhu_mbox_pdata *pdata;
 	const struct of_device_id *match;
 	struct device *dev = &adev->dev;
+	struct device_node *np = dev->of_node;
 	int mhu_reg[MHU_NUM_PCHANS] = {
 		MHU_LP_OFFSET, MHU_HP_OFFSET, MHU_SEC_OFFSET,
 	};
@@ -395,6 +397,10 @@ static int mhu_probe(struct amba_device *adev, const struct amba_id *id)
 		return PTR_ERR(mhu->base);
 	}
 
+	err = of_property_read_string(np, "mbox-name", &mhu->name);
+	if (err)
+		mhu->name = np->full_name;
+
 	chans = devm_kcalloc(dev, max_chans, sizeof(*chans), GFP_KERNEL);
 	if (!chans)
 		return -ENOMEM;
@@ -446,7 +452,7 @@ static int mhu_probe(struct amba_device *adev, const struct amba_id *id)
 		}
 	}
 
-	dev_info(dev, "ARM MHU Mailbox registered\n");
+	dev_info(dev, "%s mailbox registered\n", mhu->name);
 	return 0;
 }
 
-- 
2.7.4

      parent reply	other threads:[~2017-05-24 10:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-24 10:16 [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode Sudeep Holla
2017-05-24 10:16 ` [PATCH v2 1/6] mailbox: arm_mhu: reorder header inclusion and drop unneeded ones Sudeep Holla
2017-05-24 10:16 ` [PATCH v2 2/6] Documentation: devicetree: add bindings to support ARM MHU doorbells Sudeep Holla
     [not found]   ` <1495621003-4291-3-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2017-05-25 13:22     ` Jassi Brar
     [not found]       ` <CABb+yY0gXDEfoRmfHPOoEKgGjp_e5B5orYZ2qjcypL7ven50hw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-25 13:23         ` Sudeep Holla
2017-05-31 17:08           ` Rob Herring
2017-05-31 17:12             ` Sudeep Holla
2017-06-02  5:45             ` Jassi Brar
     [not found]               ` <CABb+yY1mA5Hzce5c5JGVtqmRjoTBj=YTZcajVpANq1oQP0Gc0A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-02  9:32                 ` Sudeep Holla
     [not found]                   ` <9a38040c-8062-870e-ab2a-beb4934428b3-5wv7dgnIgG8@public.gmane.org>
2017-07-05 18:02                     ` Sudeep Holla
     [not found]                       ` <73cf3d55-f2ec-eb15-746a-0db5e7e28dad-5wv7dgnIgG8@public.gmane.org>
2017-07-06  6:28                         ` Jassi Brar
     [not found]                           ` <CABb+yY04F0zuiD8iW=m2wPCqftoe+VmcGzzRCXp184JKr25KPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06  9:18                             ` Sudeep Holla
2017-07-06  9:27                               ` Jassi Brar
     [not found]                                 ` <CABb+yY3QRz9pcSTMsgNUnBkzQAedFFbbwu0fXY-2oJCFARz60g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06  9:33                                   ` Sudeep Holla
2017-07-06 14:37                                     ` Jassi Brar
     [not found]                                       ` <CABb+yY3GdAGeWUUyFfofff7Y9=j5DK-QcLXua1o-a6Hb_+nNcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-06 16:44                                         ` Sudeep Holla
     [not found]                                           ` <36ea8010-f22a-e0d9-b9a9-bb6be19db45d-5wv7dgnIgG8@public.gmane.org>
2017-07-06 18:37                                             ` Jassi Brar
     [not found]                                               ` <CABb+yY0j--t-VcOJnMxq25gnsb+QGi5ifw_K4qu1vgTJjKXBxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-07-07 11:32                                                 ` Sudeep Holla
     [not found]                                                   ` <aef7fc89-5e4d-95c6-cee3-444c4c89a113-5wv7dgnIgG8@public.gmane.org>
2017-07-07 13:12                                                     ` Jassi Brar
2017-07-07 13:32                                                       ` Sudeep Holla
2017-05-25 16:04       ` Sudeep Holla
     [not found] ` <1495621003-4291-1-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org>
2017-05-24 10:16   ` [PATCH v2 3/6] mailbox: arm_mhu: migrate to threaded irq handler Sudeep Holla
2017-05-24 10:16   ` [PATCH v2 5/6] mailbox: arm_mhu: add full support for the doorbells Sudeep Holla
2017-05-24 10:56   ` [PATCH v2 0/6] mailbox: arm_mhu: add support for doorbell mode Jassi Brar
     [not found]     ` <CABb+yY1eS_cXjCCpgQs18-W3KXPy-K7mPJSkWNb6wFe-is5fDw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-25 11:30       ` Sudeep Holla
     [not found]         ` <cd57b90c-4250-64df-9142-d12ac7ed7ad3-5wv7dgnIgG8@public.gmane.org>
2017-05-25 13:20           ` Jassi Brar
     [not found]             ` <CABb+yY0jKPUW3i69jO+ZhmNum7-MS8xabns+R7hmjCOz+imgJA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-25 13:35               ` Sudeep Holla
2017-05-25 13:44                 ` Jassi Brar
     [not found]                   ` <CABb+yY1r+bQCHUxzsH3DLx1kTkz8g=jOT1_S9PnqjfBrLhe9TA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-25 13:53                     ` Sudeep Holla
     [not found]                       ` <7291e5d7-fb63-57cf-c029-7a9f3b757c35-5wv7dgnIgG8@public.gmane.org>
2017-05-25 14:07                         ` Jassi Brar
     [not found]                           ` <CABb+yY1feEpKTWA7hNzx+PjhVmX78zx8OM-uo_Z7r2TzFBSW4A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-05-25 14:15                             ` Sudeep Holla
2017-05-24 10:16 ` [PATCH v2 4/6] mailbox: arm_mhu: re-factor data structure to add doorbell support Sudeep Holla
2017-05-24 10:16 ` Sudeep Holla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1495621003-4291-7-git-send-email-sudeep.holla@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=alexey.klimov@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=jaswinder.singh@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).