From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Brendan Higgins <brendanhiggins@google.com>,
wsa@the-dreams.de, robh+dt@kernel.org, mark.rutland@arm.com,
tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
joel@jms.id.au, vz@mleia.com, mouse@mayc.ru, clg@kaod.org,
ryan_chen@aspeedtech.com
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v9 5/5] i2c: aspeed: added slave support for Aspeed I2C driver
Date: Fri, 02 Jun 2017 22:04:50 +1000 [thread overview]
Message-ID: <1496405090.2842.5.camel@kernel.crashing.org> (raw)
In-Reply-To: <20170602084603.30811-6-brendanhiggins@google.com>
On Fri, 2017-06-02 at 01:46 -0700, Brendan Higgins wrote:
> Added slave support for Aspeed I2C controller. Supports fourteen busses
> present in AST24XX and AST25XX BMC SoCs by Aspeed.
(Not an issue for merging)
Have you looked at a "mode" by which you implement just enough of the
slave support to decode smbus notifications ?
This looks like it could be useful when using pmbus devices, as some of
them use smbus notifications fairly often.
Today only one driver calls i2c_handle_smbus_host_notify() (the Intel
one of course).
Cheers,
Ben.
next prev parent reply other threads:[~2017-06-02 12:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 8:45 [PATCH v9 0/5] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2017-06-02 8:45 ` [PATCH v9 1/5] irqchip/aspeed-i2c-ic: binding docs for Aspeed I2C Interrupt Controller Brendan Higgins
2017-06-02 8:46 ` [PATCH v9 3/5] i2c: aspeed: added documentation for Aspeed I2C driver Brendan Higgins
[not found] ` <20170602084603.30811-1-brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-06-02 8:46 ` [PATCH v9 2/5] irqchip/aspeed-i2c-ic: Add I2C IRQ controller for Aspeed Brendan Higgins
2017-06-02 9:54 ` Marc Zyngier
2017-06-02 18:29 ` Brendan Higgins
2017-06-02 8:46 ` [PATCH v9 4/5] i2c: aspeed: added driver for Aspeed I2C Brendan Higgins
2017-06-02 12:02 ` Benjamin Herrenschmidt
2017-06-03 1:39 ` Brendan Higgins
2017-06-02 8:46 ` [PATCH v9 5/5] i2c: aspeed: added slave support for Aspeed I2C driver Brendan Higgins
2017-06-02 12:04 ` Benjamin Herrenschmidt [this message]
2017-06-02 18:37 ` Brendan Higgins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496405090.2842.5.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=clg@kaod.org \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=joel@jms.id.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mouse@mayc.ru \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=tglx@linutronix.de \
--cc=vz@mleia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).