[PATCH v2 1/3] dt-bindings: arm: amlogic: Add SoC information bindings

[PATCH v2 1/3] dt-bindings: arm: amlogic: Add SoC information bindings

[Neil Armstrong]

Add bindings for the SoC information register of the Amlogic SoCs.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 Documentation/devicetree/bindings/arm/amlogic.txt | 32 +++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
index 5c01e65..ae3e8ed 100644
--- a/Documentation/devicetree/bindings/arm/amlogic.txt
+++ b/Documentation/devicetree/bindings/arm/amlogic.txt
@@ -60,3 +60,35 @@ Board compatible values (alphabetically, grouped by SoC):
   - "amlogic,q201" (Meson gxm s912)
   - "kingnovel,r-box-pro" (Meson gxm S912)
   - "nexbox,a1" (Meson gxm s912)
+
+Amlogic Meson Firmware registers Interface
+------------------------------------------
+
+The Meson SoCs have a register bank with status and data shared with the
+secure firmware.
+
+Required properties:
+ - compatible: For Meson GX SoCs, must be "amlogic,meson-gx-ao-secure", "syscon", "simple-mfd"
+
+Sub-nodes should indentify components of this register interface :
+
+Meson GX SoC Information
+------------------------
+A firmware register encodes the SoC type, package and revision information on
+the Meson GX SoCs.
+If present, a device node for this register should be added.
+
+Required properties:
+  - compatible: For Meson GX SoCs, must be "amlogic,meson-gx-chipid".
+
+Example
+-------
+
+ao-secure@140 {
+	compatible = "amlogic,meson-gx-ao-secure", "syscon", "simple-mfd";
+	reg = <0x0 0x140 0x0 0x140>;
+
+	chipid {
+		compatible = "amlogic,meson-gx-chipid";
+	};
+};
-- 
1.9.1

[PATCH v2 2/3] ARM64: dts: meson-gx: Add SoC info register

[Neil Armstrong]

Add node for the Amlogic Meson GX SoC information register.

Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
---
 arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
index 436b875..50d001a 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
@@ -365,6 +365,15 @@
 				#reset-cells = <1>;
 			};
 
+			sec_AO: ao-secure@140 {
+				compatible = "amlogic,meson-gx-ao-secure", "syscon", "simple-mfd";
+				reg = <0x0 0x140 0x0 0x140>;
+
+				chipid {
+					compatible = "amlogic,meson-gx-chipid";
+				};
+			};
+
 			uart_AO: serial@4c0 {
 				compatible = "amlogic,meson-uart";
 				reg = <0x0 0x004c0 0x0 0x14>;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/3] dt-bindings: arm: amlogic: Add SoC information bindings

[Rob Herring]

On Tue, Jun 06, 2017 at 11:45:38AM +0200, Neil Armstrong wrote:
> Add bindings for the SoC information register of the Amlogic SoCs.
> 
> Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/arm/amlogic.txt | 32 +++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
> index 5c01e65..ae3e8ed 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.txt
> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt
> @@ -60,3 +60,35 @@ Board compatible values (alphabetically, grouped by SoC):
>    - "amlogic,q201" (Meson gxm s912)
>    - "kingnovel,r-box-pro" (Meson gxm S912)
>    - "nexbox,a1" (Meson gxm s912)
> +
> +Amlogic Meson Firmware registers Interface
> +------------------------------------------
> +
> +The Meson SoCs have a register bank with status and data shared with the
> +secure firmware.
> +
> +Required properties:
> + - compatible: For Meson GX SoCs, must be "amlogic,meson-gx-ao-secure", "syscon", "simple-mfd"
> +
> +Sub-nodes should indentify components of this register interface :
> +
> +Meson GX SoC Information
> +------------------------
> +A firmware register encodes the SoC type, package and revision information on
> +the Meson GX SoCs.
> +If present, a device node for this register should be added.
> +
> +Required properties:
> +  - compatible: For Meson GX SoCs, must be "amlogic,meson-gx-chipid".
> +
> +Example
> +-------
> +
> +ao-secure@140 {
> +	compatible = "amlogic,meson-gx-ao-secure", "syscon", "simple-mfd";
> +	reg = <0x0 0x140 0x0 0x140>;
> +
> +	chipid {
> +		compatible = "amlogic,meson-gx-chipid";

No registers for this block? If not, this node is pointless. 
"amlogic,meson-gx-ao-secure" should be specific enough to determine if 
you have this block or not and the driver for it can create a device if 
the OS needs it.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/3] dt-bindings: arm: amlogic: Add SoC information bindings

[Neil Armstrong]

On 06/09/2017 03:37 PM, Rob Herring wrote:
> On Tue, Jun 06, 2017 at 11:45:38AM +0200, Neil Armstrong wrote:
>> Add bindings for the SoC information register of the Amlogic SoCs.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>>  Documentation/devicetree/bindings/arm/amlogic.txt | 32 +++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
>> index 5c01e65..ae3e8ed 100644
>> --- a/Documentation/devicetree/bindings/arm/amlogic.txt
>> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt
>> @@ -60,3 +60,35 @@ Board compatible values (alphabetically, grouped by SoC):
>>    - "amlogic,q201" (Meson gxm s912)
>>    - "kingnovel,r-box-pro" (Meson gxm S912)
>>    - "nexbox,a1" (Meson gxm s912)
>> +
>> +Amlogic Meson Firmware registers Interface
>> +------------------------------------------
>> +
>> +The Meson SoCs have a register bank with status and data shared with the
>> +secure firmware.
>> +
>> +Required properties:
>> + - compatible: For Meson GX SoCs, must be "amlogic,meson-gx-ao-secure", "syscon", "simple-mfd"
>> +
>> +Sub-nodes should indentify components of this register interface :
>> +
>> +Meson GX SoC Information
>> +------------------------
>> +A firmware register encodes the SoC type, package and revision information on
>> +the Meson GX SoCs.
>> +If present, a device node for this register should be added.
>> +
>> +Required properties:
>> +  - compatible: For Meson GX SoCs, must be "amlogic,meson-gx-chipid".
>> +
>> +Example
>> +-------
>> +
>> +ao-secure@140 {
>> +	compatible = "amlogic,meson-gx-ao-secure", "syscon", "simple-mfd";
>> +	reg = <0x0 0x140 0x0 0x140>;
>> +
>> +	chipid {
>> +		compatible = "amlogic,meson-gx-chipid";
> 
> No registers for this block? If not, this node is pointless. 
> "amlogic,meson-gx-ao-secure" should be specific enough to determine if 
> you have this block or not and the driver for it can create a device if 
> the OS needs it.
> 
> Rob
> 

Well OK, but since it's a firmware interface, it can be handy to list the
possible capabilities, not especially tied to a driver.

Neil

Re: [PATCH v2 1/3] dt-bindings: arm: amlogic: Add SoC information bindings

[Rob Herring]

On Fri, Jun 9, 2017 at 8:58 AM, Neil Armstrong <narmstrong@baylibre.com> wrote:
> On 06/09/2017 03:37 PM, Rob Herring wrote:
>> On Tue, Jun 06, 2017 at 11:45:38AM +0200, Neil Armstrong wrote:
>>> Add bindings for the SoC information register of the Amlogic SoCs.
>>>
>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>>> ---
>>>  Documentation/devicetree/bindings/arm/amlogic.txt | 32 +++++++++++++++++++++++
>>>  1 file changed, 32 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.txt b/Documentation/devicetree/bindings/arm/amlogic.txt
>>> index 5c01e65..ae3e8ed 100644
>>> --- a/Documentation/devicetree/bindings/arm/amlogic.txt
>>> +++ b/Documentation/devicetree/bindings/arm/amlogic.txt
>>> @@ -60,3 +60,35 @@ Board compatible values (alphabetically, grouped by SoC):
>>>    - "amlogic,q201" (Meson gxm s912)
>>>    - "kingnovel,r-box-pro" (Meson gxm S912)
>>>    - "nexbox,a1" (Meson gxm s912)
>>> +
>>> +Amlogic Meson Firmware registers Interface
>>> +------------------------------------------
>>> +
>>> +The Meson SoCs have a register bank with status and data shared with the
>>> +secure firmware.
>>> +
>>> +Required properties:
>>> + - compatible: For Meson GX SoCs, must be "amlogic,meson-gx-ao-secure", "syscon", "simple-mfd"
>>> +
>>> +Sub-nodes should indentify components of this register interface :
>>> +
>>> +Meson GX SoC Information
>>> +------------------------
>>> +A firmware register encodes the SoC type, package and revision information on
>>> +the Meson GX SoCs.
>>> +If present, a device node for this register should be added.
>>> +
>>> +Required properties:
>>> +  - compatible: For Meson GX SoCs, must be "amlogic,meson-gx-chipid".
>>> +
>>> +Example
>>> +-------
>>> +
>>> +ao-secure@140 {
>>> +    compatible = "amlogic,meson-gx-ao-secure", "syscon", "simple-mfd";
>>> +    reg = <0x0 0x140 0x0 0x140>;
>>> +
>>> +    chipid {
>>> +            compatible = "amlogic,meson-gx-chipid";
>>
>> No registers for this block? If not, this node is pointless.
>> "amlogic,meson-gx-ao-secure" should be specific enough to determine if
>> you have this block or not and the driver for it can create a device if
>> the OS needs it.
>>
>> Rob
>>
>
> Well OK, but since it's a firmware interface, it can be handy to list the
> possible capabilities, not especially tied to a driver.

A "has-chip-id;" property would do that.

It would be better to just be very explicit about what version of
firmware you have and that can imply anything and everything you need
to know about the firmware without needing to up date the dtb every
time you need to provide a new (to Linux) firmware capability.

Rob