From: Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org,
robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pavel-+ZI9xUNit7I@public.gmane.org
Subject: [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory
Date: Wed, 14 Jun 2017 12:47:16 +0300 [thread overview]
Message-ID: <1497433639-13101-6-git-send-email-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <1497433639-13101-1-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
None of the flash operations are not mandatory and therefore there should
be no need for the flash ops structure either. Accept NULL.
Signed-off-by: Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
---
drivers/media/v4l2-core/v4l2-flash-led-class.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-flash-led-class.c b/drivers/media/v4l2-core/v4l2-flash-led-class.c
index 6d69119..fdb79da 100644
--- a/drivers/media/v4l2-core/v4l2-flash-led-class.c
+++ b/drivers/media/v4l2-core/v4l2-flash-led-class.c
@@ -18,7 +18,7 @@
#include <media/v4l2-flash-led-class.h>
#define has_flash_op(v4l2_flash, op) \
- (v4l2_flash && v4l2_flash->ops->op)
+ (v4l2_flash && v4l2_flash->ops && v4l2_flash->ops->op)
#define call_flash_op(v4l2_flash, op, arg) \
(has_flash_op(v4l2_flash, op) ? \
@@ -618,7 +618,7 @@ struct v4l2_flash *v4l2_flash_init(
struct v4l2_subdev *sd;
int ret;
- if (!fled_cdev || !ops || !config)
+ if (!fled_cdev || !config)
return ERR_PTR(-EINVAL);
led_cdev = &fled_cdev->led_cdev;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-14 9:47 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 9:47 [PATCH 0/8] Support registering lens, flash and EEPROM devices Sakari Ailus
2017-06-14 9:47 ` [PATCH 1/8] dt: bindings: Add a binding for flash devices associated to a sensor Sakari Ailus
2017-06-14 15:19 ` Rob Herring
[not found] ` <1497433639-13101-2-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-15 9:11 ` Pavel Machek
2017-06-15 9:21 ` Sebastian Reichel
2017-06-14 9:47 ` [PATCH 2/8] dt: bindings: Add lens-focus binding for image sensors Sakari Ailus
2017-06-14 15:20 ` Rob Herring
2017-06-14 9:47 ` [PATCH 3/8] dt: bindings: Add a binding for referencing EEPROM from camera sensors Sakari Ailus
2017-06-18 14:05 ` Rob Herring
[not found] ` <1497433639-13101-4-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-07-19 7:52 ` Maxime Ripard
2017-07-19 9:21 ` Sakari Ailus
2017-07-19 11:18 ` Maxime Ripard
2017-07-21 11:14 ` Sakari Ailus
[not found] ` <1497433639-13101-1-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-14 9:47 ` [PATCH 4/8] v4l2-flash: Use led_classdev instead of led_classdev_flash for indicator Sakari Ailus
2017-06-14 21:13 ` Jacek Anaszewski
2017-06-15 6:31 ` kbuild test robot
2017-06-15 10:45 ` Sebastian Reichel
2017-06-14 9:47 ` Sakari Ailus [this message]
2017-06-14 21:14 ` [PATCH 5/8] v4l2-flash: Flash ops aren't mandatory Jacek Anaszewski
[not found] ` <3e0a8823-a8b4-3f78-25e0-22d8cb8ad090-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-06-14 21:19 ` Sakari Ailus
[not found] ` <20170614211939.GR12407-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2017-06-15 12:08 ` Jacek Anaszewski
2017-06-15 9:24 ` Sebastian Reichel
2017-06-15 12:32 ` Sakari Ailus
[not found] ` <20170615123209.GD12407-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2017-06-15 12:51 ` Sebastian Reichel
2017-07-18 17:36 ` [PATCH v1.1 1/1] " Sakari Ailus
2017-07-19 11:53 ` Pavel Machek
2017-06-14 9:47 ` [PATCH 6/8] leds: as3645a: Add LED flash class driver Sakari Ailus
2017-06-14 21:15 ` Jacek Anaszewski
2017-06-14 22:10 ` Sakari Ailus
[not found] ` <20170614221028.GS12407-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2017-06-15 13:01 ` Jacek Anaszewski
2017-06-15 13:34 ` Sakari Ailus
[not found] ` <20170615133404.GF12407-S+BSfZ9RZZmRSg0ZkenSGLdO1Tsj/99ntUK59QYPAWc@public.gmane.org>
2017-06-15 13:47 ` Jacek Anaszewski
2017-06-14 21:39 ` Pavel Machek
2017-06-14 22:21 ` Sakari Ailus
2017-06-14 22:28 ` Pavel Machek
2017-06-14 22:43 ` Sakari Ailus
2017-06-15 10:43 ` Pavel Machek
2017-06-14 9:47 ` [PATCH 7/8] smiapp: Add support for flash, lens and EEPROM devices Sakari Ailus
2017-06-15 1:50 ` kbuild test robot
2017-06-16 12:07 ` Pavel Machek
2017-06-16 12:26 ` Sakari Ailus
[not found] ` <20170616122629.GL15419-z7MJbOB4PBP+e+fPlCVrcFDQ4js95KgL@public.gmane.org>
2017-06-16 13:10 ` Pavel Machek
2017-06-16 12:42 ` Pavel Machek
2017-06-16 12:45 ` Sakari Ailus
[not found] ` <20170616124526.GM15419-z7MJbOB4PBP+e+fPlCVrcFDQ4js95KgL@public.gmane.org>
2017-06-17 9:19 ` Pavel Machek
2017-06-17 12:59 ` Pavel Machek
2017-06-17 21:12 ` Pavel Machek
[not found] ` <1497433639-13101-8-git-send-email-sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-06-17 12:17 ` Pavel Machek
2017-06-14 9:47 ` [PATCH 8/8] arm: dts: omap3: N9/N950: Add AS3645A camera flash Sakari Ailus
2017-06-15 10:15 ` Sebastian Reichel
2017-06-14 9:53 ` [PATCH 0/8] Support registering lens, flash and EEPROM devices Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497433639-13101-6-git-send-email-sakari.ailus@linux.intel.com \
--to=sakari.ailus-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pavel-+ZI9xUNit7I@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).