From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryder Lee Subject: Re: [PATCH v5 1/2] PCI: mediatek: Add Mediatek PCIe host controller support Date: Thu, 29 Jun 2017 10:00:23 +0800 Message-ID: <1498701623.32475.9.camel@mtkswgap22> References: <1495338145-9384-1-git-send-email-ryder.lee@mediatek.com> <1495338145-9384-2-git-send-email-ryder.lee@mediatek.com> <20170628195325.GR17844@bhelgaas-glaptop.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170628195325.GR17844-1RhO1Y9PlrlHTL0Zs8A6p5iNqAH0jzoTYJqu5kTmcBRl57MIdRCFDg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bjorn Helgaas Cc: Bjorn Helgaas , Rob Herring , Arnd Bergmann , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Red Hung , linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, 2017-06-28 at 14:53 -0500, Bjorn Helgaas wrote: > On Sun, May 21, 2017 at 11:42:24AM +0800, Ryder Lee wrote: > > Add support for the Mediatek PCIe Gen2 controller which can > > be found on MT7623 series SoCs. > > > > Signed-off-by: Ryder Lee > > --- > > drivers/pci/host/Kconfig | 11 + > > drivers/pci/host/Makefile | 1 + > > drivers/pci/host/pcie-mediatek.c | 553 +++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 565 insertions(+) > > create mode 100644 drivers/pci/host/pcie-mediatek.c > >... > > > +static int mtk_pcie_register_host(struct pci_host_bridge *host) > > +{ > > + struct mtk_pcie *pcie = pci_host_bridge_priv(host); > > + struct pci_bus *child; > > + int err; > > + > > + pci_add_flags(PCI_REASSIGN_ALL_RSRC | PCI_REASSIGN_ALL_BUS); > > Do you really need the PCI_REASSIGN_ALL_RSRC and PCI_REASSIGN_ALL_BUS > flags? I'd like to get rid of them because we should automatically > assign resources if the firmware hasn't done it. > > Bjorn You're right! These flags are not needed and should be removed. Thanks for catching that. Ryder -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html