From: Andrew Jeffery <andrew@aj.id.au>
To: Rob Herring <robh@kernel.org>
Cc: linus.walleij@linaro.org, mark.rutland@arm.com, joel@jms.id.au,
benh@kernel.crashing.org, ryan_chen@aspeedtech.com,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH 2/4] ARM: aspeed: g5: Add USB functions to pinctrl bindings
Date: Fri, 30 Jun 2017 10:44:56 +0930 [thread overview]
Message-ID: <1498785296.5203.10.camel@aj.id.au> (raw)
In-Reply-To: <20170629203222.xwxzlawckxlpw6u5@rob-hp-laptop>
[-- Attachment #1: Type: text/plain, Size: 1565 bytes --]
On Thu, 2017-06-29 at 15:32 -0500, Rob Herring wrote:
> On Thu, Jun 29, 2017 at 03:13:24PM -0500, Rob Herring wrote:
> > On Tue, Jun 27, 2017 at 11:42:12AM +0930, Andrew Jeffery wrote:
> > > The Aspeed AST2500 SoC contains a number of USB controllers:
> > >
> > > * USB 1.1 Host Controller
> > > * USB 2.0 Host Controller (x2)
> > > * Combined USB 2.0 Virtual Hub and USB 1.1 HID Controller
> > >
> > > The controllers are exposed via two USB ports with functionality muxed
> > > as required. The following table illustrates the relationships between
> > > the ports and the controllers via the mux function names:
> > >
> > > Port | USB Version | USB Mode | Mux Function
> > > ------|--------------|--------------|-------------
> > > A | 2.0 | Virtual Hub | USB2AD
> > > A | 2.0 | Host | USB2AH
> > > B | 1.1 | HID | USB11BHID
> > > B | 2.0 | Device | USB2BD
> > > B | 2.0 | Host | USB2BH
> > >
> > > > > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > > ---
> > > Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > Acked-by: Rob Herring <robh@kernel.org>
>
> Also, when you resend, use "dt-bindings: pinctrl: ..." for the subjects
> of binding patches in this series.
Will do.
Cheers,
Andrew
>
> Rob
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-06-30 1:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 2:12 [PATCH 0/4] pinctrl: Add USB support for Aspeed SoCs Andrew Jeffery
[not found] ` <20170627021214.23323-1-andrew-zrmu5oMJ5Fs@public.gmane.org>
2017-06-27 2:12 ` [PATCH 1/4] ARM: aspeed: g4: Add USB functions to pinctrl bindings Andrew Jeffery
2017-06-27 3:53 ` Benjamin Herrenschmidt
[not found] ` <1498535619.3651.29.camel-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2017-06-30 1:13 ` Andrew Jeffery
[not found] ` <20170627021214.23323-2-andrew-zrmu5oMJ5Fs@public.gmane.org>
2017-06-29 20:12 ` Rob Herring
2017-06-29 12:53 ` [PATCH 0/4] pinctrl: Add USB support for Aspeed SoCs Linus Walleij
2017-06-30 1:24 ` Andrew Jeffery
2017-06-27 2:12 ` [PATCH 2/4] ARM: aspeed: g5: Add USB functions to pinctrl bindings Andrew Jeffery
2017-06-29 20:13 ` Rob Herring
2017-06-29 20:32 ` Rob Herring
2017-06-30 1:14 ` Andrew Jeffery [this message]
2017-06-27 2:12 ` [PATCH 3/4] pinctrl: aspeed: g4: Add USB device and host support Andrew Jeffery
2017-06-27 2:12 ` [PATCH 4/4] pinctrl: aspeed: g5: " Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498785296.5203.10.camel@aj.id.au \
--to=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linus.walleij@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).