From: Frank Rowand <frowand.list@gmail.com>
To: Jiang Jian <jiangjian@cdjrlc.com>, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: base: Remove duplicate 'of' in two places.
Date: Thu, 23 Jun 2022 22:59:29 -0500 [thread overview]
Message-ID: <14a9c8fe-410e-2c85-7d1e-733222d1902c@gmail.com> (raw)
In-Reply-To: <20220621161322.17739-1-jiangjian@cdjrlc.com>
On 6/21/22 12:13, Jiang Jian wrote:
> file: drivers/of/base.c
> line: 1152,1177
> * @matches: array of of device match structures to search in
> changed to
> * @matches: array of device match structures to search in
>
> Signed-off-by: Jiang Jian <jiangjian@cdjrlc.com>
> ---
> drivers/of/base.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/of/base.c b/drivers/of/base.c
> index d4f98c8469ed..f738939cd283 100644
> --- a/drivers/of/base.c
> +++ b/drivers/of/base.c
> @@ -1149,7 +1149,7 @@ const struct of_device_id *__of_match_node(const struct of_device_id *matches,
>
> /**
> * of_match_node - Tell if a device_node has a matching of_match structure
> - * @matches: array of of device match structures to search in
> + * @matches: array of device match structures to search in
> * @node: the of device structure to match against
> *
> * Low level utility function used by device matching.
> @@ -1174,7 +1174,7 @@ EXPORT_SYMBOL(of_match_node);
> * you pass will not be searched, only the next one
> * will; typically, you pass what the previous call
> * returned. of_node_put() will be called on it
> - * @matches: array of of device match structures to search in
> + * @matches: array of device match structures to search in
> * @match: Updated to point at the matches entry which matched
> *
> * Return: A node pointer with refcount incremented, use
"of of device" looks wrong, but 'of device' means Open Firmeare device.
So technically it is correct. If Rob wants to accept the patch then
I am ok with the acceptance, to avoid future attempts to fix.
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
prev parent reply other threads:[~2022-06-24 3:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 16:13 [PATCH] of: base: Remove duplicate 'of' in two places Jiang Jian
2022-06-24 3:59 ` Frank Rowand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14a9c8fe-410e-2c85-7d1e-733222d1902c@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jiangjian@cdjrlc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).