From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Brophy <professor_jonny@hotmail.com>,
Jonathan Brophy <professorjonny98@gmail.com>,
lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Radoslav Tsvetkov <rtsvetkov@gradotech.eu>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH 1/4] leds: Add Virtual Color LED Group driver
Date: Mon, 13 Oct 2025 02:44:28 +0200 [thread overview]
Message-ID: <14aec202-39a0-45fc-9d5f-20fb6806eca3@kernel.org> (raw)
In-Reply-To: <DS0PR84MB374668EBA934375770E4A6CA9FEAA@DS0PR84MB3746.NAMPRD84.PROD.OUTLOOK.COM>
On 13/10/2025 02:24, Jonathan Brophy wrote:
> On FRI, 10 October 2025, Krzysztof Kozlowski wrote:
>
>
>>> + if (!ret) {
>>> + vled->blink_delay_on = blink_interval;
>>> + vled->blink_delay_off = blink_interval;
>>> + }
>>> +
>>> + phandle_count = fwnode_property_count_u32(child_fwnode, "leds");
>>
>>
>> No, don't mix OF and fwnode.
>
> Thanks for the guidance I am working my way through the List if fixes and will offer a new patch set when complete.
>
> Just one question is there a preference to use Device Tree (OF) functions or FWnode functions?
> It is my under standing FWnode is newer and more universal.
I think fwnode is better, but my comment here was - choose one.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-13 0:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 8:43 [PATCH 1/4] leds: Add Virtual Color LED Group driver Jonathan Brophy
2025-10-09 8:43 ` [PATCH 2/4] dt-bindings: leds: Add YAML bindings for " Jonathan Brophy
2025-10-09 14:18 ` Krzysztof Kozlowski
2025-10-09 8:43 ` [PATCH 3/4] ABI: sysfs-class-leds-virtualcolor: Document sysfs entries for Virtual Color LEDs Jonathan Brophy
2025-10-09 8:43 ` [PATCH 4/4] dt-bindings: led: add virtual LED bindings Jonathan Brophy
2025-10-09 14:19 ` Krzysztof Kozlowski
2025-10-09 14:25 ` [PATCH 1/4] leds: Add Virtual Color LED Group driver Krzysztof Kozlowski
2025-10-13 0:24 ` Jonathan Brophy
2025-10-13 0:44 ` Krzysztof Kozlowski [this message]
2025-10-09 15:18 ` Lee Jones
2025-10-10 0:10 ` Jonathan Brophy
2025-10-10 7:59 ` Lee Jones
2025-10-10 18:12 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14aec202-39a0-45fc-9d5f-20fb6806eca3@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=professor_jonny@hotmail.com \
--cc=professorjonny98@gmail.com \
--cc=robh@kernel.org \
--cc=rtsvetkov@gradotech.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).