[PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree

[PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree

[Dan Carpenter]

Checkpatch points out that this should use spaces instead of tabs.
"ERROR: code indent should use tabs where possible".

Reported-by: Xu Yang <xu.yang_2@nxp.com>
Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 arch/arm64/boot/dts/freescale/s32g3.dtsi | 32 ++++++++++++------------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/s32g3.dtsi b/arch/arm64/boot/dts/freescale/s32g3.dtsi
index 68c11ebd405f..e80144e33efb 100644
--- a/arch/arm64/boot/dts/freescale/s32g3.dtsi
+++ b/arch/arm64/boot/dts/freescale/s32g3.dtsi
@@ -489,22 +489,22 @@ usbmisc: usbmisc@44064200 {
 			reg = <0x44064200 0x200>;
 		};
 
-                usbotg: usb@44064000 {
-                        compatible = "nxp,s32g3-usb", "nxp,s32g2-usb";
-                        reg = <0x44064000 0x200>;
-                        interrupt-parent = <&gic>;
-                        interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, /* OTG Core */
-                                     <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; /* OTG Wakeup */
-                        clocks = <&clks 94>, <&clks 95>;
-                        fsl,usbmisc = <&usbmisc 0>;
-                        ahb-burst-config = <0x3>;
-                        tx-burst-size-dword = <0x10>;
-                        rx-burst-size-dword = <0x10>;
-                        phy_type = "ulpi";
-                        dr_mode = "host";
-                        maximum-speed = "high-speed";
-                        status = "disabled";
-                };
+		usbotg: usb@44064000 {
+			compatible = "nxp,s32g3-usb", "nxp,s32g2-usb";
+			reg = <0x44064000 0x200>;
+			interrupt-parent = <&gic>;
+			interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, /* OTG Core */
+				     <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; /* OTG Wakeup */
+			clocks = <&clks 94>, <&clks 95>;
+			fsl,usbmisc = <&usbmisc 0>;
+			ahb-burst-config = <0x3>;
+			tx-burst-size-dword = <0x10>;
+			rx-burst-size-dword = <0x10>;
+			phy_type = "ulpi";
+			dr_mode = "host";
+			maximum-speed = "high-speed";
+			status = "disabled";
+		};
 
 		i2c0: i2c@401e4000 {
 			compatible = "nxp,s32g3-i2c",
-- 
2.47.2

[PATCH 3/3] arm64: dts: s32g2: Re-order usbmisc device tree section

[Dan Carpenter]

The compatible line is supposed to be first.

Reported-by: Xu Yang <xu.yang_2@nxp.com>
Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 arch/arm64/boot/dts/freescale/s32g2.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi
index 089f54415571..6f700085dec2 100644
--- a/arch/arm64/boot/dts/freescale/s32g2.dtsi
+++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi
@@ -424,8 +424,8 @@ spi2: spi@401dc000 {
 		};
 
 		usbmisc: usbmisc@44064200 {
-			#index-cells = <1>;
 			compatible = "nxp,s32g2-usbmisc";
+			#index-cells = <1>;
 			reg = <0x44064200 0x200>;
 		};
 
-- 
2.47.2

Re: [PATCH 3/3] arm64: dts: s32g2: Re-order usbmisc device tree section

[Matthias Brugger]

On 17/07/2025 00:46, Dan Carpenter wrote:
> The compatible line is supposed to be first.
> 
> Reported-by: Xu Yang <xu.yang_2@nxp.com>
> Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Matthias Brugger <mbrugger@suse.com>

> ---
>   arch/arm64/boot/dts/freescale/s32g2.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi
> index 089f54415571..6f700085dec2 100644
> --- a/arch/arm64/boot/dts/freescale/s32g2.dtsi
> +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi
> @@ -424,8 +424,8 @@ spi2: spi@401dc000 {
>   		};
>   
>   		usbmisc: usbmisc@44064200 {
> -			#index-cells = <1>;
>   			compatible = "nxp,s32g2-usbmisc";
> +			#index-cells = <1>;
>   			reg = <0x44064200 0x200>;
>   		};
>   

Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree

[Matthias Brugger]

On 17/07/2025 00:46, Dan Carpenter wrote:
> Checkpatch points out that this should use spaces instead of tabs.
> "ERROR: code indent should use tabs where possible".
> 
> Reported-by: Xu Yang <xu.yang_2@nxp.com>
> Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Matthias Brugger <mbrugger@suse.com>

> ---
>   arch/arm64/boot/dts/freescale/s32g3.dtsi | 32 ++++++++++++------------
>   1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/s32g3.dtsi b/arch/arm64/boot/dts/freescale/s32g3.dtsi
> index 68c11ebd405f..e80144e33efb 100644
> --- a/arch/arm64/boot/dts/freescale/s32g3.dtsi
> +++ b/arch/arm64/boot/dts/freescale/s32g3.dtsi
> @@ -489,22 +489,22 @@ usbmisc: usbmisc@44064200 {
>   			reg = <0x44064200 0x200>;
>   		};
>   
> -                usbotg: usb@44064000 {
> -                        compatible = "nxp,s32g3-usb", "nxp,s32g2-usb";
> -                        reg = <0x44064000 0x200>;
> -                        interrupt-parent = <&gic>;
> -                        interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, /* OTG Core */
> -                                     <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; /* OTG Wakeup */
> -                        clocks = <&clks 94>, <&clks 95>;
> -                        fsl,usbmisc = <&usbmisc 0>;
> -                        ahb-burst-config = <0x3>;
> -                        tx-burst-size-dword = <0x10>;
> -                        rx-burst-size-dword = <0x10>;
> -                        phy_type = "ulpi";
> -                        dr_mode = "host";
> -                        maximum-speed = "high-speed";
> -                        status = "disabled";
> -                };
> +		usbotg: usb@44064000 {
> +			compatible = "nxp,s32g3-usb", "nxp,s32g2-usb";
> +			reg = <0x44064000 0x200>;
> +			interrupt-parent = <&gic>;
> +			interrupts = <GIC_SPI 211 IRQ_TYPE_LEVEL_HIGH>, /* OTG Core */
> +				     <GIC_SPI 212 IRQ_TYPE_LEVEL_HIGH>; /* OTG Wakeup */
> +			clocks = <&clks 94>, <&clks 95>;
> +			fsl,usbmisc = <&usbmisc 0>;
> +			ahb-burst-config = <0x3>;
> +			tx-burst-size-dword = <0x10>;
> +			rx-burst-size-dword = <0x10>;
> +			phy_type = "ulpi";
> +			dr_mode = "host";
> +			maximum-speed = "high-speed";
> +			status = "disabled";
> +		};
>   
>   		i2c0: i2c@401e4000 {
>   			compatible = "nxp,s32g3-i2c",

Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree

[Krzysztof Kozlowski]

On 17/07/2025 00:46, Dan Carpenter wrote:
> Checkpatch points out that this should use spaces instead of tabs.
> "ERROR: code indent should use tabs where possible".
> 
> Reported-by: Xu Yang <xu.yang_2@nxp.com>
> Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---

Patches were not merged, so this should be squashed there... or you
meant they went with Greg USB? Then no, that's dissapointing, you are
not supposed to send DTS patches to Greg's subsystem.

Best regards,
Krzysztof

Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree

[Dan Carpenter]

On Fri, Jul 18, 2025 at 08:58:19AM +0200, Krzysztof Kozlowski wrote:
> On 17/07/2025 00:46, Dan Carpenter wrote:
> > Checkpatch points out that this should use spaces instead of tabs.
> > "ERROR: code indent should use tabs where possible".
> > 
> > Reported-by: Xu Yang <xu.yang_2@nxp.com>
> > Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/
> > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> > ---
> 
> Patches were not merged, so this should be squashed there... or you
> meant they went with Greg USB? Then no, that's dissapointing, you are
> not supposed to send DTS patches to Greg's subsystem.

I worry that I have accidentally stepped into politics...

Yes, it went through Greg's tree.  I'm just using get_maintainer.pl.
Looking at it now, Greg and linux-usb weren't even on the Cc list for
the DTS patches.  There was probably some b4 magic which let him apply
the whole series.

How was this supposed to have worked?

regards,
dan carpenter

Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree

[Shawn Guo]

On Fri, Jul 18, 2025 at 06:21:00PM +0300, Dan Carpenter wrote:
> On Fri, Jul 18, 2025 at 08:58:19AM +0200, Krzysztof Kozlowski wrote:
> > On 17/07/2025 00:46, Dan Carpenter wrote:
> > > Checkpatch points out that this should use spaces instead of tabs.
> > > "ERROR: code indent should use tabs where possible".
> > > 
> > > Reported-by: Xu Yang <xu.yang_2@nxp.com>
> > > Closes: https://lore.kernel.org/all/u7glt7mn33lbdeskbr4ily6tjjifvffy64llwpi5b2rrhx5tnv@y2h2y3oz3xc4/
> > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> > > ---
> > 
> > Patches were not merged, so this should be squashed there... or you
> > meant they went with Greg USB? Then no, that's dissapointing, you are
> > not supposed to send DTS patches to Greg's subsystem.
> 
> I worry that I have accidentally stepped into politics...
> 
> Yes, it went through Greg's tree.

I don't find two DTS patches in v6.17-rc1.  I tried to pick them up, but
this one doesn't apply.  So you may want to resend them.

> I'm just using get_maintainer.pl.
> Looking at it now, Greg and linux-usb weren't even on the Cc list for
> the DTS patches.  There was probably some b4 magic which let him apply
> the whole series.
> 
> How was this supposed to have worked?

The DTS changes should be sent separately from usb driver ones.

Shawn

Re: [PATCH 2/3] arm64: dts: s32g3: Fix whitespace issue in device tree

[Krzysztof Kozlowski]

On 18/07/2025 17:21, Dan Carpenter wrote:
> 
> Yes, it went through Greg's tree.  I'm just using get_maintainer.pl.
> Looking at it now, Greg and linux-usb weren't even on the Cc list for
> the DTS patches.  There was probably some b4 magic which let him apply
> the whole series.
> 
> How was this supposed to have worked?


There are few maintainers who pick up entire patchsets, including DTS.
You must not combine DTS into the same patchset targeting such
maintainers (Greg, and in the past sometimes watchdog and netdev).

Best regards,
Krzysztof