From: Jeffrey Hugo <jhugo@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: agross@kernel.org, david.brown@linaro.org,
marc.w.gonzalez@free.fr, mturquette@baylibre.com,
sboyd@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/6] arm64: dts: msm8998: Add xo clock to gcc node
Date: Wed, 1 May 2019 08:17:58 -0600 [thread overview]
Message-ID: <14d71a86-4bf7-b5f1-3efa-0938bd838ce3@codeaurora.org> (raw)
In-Reply-To: <20190501033548.GC2938@tuxbook-pro>
On 4/30/2019 9:35 PM, Bjorn Andersson wrote:
> On Tue 30 Apr 19:25 PDT 2019, Jeffrey Hugo wrote:
>
>> GCC is a consumer of the xo clock. Add a reference to the clock supplier
>> to the gcc node.
>>
>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> (Although I prefer clock-names following clocks)
Huh, I didn't even realize I did that until you pointed it out. Feel
free to adjust when you apply, or if there is another spin I'll fix it.
>
> Regards,
> Bjorn
>
>> ---
>> arch/arm64/boot/dts/qcom/msm8998.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> index 574be78..9c88801 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi
>> @@ -709,6 +709,8 @@
>> #reset-cells = <1>;
>> #power-domain-cells = <1>;
>> reg = <0x100000 0xb0000>;
>> + clock-names = "xo";
>> + clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>;
>> };
>>
>> tlmm: pinctrl@3400000 {
>> --
>> Qualcomm Datacenter Technologies as an affiliate of Qualcomm Technologies, Inc.
>> Qualcomm Technologies, Inc. is a member of the
>> Code Aurora Forum, a Linux Foundation Collaborative Project.
>>
--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2019-05-01 14:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 2:23 [PATCH v3 0/6] MSM8998 Multimedia Clock Controller Jeffrey Hugo
2019-05-01 2:24 ` [PATCH v3 1/6] dt-bindings: clock: Document external clocks for MSM8998 gcc Jeffrey Hugo
2019-05-01 3:34 ` Bjorn Andersson
2019-05-01 14:17 ` Jeffrey Hugo
2019-05-01 19:48 ` Rob Herring
2019-05-01 2:25 ` [PATCH v3 2/6] arm64: dts: msm8998: Add xo clock to gcc node Jeffrey Hugo
2019-05-01 3:35 ` Bjorn Andersson
2019-05-01 14:17 ` Jeffrey Hugo [this message]
2019-05-01 2:26 ` [PATCH v3 3/6] clk: qcom: smd: Add XO clock for MSM8998 Jeffrey Hugo
2019-05-01 3:26 ` Bjorn Andersson
2019-05-01 2:26 ` [PATCH v3 4/6] dt-bindings: clock: Add support for the MSM8998 mmcc Jeffrey Hugo
2019-05-01 3:37 ` Bjorn Andersson
2019-05-01 2:27 ` [PATCH v3 5/6] clk: qcom: Add MSM8998 Multimedia Clock Controller (MMCC) driver Jeffrey Hugo
2019-05-01 3:43 ` Bjorn Andersson
2019-05-01 14:25 ` Jeffrey Hugo
2019-05-01 16:54 ` Bjorn Andersson
2019-05-01 2:27 ` [PATCH v3 6/6] arm64: dts: qcom: msm8998: Add mmcc node Jeffrey Hugo
2019-05-01 3:44 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14d71a86-4bf7-b5f1-3efa-0938bd838ce3@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).