From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6915E51A13B; Tue, 22 Sep 2026 08:58:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790067490; cv=none; b=YvLnBTrlXisa127ltqwN74rAB9nj512ne5/pp6gXOb9w8Aepm4fsYe2VtRU2lgrvQ/bso+hEV4ZhoL8wEvdaVkwCo34D45VgMZAanufphCc6uPLHOwOq1Kfece5KNu2UpNLLjIYND3mrGfcLHijTDkiZM9WQucQ/peYuY2gXvX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790067490; c=relaxed/simple; bh=vrW9x0p853O/au0zjzgdBa+hKPpjn1ouW8qBrfGVPPY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BXWsgdotsTkP9MJDRfZOFTmpA9M07KxulqR1mJZ9zFGkOa89Mmq74ePsQcQtMtGH80ut+J5KrHmVnTH5c0Bc39LPyMV8REiRU36yEAfFZA2a9r7HEGCDp/RbL1xLLg8+LDUJjy9Bp/rR0nFM/Xbg7C6FUhsuEFAcETjsEdXOtdE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KXmIFed4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KXmIFed4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2964F1F000FF; Tue, 22 Sep 2026 08:58:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790067489; bh=qb0HPurhUwXfzK933oHu7FVbx6bhwTEcvjhtwrCu9sM=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=KXmIFed4Plw0lbcMgQ0CSWi7iZ4VyyiZsNe6xhbabHSD8W4y4klzGY3cg7cBD/RdO hZxMQuHQZWXgxg2lOOn0b/I05uzCa11EqMFjYedLxTv//fwI8K3xws3s86l8vnVRFq y/qMaFuO7fB9730eXHRuyqJGwG+LUHTfPwxWtlhBqE6Z4wLcczY/nU9KR3BU2LWPOp TS7QOeY0o4M/e6eSKKwDPAMh5GBYpPuzX7a0AoIMawuLJeBGX/oG2gJb8S5PqjJkOu fSIS8cLJM6yZqPPTYKfPvUOxU/Uo6FBMfEL5Xp7usU6HvB0gOFHlIS6DRmQIuZ6SW7 fF/SEdLeDOe5w== Message-ID: <14f2baec-41d5-49e1-8b49-04388b64e38a@kernel.org> Date: Tue, 22 Sep 2026 10:58:03 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] dt-bindings: remoteproc: add allwinner sun55i rproc binding To: Tim Michals , linux-sunxi@lists.linux.dev Cc: wens@kernel.org, jernej.skrabec@gmail.com, samuel@sholland.org, Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20260922034711.190253-1-tcmichals@gmail.com> <20260922034711.190253-5-tcmichals@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <20260922034711.190253-5-tcmichals@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 22/09/2026 05:47, Tim Michals wrote: > Add Device Tree binding schema for the Allwinner XuanTie E906/E907 > RISC-V remote processor found on A523, A527, and T527 SoCs. > A nit, subject: drop second/last, redundant "binding". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23 ... > + resets: > + minItems: 1 > + maxItems: 4 > + description: | > + CCU reset lines. Typical resets are "cfg" (configuration block), > + "core" (CPU core), "sram" (SRAM interconnect), and "msgbox" (mailbox interconnect). > + > + reset-names: > + minItems: 1 > + maxItems: 4 > + items: > + enum: [cfg, core, sram, msgbox] Nope, this cannot be flexible. Please open existing code to see how this is done. Same comments everywhere else. I don't get why your previous patch had it correct and here you decided to implement it completely different style which almost does not exist in the kernel. > + > + mboxes: > + minItems: 2 Drpo > + maxItems: 2 > + description: > + Exactly two mailbox channels from the Allwinner CPUX_MSGBOX controller — > + one receive channel (RISC-V-to-ARM) and one transmit channel > + (ARM-to-RISC-V) — used for VirtIO RPMsg kick notifications. > + > + mbox-names: > + items: > + - const: rx > + - const: tx > + > + firmware-name: > + $ref: /schemas/types.yaml#/definitions/string Drop. Instead maxItems. See existing code. > + description: > + Name of the ELF firmware image to load from /lib/firmware/. > + Defaults to "riscv-firmware.elf" if not specified. > + > + memory-region: > + description: > + Optional phandle list of reserved memory regions for VirtIO vring > + buffers or DDR carveouts. Region names "vram" and "dram" are > + recognized; "trace" selects the RemoteProc trace buffer carveout. List the items instead. > + > + memory-region-names: > + description: > + Names corresponding to the memory-region phandle list entries. > + Recognized values are "vram", "dram", and "trace". List the items instead. > + > + interrupts: > + maxItems: 1 > + description: > + Optional hardware crash-notification interrupt. When present the > + driver calls rproc_report_crash() on assertion. > + > + interrupt-names: > + items: > + - const: crash > + > + status: true > + Drop Best regards, Krzysztof