From: Andrew Lunn <andrew@lunn.ch>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Gregor Herburger <gregor.herburger@tq-group.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux@ew.tq-group.com
Subject: Re: [PATCH v2 2/2] arm64: dts: ls1028a: Add mbls1028a and mbls1028a-ind devicetrees
Date: Mon, 20 Oct 2025 20:34:16 +0200 [thread overview]
Message-ID: <14f52170-cc5b-4808-8fc1-28685ba349dd@lunn.ch> (raw)
In-Reply-To: <20251020133536.303471-2-alexander.stein@ew.tq-group.com>
> +&enetc_mdio_pf3 {
> + mdio0_rgmii_phy00: ethernet-phy@0 {
> + compatible = "ethernet-phy-ieee802.3-c22";
> + reg = <0x00>;
> + reset-gpios = <&gpio_exp_1v8 1 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <1>;
> + reset-deassert-us = <200>;
> + interrupt-parent = <&gpio_exp_1v8>;
> + interrupts = <0 IRQ_TYPE_EDGE_FALLING>;
PHY interrupts are generally level not edge. So this is probably
wrong.
> + ti,rx-internal-delay = <DP83867_RGMIIDCTL_2_50_NS>;
> + ti,tx-internal-delay = <DP83867_RGMIIDCTL_2_00_NS>;
> + ti,led-function = <0x05b0>;
> + ti,led-ctrl = <0x1001>;
I really would prefer /sys/class/leds was used. In fact, these are not
documented, and don't even seem to be implemented in mainline. So you
need to drop them.
Andrew
next prev parent reply other threads:[~2025-10-20 18:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 13:35 [PATCH v2 1/2] dt-bindings: arm: fsl: add TQ-Systems boards MBLS1028A and MBLS1028A-IND Alexander Stein
2025-10-20 13:35 ` [PATCH v2 2/2] arm64: dts: ls1028a: Add mbls1028a and mbls1028a-ind devicetrees Alexander Stein
2025-10-20 15:31 ` Frank Li
2025-10-20 18:34 ` Andrew Lunn [this message]
2025-10-21 11:24 ` Alexander Stein
2025-10-20 15:23 ` [PATCH v2 1/2] dt-bindings: arm: fsl: add TQ-Systems boards MBLS1028A and MBLS1028A-IND Frank Li
2025-10-20 17:15 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14f52170-cc5b-4808-8fc1-28685ba349dd@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregor.herburger@tq-group.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox