From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AAA0F33EAE2 for ; Mon, 18 Aug 2025 14:22:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755526951; cv=none; b=sCL99xLaspYlfVQVyeC5Fj8Dh4sytWHMUCwT0lBmy+YebiYeM+IPVraKKkcUH6R1x4Zv+Zbfd/dgVSoqg2+Fq65lAh90DxUFtZb6o5gIBwZH2k/jTnt24yoUd5TfgjYgZ6N3GtV206JQ2ODyUkf8E+/7cdcscM4PpIUcl0HFTRc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755526951; c=relaxed/simple; bh=Ld4BTbysJvvmlTmsob/shBMtAaRTdrmxmv8v8XzejBg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gDzCGZG6bkHRnK6Cx2UIB4o4a0P6dNjeLO0A5hHA7oiZEUlR8YWbv2RtlwraoDJTJBfGF3/HFltRdqLLqPvQec4+/KrMs+sGiPQhLc0n2ikAADCYaoZsO5AKgtml9xhYeGRJBBw/OZLt1jbeh3qq+0WcG7Z/4BaH9qwthnkgUxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UwX8zWfI; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UwX8zWfI" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3b9e414252dso1990958f8f.3 for ; Mon, 18 Aug 2025 07:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755526948; x=1756131748; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VFT7EYdl/U8S17HmCa7RikHeUwhOUF2kdHWiG5vKuDQ=; b=UwX8zWfI9Y9O0JWLzyJIfhLp4KSd5m0AY7K6K3LctpX/JPE0C6s7xd3Cwfv7cTYF7b y97C3ez/IjG1UIuMHk9urbb8Piojo3BxIBJ1HXzzrZdwHoWY8woeQVeOOSor2tnXtMr4 P0HJwk1hfqz7ZEE8zOa3Budbp94NwevxazEmQfpQTyeFS+5tQzsAKCi8jn1hJ5sACE5Q 3o3CrwC5IfnPSuoz1H2EzhELR+nLlBCVLnIRw2xJqRO+jmfIAzp3OgIzrwzpkL1L3AAx JZFlZnfR1Gc720z7Iyg+XnBevYFp/wSEZ2Zi9+uKeBW9r7qTnnAM2PD9FuakbW6U9q+I dR5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755526948; x=1756131748; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VFT7EYdl/U8S17HmCa7RikHeUwhOUF2kdHWiG5vKuDQ=; b=fEBWjQbofDK8tpFZvF5CBvMYGJNWTW2OkGlpkmDH4frwn35sGScfpYiWBM/Ud9Fmt0 YoK8WT/25svYdSrS//Z9xhanvXS/a58w4zZKnQogOaduJsVUgBMMVHhwVSmOc4nRaPgo F4ZFFc2dh9SHiJP0EJuVc8+qLQRl1qrA3mMw9QBsVnPXbahgY4kJDpjUcIvRlrLc1q0D JzGxXS85SD9NtOH7R+UmtlV5BIWXUW5j66HAT2UwIKX/8klk/ExURODOacutOa57YLLZ F+jz0+2FYY0JoUeIEs3B8ndLQ1ohX74aLkIPZNmkb7c6JBzgEhDVwr1MLnNq1EQNnNao i10A== X-Forwarded-Encrypted: i=1; AJvYcCX+foU1cBm1fwWl5w6JA+Hw3vwXXtltPd5hy7vf9s06i48C2/WNFQrHzqclXVuu2MGNOWTGdP63Dm+b@vger.kernel.org X-Gm-Message-State: AOJu0YwXStYcszo29wWbWWgDILxoVD/RhjWgTtlmtyZkZLEijtYV/5dM FZ2gfsYccM38MVgdXLyiwF6EbsWg4u4mhwmnfH0P3z+maj1S/s5lp1x8sxObfgohYwA= X-Gm-Gg: ASbGncvyctIVrqvlt6IshNz1LS/3xuEp8jM4vHbiJ4uy/xRr87YFQt/H22gT6ULK/tr Cbcn+4sH6Cnhc+9OqeCyRco0NUwns1aV8xbLrdb9yKN6MrMvh1uPYqFNHx33moe1nr52rxfba6G XRsw/0oydyFfYmIrhSQP85MsXtQ/IBxcjLmByON25XFYv9KMfeMJxS02/siFo2WzYkusugiuVAD rryhFOn/2DynbH1RgKAL3GqNHrjaJaiSUJrA+FaRJ7JnaL78H7ebXH82Ci4jaJXAbh9hSHr904j La9vlSJd6e8JO+l6oxrNxmHLG1dyTF++73bKBjCp2qjX8wokj0miJ440BkZxToeQKAvUpxW/tvL i+Ub8EEPz9BgHF87hVYa48nnkVQg= X-Google-Smtp-Source: AGHT+IHXXBqcG5WtLIRqk/YWgEdHVWCYOOUWvQEUiJZ9gf9C/DO/NkLfo+uNFk8MgEI2qKitz8FZdg== X-Received: by 2002:a05:6000:2c09:b0:3b7:882c:790 with SMTP id ffacd0b85a97d-3bb68a1644bmr9651163f8f.37.1755526947830; Mon, 18 Aug 2025 07:22:27 -0700 (PDT) Received: from [192.168.1.3] ([185.48.76.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45a1b226eecsm106540185e9.1.2025.08.18.07.22.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Aug 2025 07:22:27 -0700 (PDT) Message-ID: <14fd2e7a-0fe6-4f00-b826-7f3971dd09ae@linaro.org> Date: Mon, 18 Aug 2025 15:22:25 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/13] spi: spi-fsl-lpspi: Parameterize reading num-cs from hardware To: Frank Li Cc: Mark Brown , Clark Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Fabio Estevam , Larisa Grigore , Larisa Grigore , Ghennadi Procopciuc , Ciprianmarian Costea , s32@nxp.com, linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20250814-james-nxp-lpspi-v1-0-9586d7815d14@linaro.org> <20250814-james-nxp-lpspi-v1-9-9586d7815d14@linaro.org> Content-Language: en-US From: James Clark In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14/08/2025 7:31 pm, Frank Li wrote: > On Thu, Aug 14, 2025 at 05:06:49PM +0100, James Clark wrote: >> To avoid adding more string matching here for every new device, move >> this property into devtype data. > > Add query_hw_for_num_cs in devtype to avoid directly check compatible > "fsl,imx93-spi". > > No functionaltiy change. > > Frank Ack >> >> Signed-off-by: James Clark >> --- >> drivers/spi/spi-fsl-lpspi.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c >> index 1013d5c994e9..6d0138b27785 100644 >> --- a/drivers/spi/spi-fsl-lpspi.c >> +++ b/drivers/spi/spi-fsl-lpspi.c >> @@ -97,6 +97,7 @@ static const char * const pincfgs[] = { >> >> struct fsl_lpspi_devtype_data { >> bool prescale_err : 1; >> + bool query_hw_for_num_cs : 1; >> }; >> >> struct lpspi_config { >> @@ -150,10 +151,12 @@ struct fsl_lpspi_data { >> */ >> static const struct fsl_lpspi_devtype_data imx93_lpspi_devtype_data = { >> .prescale_err = true, >> + .query_hw_for_num_cs = true, >> }; >> >> static const struct fsl_lpspi_devtype_data imx7ulp_lpspi_devtype_data = { >> .prescale_err = false, >> + .query_hw_for_num_cs = false, >> }; >> >> static const struct of_device_id fsl_lpspi_dt_ids[] = { >> @@ -960,7 +963,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev) >> fsl_lpspi->rxfifosize = 1 << ((temp >> 8) & 0x0f); >> if (of_property_read_u32((&pdev->dev)->of_node, "num-cs", >> &num_cs)) { >> - if (of_device_is_compatible(pdev->dev.of_node, "fsl,imx93-spi")) >> + if (devtype_data->query_hw_for_num_cs) >> num_cs = ((temp >> 16) & 0xf); >> else >> num_cs = 1; >> >> -- >> 2.34.1 >>