From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1500394987.17774.4.camel@mtksdaap41> Subject: Re: [PATCH v2 9/9] soc: mediatek: pwrap: fixup warnings from coding style From: Yingjoe Chen Date: Wed, 19 Jul 2017 00:23:07 +0800 In-Reply-To: <568c3b518b70a0af17cbef1223721b68448a8ac6.1500368529.git.sean.wang@mediatek.com> References: <568c3b518b70a0af17cbef1223721b68448a8ac6.1500368529.git.sean.wang@mediatek.com> Content-Type: multipart/alternative; boundary="=-qiktSKUVunyeizBDzIab" MIME-Version: 1.0 To: sean.wang@mediatek.com, Matthias Brugger Cc: robh+dt@kernel.org, mark.rutland@arm.com, lgirdwood@gmail.com, broonie@kernel.org, jamesjj.liao@mediatek.com, henryc.chen@mediatek.com, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, chenglin.xu@mediatek.com, chen.zhong@mediatek.com, linux-kernel@vger.kernel.org List-ID: --=-qiktSKUVunyeizBDzIab Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2017-07-18 at 17:49 +0800, sean.wang@mediatek.com wrote: > From: Sean Wang > > fixup those warnings such as lines over 80 words and parenthesis > alignment which would be complained by checkpatch.pl. > > Signed-off-by: Sean Wang > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index 142f40a..5f1036f 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1057,7 +1057,8 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp) > /* wait for cipher data ready@PMIC */ > ret = pwrap_wait_for_state(wrp, pwrap_is_pmic_cipher_ready); > if (ret) { > - dev_err(wrp->dev, "timeout waiting for cipher data ready@PMIC\n"); > + dev_err(wrp->dev, > + "timeout waiting for cipher data ready@PMIC\n"); Sean, I think the old code is easier to read. When the line is only slightly over the 80 chars limit, some maintainers will even ask to keep it in one line to make it easier to read. So if it is OK with Matthias, I think we should just keep it as is. Joe.C --=-qiktSKUVunyeizBDzIab Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

On Tue, 2017-07-18 at 17:49 +0800, sean.wang@mediatek.com wrote:
> From: Sean Wang <sean.wang@mediatek.com>
> 
> fixup those warnings such as lines over 80 words and parenthesis
> alignment which would be complained by checkpatch.pl.
> 
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
> ---
>  drivers/soc/mediatek/mtk-pmic-wrap.c | 20 +++++++++++++-------
>  1 file changed, 13 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> index 142f40a..5f1036f 100644
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> @@ -1057,7 +1057,8 @@ static int pwrap_init_cipher(struct pmic_wrapper *wrp)
>  	/* wait for cipher data ready@PMIC */
>  	ret = pwrap_wait_for_state(wrp, pwrap_is_pmic_cipher_ready);
>  	if (ret) {
> -		dev_err(wrp->dev, "timeout waiting for cipher data ready@PMIC\n");
> +		dev_err(wrp->dev,
> +			"timeout waiting for cipher data ready@PMIC\n");

Sean,

I think the old code is easier to read. When the line is only slightly
over the 80 chars limit, some maintainers will even ask to keep it in
one line to make it easier to read.

So if it is OK with Matthias, I think we should just keep it as is.

Joe.C

--=-qiktSKUVunyeizBDzIab--