devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Varadarajan Narayanan <varada@codeaurora.org>
To: broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
	andy.gross@linaro.org, david.brown@linaro.org,
	linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org
Cc: Varadarajan Narayanan <varada@codeaurora.org>
Subject: [PATCH v5 04/14] spi: qup: Place the QUP in run mode before DMA
Date: Mon, 24 Jul 2017 13:17:15 +0530	[thread overview]
Message-ID: <1500882445-29008-5-git-send-email-varada@codeaurora.org> (raw)
In-Reply-To: <1500882445-29008-1-git-send-email-varada@codeaurora.org>

Signed-off-by: Andy Gross <andy.gross@linaro.org>
Signed-off-by: Varadarajan Narayanan <varada@codeaurora.org>
---
 drivers/spi/spi-qup.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index 92922b6..e6294f8 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -342,6 +342,14 @@ static int spi_qup_do_dma(struct spi_master *master, struct spi_transfer *xfer,
 	else if (xfer->tx_buf)
 		tx_done = spi_qup_dma_done;
 
+	/* before issuing the descriptors, set the QUP to run */
+	ret = spi_qup_set_state(qup, QUP_STATE_RUN);
+	if (ret) {
+		dev_warn(qup->dev, "%s(%d): cannot set RUN state\n",
+				__func__, __LINE__);
+		return ret;
+	}
+
 	if (xfer->rx_buf) {
 		ret = spi_qup_prep_sg(master, xfer, DMA_DEV_TO_MEM, rx_done);
 		if (ret)
@@ -387,6 +395,13 @@ static int spi_qup_do_pio(struct spi_master *master, struct spi_transfer *xfer,
 
 	spi_qup_fifo_write(qup, xfer);
 
+	ret = spi_qup_set_state(qup, QUP_STATE_RUN);
+	if (ret) {
+		dev_warn(qup->dev, "%s(%d): cannot set RUN state\n",
+				__func__, __LINE__);
+		return ret;
+	}
+
 	if (!wait_for_completion_timeout(&qup->done, timeout))
 		return -ETIMEDOUT;
 
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

  parent reply	other threads:[~2017-07-24  7:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24  7:47 [PATCH v5 00/14] spi: qup: Fixes and add support for >64k transfers Varadarajan Narayanan
2017-07-24  7:47 ` [PATCH v5 01/14] spi: qup: Enable chip select support Varadarajan Narayanan
2017-07-24  7:47 ` Varadarajan Narayanan [this message]
2017-08-08 11:18   ` Applied "spi: qup: Place the QUP in run mode before DMA" to the spi tree Mark Brown
     [not found] ` <1500882445-29008-1-git-send-email-varada-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-07-24  7:47   ` [PATCH v5 02/14] spi: qup: Setup DMA mode correctly Varadarajan Narayanan
2017-07-24  7:47   ` [PATCH v5 03/14] spi: qup: Add completion timeout Varadarajan Narayanan
2017-07-27  8:30     ` kbuild test robot
2017-07-24  7:47   ` [PATCH v5 05/14] spi: qup: Fix error handling in spi_qup_prep_sg Varadarajan Narayanan
2017-08-08 11:18     ` Applied "spi: qup: Fix error handling in spi_qup_prep_sg" to the spi tree Mark Brown
2017-07-24  7:47   ` [PATCH v5 07/14] spi: qup: Do block sized read/write in block mode Varadarajan Narayanan
2017-08-08 11:18     ` Applied "spi: qup: Do block sized read/write in block mode" to the spi tree Mark Brown
2017-07-24  7:47   ` [PATCH v5 09/14] spi: qup: call io_config in mode specific function Varadarajan Narayanan
2017-07-24  7:47   ` [PATCH v5 10/14] spi: qup: allow block mode to generate multiple transactions Varadarajan Narayanan
2017-08-08 11:18     ` Applied "spi: qup: allow block mode to generate multiple transactions" to the spi tree Mark Brown
2017-07-24  7:47   ` [PATCH v5 11/14] spi: qup: refactor spi_qup_prep_sg Varadarajan Narayanan
2017-08-08 11:18     ` Applied "spi: qup: refactor spi_qup_prep_sg" to the spi tree Mark Brown
2017-07-24  7:47   ` [PATCH v5 12/14] spi: qup: allow multiple DMA transactions per spi xfer Varadarajan Narayanan
2017-07-24  7:47 ` [PATCH v5 06/14] spi: qup: Fix transaction done signaling Varadarajan Narayanan
2017-07-24  7:47 ` [PATCH v5 08/14] spi: qup: refactor spi_qup_io_config into two functions Varadarajan Narayanan
2017-08-08 11:18   ` Applied "spi: qup: refactor spi_qup_io_config into two functions" to the spi tree Mark Brown
2017-07-24  7:47 ` [PATCH v5 13/14] spi: qup: Ensure done detection Varadarajan Narayanan
2017-07-24  7:47 ` [PATCH v5 14/14] spi: qup: Fix QUP version identify method Varadarajan Narayanan
     [not found]   ` <1500882445-29008-15-git-send-email-varada-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-07-25  2:52     ` kbuild test robot
2017-08-08 11:17     ` Applied "spi: qup: Fix QUP version identify method" to the spi tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500882445-29008-5-git-send-email-varada@codeaurora.org \
    --to=varada@codeaurora.org \
    --cc=andy.gross@linaro.org \
    --cc=broonie@kernel.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).