From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 1/3] serial: mctrl_gpio: restrict MCTRL initialization Date: Thu, 27 Jul 2017 17:01:32 +0300 Message-ID: <1501164092.29303.270.camel@linux.intel.com> References: <1501161456-13367-1-git-send-email-yegorslists@googlemail.com> <1501161456-13367-2-git-send-email-yegorslists@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1501161456-13367-2-git-send-email-yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, jslaby-IBi9RG/b67k@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, uwe-rXY34ruvC2xidJT2blvkqNi2O/JbrIOy@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, 2017-07-27 at 15:17 +0200, yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org wrote: > From: Yegor Yefremov > > GPIOs specified for serial port can be used either as GPIO driven > MCTRL > or as a wakeup-source. Use the latter property to abort the MCTRL > initialization. Please, elaborate on a choice of error code for this (-ENOSYS). > > Cc: Andy Shevchenko Suggested-by: I suppose. I dunno about documentation part for this property, I leave it for DT people to decide. Below part looks good to me. > Signed-off-by: Yegor Yefremov > --- >  drivers/tty/serial/serial_mctrl_gpio.c | 4 ++++ >  1 file changed, 4 insertions(+) > > diff --git a/drivers/tty/serial/serial_mctrl_gpio.c > b/drivers/tty/serial/serial_mctrl_gpio.c > index d2da6aa..dce661c 100644 > --- a/drivers/tty/serial/serial_mctrl_gpio.c > +++ b/drivers/tty/serial/serial_mctrl_gpio.c > @@ -19,6 +19,7 @@ >  #include >  #include >  #include > +#include >  #include >  #include >   > @@ -118,6 +119,9 @@ struct mctrl_gpios *mctrl_gpio_init_noauto(struct > device *dev, unsigned int idx) >   struct mctrl_gpios *gpios; >   enum mctrl_gpio_idx i; >   > + if (device_property_present(dev, "wakeup-source")) > + return ERR_PTR(-ENOSYS); > + >   gpios = devm_kzalloc(dev, sizeof(*gpios), GFP_KERNEL); >   if (!gpios) >   return ERR_PTR(-ENOMEM); -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html