From: Varadarajan Narayanan <varada@codeaurora.org>
To: broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
andy.gross@linaro.org, david.brown@linaro.org,
linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org
Cc: Varadarajan Narayanan <varada@codeaurora.org>
Subject: [PATCH v6 03/14] spi: qup: Add completion timeout
Date: Fri, 28 Jul 2017 12:22:50 +0530 [thread overview]
Message-ID: <1501224781-19519-4-git-send-email-varada@codeaurora.org> (raw)
In-Reply-To: <1501224781-19519-1-git-send-email-varada@codeaurora.org>
Add i/o completion timeout for DMA and PIO modes.
Signed-off-by: Andy Gross <andy.gross@linaro.org>
Signed-off-by: Varadarajan Narayanan <varada@codeaurora.org>
---
drivers/spi/spi-qup.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-qup.c b/drivers/spi/spi-qup.c
index abe799b..fdd34c3 100644
--- a/drivers/spi/spi-qup.c
+++ b/drivers/spi/spi-qup.c
@@ -331,8 +331,10 @@ static void spi_qup_dma_terminate(struct spi_master *master,
dmaengine_terminate_all(master->dma_rx);
}
-static int spi_qup_do_dma(struct spi_master *master, struct spi_transfer *xfer)
+static int spi_qup_do_dma(struct spi_master *master, struct spi_transfer *xfer,
+ unsigned long timeout)
{
+ struct spi_qup *qup = spi_master_get_devdata(master);
dma_async_tx_callback rx_done = NULL, tx_done = NULL;
int ret;
@@ -357,10 +359,14 @@ static int spi_qup_do_dma(struct spi_master *master, struct spi_transfer *xfer)
dma_async_issue_pending(master->dma_tx);
}
+ if (!wait_for_completion_timeout(&qup->done, timeout))
+ return -ETIMEDOUT;
+
return 0;
}
-static int spi_qup_do_pio(struct spi_master *master, struct spi_transfer *xfer)
+static int spi_qup_do_pio(struct spi_master *master, struct spi_transfer *xfer,
+ unsigned long timeout)
{
struct spi_qup *qup = spi_master_get_devdata(master);
int ret;
@@ -379,6 +385,9 @@ static int spi_qup_do_pio(struct spi_master *master, struct spi_transfer *xfer)
spi_qup_fifo_write(qup, xfer);
+ if (!wait_for_completion_timeout(&qup->done, timeout))
+ return -ETIMEDOUT;
+
return 0;
}
@@ -632,9 +641,9 @@ static int spi_qup_transfer_one(struct spi_master *master,
spin_unlock_irqrestore(&controller->lock, flags);
if (spi_qup_is_dma_xfer(controller->mode))
- ret = spi_qup_do_dma(master, xfer);
+ ret = spi_qup_do_dma(master, xfer, timeout);
else
- ret = spi_qup_do_pio(master, xfer);
+ ret = spi_qup_do_pio(master, xfer, timeout);
if (ret)
goto exit;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2017-07-28 6:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 6:52 [PATCH v6 00/14] spi: qup: Fixes and add support for >64k transfers Varadarajan Narayanan
2017-07-28 6:52 ` [PATCH v6 01/14] spi: qup: Enable chip select support Varadarajan Narayanan
2017-07-28 6:52 ` [PATCH v6 02/14] spi: qup: Setup DMA mode correctly Varadarajan Narayanan
2017-07-28 6:52 ` Varadarajan Narayanan [this message]
2017-08-08 11:18 ` Applied "spi: qup: Add completion timeout" to the spi tree Mark Brown
2017-07-28 6:52 ` [PATCH v6 04/14] spi: qup: Place the QUP in run mode before DMA Varadarajan Narayanan
2017-07-28 6:52 ` [PATCH v6 05/14] spi: qup: Fix error handling in spi_qup_prep_sg Varadarajan Narayanan
2017-07-28 6:52 ` [PATCH v6 06/14] spi: qup: Fix transaction done signaling Varadarajan Narayanan
2017-07-28 6:52 ` [PATCH v6 07/14] spi: qup: Do block sized read/write in block mode Varadarajan Narayanan
2017-07-28 6:52 ` [PATCH v6 08/14] spi: qup: refactor spi_qup_io_config into two functions Varadarajan Narayanan
2017-07-28 6:52 ` [PATCH v6 09/14] spi: qup: call io_config in mode specific function Varadarajan Narayanan
2017-08-08 11:18 ` Applied "spi: qup: call io_config in mode specific function" to the spi tree Mark Brown
2017-07-28 6:52 ` [PATCH v6 10/14] spi: qup: allow block mode to generate multiple transactions Varadarajan Narayanan
2017-07-28 6:52 ` [PATCH v6 11/14] spi: qup: refactor spi_qup_prep_sg Varadarajan Narayanan
2017-07-28 6:52 ` [PATCH v6 12/14] spi: qup: allow multiple DMA transactions per spi xfer Varadarajan Narayanan
[not found] ` <1501224781-19519-13-git-send-email-varada-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-08-08 11:18 ` Applied "spi: qup: allow multiple DMA transactions per spi xfer" to the spi tree Mark Brown
2017-07-28 6:53 ` [PATCH v6 13/14] spi: qup: Ensure done detection Varadarajan Narayanan
2017-07-28 6:53 ` [PATCH v6 14/14] spi: qup: Fix QUP version identify method Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501224781-19519-4-git-send-email-varada@codeaurora.org \
--to=varada@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=broonie@kernel.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).