From: Andy Yan <andy.yan@rock-chips.com>
To: heiko@sntech.de, linus.walleij@linaro.org
Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-gpio@vger.kernel.org, Andy Yan <andy.yan@rock-chips.com>
Subject: [PATCH 03/14] pinctrl: rockchip: add input schmitt support for rv1108
Date: Mon, 31 Jul 2017 18:10:22 +0800 [thread overview]
Message-ID: <1501495822-21503-1-git-send-email-andy.yan@rock-chips.com> (raw)
In-Reply-To: <1501495449-21290-1-git-send-email-andy.yan@rock-chips.com>
Some pins like i2c SCL/SDA need the schmitt input function
to avoid crosstalk problems.
Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---
drivers/pinctrl/pinctrl-rockchip.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index e831647..868cb9c 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -1084,6 +1084,36 @@ static void rv1108_calc_drv_reg_and_bit(struct rockchip_pin_bank *bank,
*bit *= RV1108_DRV_BITS_PER_PIN;
}
+#define RV1108_SCHMITT_PMU_OFFSET 0x30
+#define RV1108_SCHMITT_GRF_OFFSET 0x388
+#define RV1108_SCHMITT_BANK_STRIDE 8
+#define RV1108_SCHMITT_PINS_PER_GRF_REG 16
+#define RV1108_SCHMITT_PINS_PER_PMU_REG 8
+
+static int rv1108_calc_schmitt_reg_and_bit(struct rockchip_pin_bank *bank,
+ int pin_num,
+ struct regmap **regmap,
+ int *reg, u8 *bit)
+{
+ struct rockchip_pinctrl *info = bank->drvdata;
+ int pins_per_reg;
+
+ if (bank->bank_num == 0) {
+ *regmap = info->regmap_pmu;
+ *reg = RV1108_SCHMITT_PMU_OFFSET;
+ pins_per_reg = RV1108_SCHMITT_PINS_PER_PMU_REG;
+ } else {
+ *regmap = info->regmap_base;
+ *reg = RV1108_SCHMITT_GRF_OFFSET;
+ pins_per_reg = RV1108_SCHMITT_PINS_PER_GRF_REG;
+ *reg += (bank->bank_num - 1) * RV1108_SCHMITT_BANK_STRIDE;
+ }
+ *reg += ((pin_num / pins_per_reg) * 4);
+ *bit = pin_num % pins_per_reg;
+
+ return 0;
+}
+
#define RK2928_PULL_OFFSET 0x118
#define RK2928_PULL_PINS_PER_REG 16
#define RK2928_PULL_BANK_STRIDE 8
@@ -3017,6 +3047,7 @@ static struct rockchip_pin_ctrl rv1108_pin_ctrl = {
.pmu_mux_offset = 0x0,
.pull_calc_reg = rv1108_calc_pull_reg_and_bit,
.drv_calc_reg = rv1108_calc_drv_reg_and_bit,
+ .schmitt_calc_reg = rv1108_calc_schmitt_reg_and_bit,
};
static struct rockchip_pin_bank rk2928_pin_banks[] = {
--
2.7.4
next prev parent reply other threads:[~2017-07-31 10:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 10:04 [PATCH 00/14] Support more devices on rockchip rv1108 Andy Yan
2017-07-31 10:08 ` [PATCH 02/14] clk: rockchip: support more clks for rv1108 Andy Yan
2017-07-31 23:31 ` Heiko Stuebner
2017-07-31 10:10 ` Andy Yan [this message]
2017-07-31 11:26 ` [PATCH 03/14] pinctrl: rockchip: add input schmitt support " Heiko Stübner
[not found] ` <1501495822-21503-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-08-07 8:49 ` Linus Walleij
2017-07-31 10:11 ` [PATCH 04/14] dt-bindings: i2c: rk3x: add " Andy Yan
[not found] ` <1501495449-21290-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-07-31 10:06 ` [PATCH 01/14] clk: rockchip: add more clk ids " Andy Yan
2017-07-31 23:27 ` Heiko Stuebner
2017-07-31 10:12 ` [PATCH 05/14] i2c: rk3x: add support " Andy Yan
[not found] ` <1501495963-21608-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-07-31 11:26 ` Heiko Stübner
2017-07-31 10:13 ` [PATCH 06/14] ARM: dts: rockchip: add i2c dt node " Andy Yan
2017-07-31 10:15 ` [PATCH 07/14] spi: rockchip: add compatible string for rv1108 spi Andy Yan
[not found] ` <1501496103-21713-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-07-31 13:16 ` kbuild test robot
2017-07-31 10:16 ` [PATCH 08/14] ARM: dts: rockchip: add spi dt node for rv1108 Andy Yan
2017-07-31 10:17 ` [PATCH 09/14] ARM: dts: rockchip: add pwm " Andy Yan
[not found] ` <1501496265-21910-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-07-31 11:28 ` Heiko Stübner
2017-07-31 10:18 ` [PATCH 10/14] ARM: dts: rockchip: add watchdog " Andy Yan
2017-08-01 15:16 ` Heiko Stuebner
2017-08-01 18:55 ` Heiko Stuebner
2017-08-02 0:34 ` Andy Yan
2017-07-31 10:19 ` [PATCH 12/14] ARM: dts: rockchip: add pwm backlight for rv1108 evb Andy Yan
2017-07-31 10:20 ` [PATCH 13/14] ARM: dts: rockchip: add pmic rk805 dt node " Andy Yan
2017-07-31 10:21 ` [PATCH 14/14] ARM: dts: rockchip: add accelerometer bma250e " Andy Yan
2017-07-31 10:19 ` [PATCH 11/14] ARM: dts: rockchip: add saradc support for rv1108 Andy Yan
2017-07-31 23:11 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501495822-21503-1-git-send-email-andy.yan@rock-chips.com \
--to=andy.yan@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).