From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yingjoe Chen Subject: Re: [PATCH v5 2/2] arm64: dts: Add Mediatek SoC MT2712 and evaluation board dts and Makefile Date: Tue, 1 Aug 2017 16:51:21 +0800 Message-ID: <1501577481.32089.3.camel@mtksdaap41> References: <1501241835-47849-1-git-send-email-yt.shen@mediatek.com> <1501241835-47849-3-git-send-email-yt.shen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1501241835-47849-3-git-send-email-yt.shen@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: YT Shen , Matthias Brugger Cc: Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Jason Cooper , srv_heupstream@mediatek.com, Marc Zyngier , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, Mars Cheng , linux-serial@vger.kernel.org, Greg Kroah-Hartman , linux-mediatek@lists.infradead.org, Thomas Gleixner , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Fri, 2017-07-28 at 19:37 +0800, YT Shen wrote: > diff --git a/arch/arm64/boot/dts/mediatek/mt2712e.dtsi b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi > new file mode 100644 > index 0000000..1e135af > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt2712e.dtsi <...> > + timer { > + compatible = "arm,armv8-timer"; > + interrupt-parent = <&gic>; > + interrupts = + (GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_RAW(0x13) | IRQ_TYPE_LEVEL_LOW)>; > + }; > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + compatible = "simple-bus"; > + ranges; Matthias, I notice this have soc node. Do we need to get rid of it? Joe.C