From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH 0/2] serial: 8250: add support for MediaTek BTIF controller Date: Wed, 02 Aug 2017 21:02:15 +0300 Message-ID: <1501696935.29303.367.camel@linux.intel.com> References: <1501694063.29303.361.camel@linux.intel.com> <1501695470.25246.7.camel@mtkswgap22> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1501695470.25246.7.camel@mtkswgap22> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sean Wang , "arnd.bergmann" Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, jslaby-IBi9RG/b67k@public.gmane.org, jan.kiszka-kv7WeFo6aLtBDgjK7y7TUQ@public.gmane.org, heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, hpeter-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, vigneshr-l0cyMroinI0@public.gmane.org, matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, 2017-08-03 at 01:37 +0800, Sean Wang wrote: > On Wed, 2017-08-02 at 20:14 +0300, Andy Shevchenko wrote: > > On Thu, 2017-08-03 at 01:05 +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote: > > > From: Sean Wang > > > > > > This patchset introduces the support for MediaTek BTIF controller. > > > > > > MediaTek BTIF controller is the serial interface similar to UART > > > but > > > it > > > works only as the digital device which is mainly used to > > > communicate > > > with > > > the connectivity module also called CONNSYS inside the SoC which > > > could > > > be > > > mostly found on those MediaTek SoCs with Bluetooth feature. > > > > > > And the controller is made as being compatible with the 8250 > > > register > > > layout so it tends to be integrated with existing 8250 core driver > > > and > > > have no requirement for the modem configuration additionally such > > > as > > > the > > > baud rate calculation and assignment. +Cc: Arnd. > > Why it requires a separate driver? > > > > 8250_of is for DT enabled drivers. > > > > Hi, Andy > > thanks for your information > > the hardware is not completely identical to 8250 device,  > it has extra registers belonged to platform control such as internal > loopback, dma disable/enable, sleep/wakeup setup and so on, so I > create > it as a separate driver. Over all 200+ LOCs I didn't see any of the above except loopback, which is one property that can be easily added to 8250_of.c. Moreover, if you have more code coming I would suggest you to split 8250_of to library and driver parts and re-use stuff from there. Arnd, what is your opinion about new 8250 OF based drivers? -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html