From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suzuki K Poulose Subject: [PATCH v5 3/6] coresight: of: Use of_cpu_node_to_id helper Date: Tue, 8 Aug 2017 12:37:23 +0100 Message-ID: <1502192246-5623-4-git-send-email-suzuki.poulose@arm.com> References: <1502192246-5623-1-git-send-email-suzuki.poulose@arm.com> Return-path: In-Reply-To: <1502192246-5623-1-git-send-email-suzuki.poulose@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: will.deacon@arm.com, marc.zyngier@arm.com, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robh@kernel.org, frowand.list@gmail.com, mathieu.poirier@linaro.org, peterz@infradead.org, Suzuki K Poulose , Leo Yan List-Id: devicetree@vger.kernel.org Reuse the new generic helper, of_cpu_node_to_id() to map a given CPU phandle to a logical CPU number. Cc: Leo Yan Acked-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- Changes since V4: - Fix a regression introduced in v4, reported by bugrobot Changes since V3: - Reflect the renaming of the helper and return value changes --- drivers/hwtracing/coresight/of_coresight.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c index a187941..7c37544 100644 --- a/drivers/hwtracing/coresight/of_coresight.c +++ b/drivers/hwtracing/coresight/of_coresight.c @@ -104,26 +104,17 @@ static int of_coresight_alloc_memory(struct device *dev, int of_coresight_get_cpu(const struct device_node *node) { int cpu; - bool found; - struct device_node *dn, *np; + struct device_node *dn; dn = of_parse_phandle(node, "cpu", 0); - /* Affinity defaults to CPU0 */ if (!dn) return 0; - - for_each_possible_cpu(cpu) { - np = of_cpu_device_node_get(cpu); - found = (dn == np); - of_node_put(np); - if (found) - break; - } + cpu = of_cpu_node_to_id(dn); of_node_put(dn); /* Affinity to CPU0 if no cpu nodes are found */ - return found ? cpu : 0; + return (cpu < 0) ? 0 : cpu; } EXPORT_SYMBOL_GPL(of_coresight_get_cpu); -- 2.7.5