Re: [PATCH 2/3] regulator: mt6351: Add support for MT6351 regulator

[Mars Cheng <mars.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>]

Hi

On Wed, 2017-08-09 at 17:03 +0800, Yingjoe Chen wrote:
> On Wed, 2017-08-09 at 16:46 +0800, Yingjoe Chen wrote:
...
> > > +static struct regulator_ops mt6351_volt_table_ops = {
> > > +	.list_voltage = regulator_list_voltage_table,
> > > +	.map_voltage = regulator_map_voltage_iterate,
> > > +	.set_voltage_sel = regulator_set_voltage_sel_regmap,
> > > +	.get_voltage_sel = regulator_get_voltage_sel_regmap,
> > > +	.set_voltage_time_sel = regulator_set_voltage_time_sel,
> > > +	.enable = regulator_enable_regmap,
> > > +	.disable = regulator_disable_regmap,
> > > +	.is_enabled = regulator_is_enabled_regmap,
> > > +	.get_status = mt6351_get_status,
> > > +};
> > > +
> > > +static struct regulator_ops mt6351_volt_fixed_ops = {
> > > +	.list_voltage = regulator_list_voltage_linear,
> > > +	.enable = regulator_enable_regmap,
> > > +	.disable = regulator_disable_regmap,
> > > +	.is_enabled = regulator_is_enabled_regmap,
> > > +	.get_status = mt6351_get_status,
> > > +};
> > > +
> > > +/* The array is indexed by id(MT6351_ID_XXX) */
> > > +static struct mt6351_regulator_info mt6351_regulators[] = {
> > 
> > 
> > const
> > 
> > All struct regulator_ops and mt6351_regulators should be const.
> 
> 
> Hi,
> 
> It seems mt6351_regulators will be modified so can't be const.
> But regulator_ops should be.
> 

got it, will fix this along with other coding style and sent v2 later.

Thanks for your review.

> Joe.C
> 
>