devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jun Gao <jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
	Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
Date: Wed, 9 Aug 2017 20:58:39 +0800	[thread overview]
Message-ID: <1502283519.930.62.camel@mhfsdcap03> (raw)
In-Reply-To: <1502271638.31781.3.camel@mtksdaap41>

On Wed, 2017-08-09 at 17:40 +0800, Yingjoe Chen wrote:
> On Wed, 2017-08-09 at 15:43 +0800, Jun Gao wrote:
> > From: Jun Gao <jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > 
> > Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
> > MT7622 limit message size to 255, and not support 4GB DMA mode.
> 
> 
> Jun,
> 
> Do you mean message numbers?
> 
> 
> Joe.C
> 

Yes, bit7~bit0 of i2c register TRANSAC_LEN will be used as message
numbers.

Jun
> > 
> > Signed-off-by: Jun Gao <jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> >  drivers/i2c/busses/i2c-mt65xx.c | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> > 
> > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> > index 9bedf0b..2c7f847 100644
> > --- a/drivers/i2c/busses/i2c-mt65xx.c
> > +++ b/drivers/i2c/busses/i2c-mt65xx.c
> > @@ -172,6 +172,14 @@ struct mtk_i2c {
> >  	.max_comb_2nd_msg_len = 31,
> >  };
> >  
> > +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> > +	.max_num_msgs = 255,
> > +	.max_write_len = 65535,
> > +	.max_read_len = 65535,
> > +	.max_comb_1st_msg_len = 65535,
> > +	.max_comb_2nd_msg_len = 65535,
> > +};
> > +
> >  static const struct mtk_i2c_compatible mt6577_compat = {
> >  	.quirks = &mt6577_i2c_quirks,
> >  	.pmic_i2c = 0,
> > @@ -190,6 +198,15 @@ struct mtk_i2c {
> >  	.support_33bits = 0,
> >  };
> >  
> > +static const struct mtk_i2c_compatible mt7622_compat = {
> > +	.quirks = &mt7622_i2c_quirks,
> > +	.pmic_i2c = 0,
> > +	.dcm = 1,
> > +	.auto_restart = 1,
> > +	.aux_len_reg = 1,
> > +	.support_33bits = 0,
> > +};
> > +
> >  static const struct mtk_i2c_compatible mt8173_compat = {
> >  	.pmic_i2c = 0,
> >  	.dcm = 1,
> > @@ -201,6 +218,7 @@ struct mtk_i2c {
> >  static const struct of_device_id mtk_i2c_of_match[] = {
> >  	{ .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
> >  	{ .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
> > +	{ .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
> >  	{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
> >  	{}
> >  };
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2017-08-09 12:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-09  7:43 [PATCH 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC Jun Gao
2017-08-09  7:43 ` [PATCH 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Jun Gao
2017-08-14  9:36   ` Matthias Brugger
2017-08-14 10:05     ` Jun Gao
2017-08-09  7:43 ` [PATCH 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao
     [not found]   ` <1502264631-12572-3-git-send-email-jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-09  9:40     ` Yingjoe Chen
2017-08-09 12:58       ` Jun Gao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502283519.930.62.camel@mhfsdcap03 \
    --to=jun.gao-nus5lvnupcjwk0htik3j/w@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    --cc=yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).