From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Jun Gao <jun.gao@mediatek.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-i2c@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622
Date: Thu, 10 Aug 2017 16:03:46 +0800 [thread overview]
Message-ID: <1502352226.12382.1.camel@mtksdaap41> (raw)
In-Reply-To: <1502349760.930.66.camel@mhfsdcap03>
On Thu, 2017-08-10 at 15:22 +0800, Jun Gao wrote:
> On Thu, 2017-08-10 at 10:27 +0800, Jun Gao wrote:
> > From: Jun Gao <jun.gao@mediatek.com>
> >
> > Add i2c compatible for MT7622. Compare to MT8173 i2c controller,
> > MT7622 limits message numbers to 255, and does not support 4GB
> > DMA mode.
> >
>
> These two resend patches only modify commit message.
> Thanks!
>
> Jun
Looks good to me, so for new version:
Reviewed-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
Joe.C
>
> > Signed-off-by: Jun Gao <jun.gao@mediatek.com>
> > ---
> > drivers/i2c/busses/i2c-mt65xx.c | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> > index 9bedf0b..2c7f847 100644
> > --- a/drivers/i2c/busses/i2c-mt65xx.c
> > +++ b/drivers/i2c/busses/i2c-mt65xx.c
> > @@ -172,6 +172,14 @@ struct mtk_i2c {
> > .max_comb_2nd_msg_len = 31,
> > };
> >
> > +static const struct i2c_adapter_quirks mt7622_i2c_quirks = {
> > + .max_num_msgs = 255,
> > + .max_write_len = 65535,
> > + .max_read_len = 65535,
> > + .max_comb_1st_msg_len = 65535,
> > + .max_comb_2nd_msg_len = 65535,
> > +};
> > +
> > static const struct mtk_i2c_compatible mt6577_compat = {
> > .quirks = &mt6577_i2c_quirks,
> > .pmic_i2c = 0,
> > @@ -190,6 +198,15 @@ struct mtk_i2c {
> > .support_33bits = 0,
> > };
> >
> > +static const struct mtk_i2c_compatible mt7622_compat = {
> > + .quirks = &mt7622_i2c_quirks,
> > + .pmic_i2c = 0,
> > + .dcm = 1,
> > + .auto_restart = 1,
> > + .aux_len_reg = 1,
> > + .support_33bits = 0,
> > +};
> > +
> > static const struct mtk_i2c_compatible mt8173_compat = {
> > .pmic_i2c = 0,
> > .dcm = 1,
> > @@ -201,6 +218,7 @@ struct mtk_i2c {
> > static const struct of_device_id mtk_i2c_of_match[] = {
> > { .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
> > { .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
> > + { .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
> > { .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
> > {}
> > };
>
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2017-08-10 8:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 2:27 [RESEND PATCH 0/2] Add i2c dt-binding and compatible for Mediatek MT7622 SoC Jun Gao
2017-08-10 2:27 ` [RESEND PATCH 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Jun Gao
2017-08-10 8:19 ` Honghui Zhang
2017-08-11 1:37 ` Jun Gao
2017-08-11 2:17 ` Honghui Zhang
2017-08-10 2:27 ` [RESEND PATCH 2/2] i2c: mediatek: Add i2c compatible for MediaTek MT7622 Jun Gao
[not found] ` <1502332061-25085-3-git-send-email-jun.gao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-10 7:22 ` Jun Gao
2017-08-10 8:03 ` Yingjoe Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502352226.12382.1.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=jun.gao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).