From mboxrd@z Thu Jan 1 00:00:00 1970 From: Honghui Zhang Subject: Re: [RESEND PATCH 1/2] dt-bindings: i2c: Add MediaTek MT7622 i2c binding Date: Fri, 11 Aug 2017 10:17:06 +0800 Message-ID: <1502417826.10379.1.camel@mtksdaap41> References: <1502332061-25085-1-git-send-email-jun.gao@mediatek.com> <1502332061-25085-2-git-send-email-jun.gao@mediatek.com> <1502353140.17420.7.camel@mtksdaap41> <1502415473.930.72.camel@mhfsdcap03> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1502415473.930.72.camel@mhfsdcap03> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jun Gao Cc: Wolfram Sang , Matthias Brugger , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, 2017-08-11 at 09:37 +0800, Jun Gao wrote: > On Thu, 2017-08-10 at 16:19 +0800, Honghui Zhang wrote: > > On Thu, 2017-08-10 at 10:27 +0800, Jun Gao wrote: > > > From: Jun Gao > > > > > > Add MT7622 i2c binding to binding file. Compare to MT8173 i2c > > > controller, MT7622 limits message numbers to 255, and does not > > > support 4GB DMA mode. > > > > > > Signed-off-by: Jun Gao > > > --- > > > Documentation/devicetree/bindings/i2c/i2c-mtk.txt | 11 ++++++----- > > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > > index bd5a7be..ff9ac61 100644 > > > --- a/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > > +++ b/Documentation/devicetree/bindings/i2c/i2c-mtk.txt > > > @@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices. > > > > > > Required properties: > > > - compatible: value should be either of the following. > > > - "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek mt2701 > > > - "mediatek,mt6577-i2c": for i2c compatible with mt6577. > > > - "mediatek,mt6589-i2c": for i2c compatible with mt6589. > > > - "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for i2c compatible with mt7623. > > > - "mediatek,mt8173-i2c": for i2c compatible with mt8173. > > > + "mediatek,mt2701-i2c", "mediatek,mt6577-i2c": for Mediatek MT2701 > > > + "mediatek,mt6577-i2c": for Mediatek MT6577 > > > + "mediatek,mt6589-i2c": for Mediatek MT6589 > > > > Better not change those and just add compatible strings for mt7622. > > > It seems better to use the same format for all SoCs. > Alright, do you need to put those changes in commit message? Thanks. > Jun > > > + "mediatek,mt7622-i2c": for Mediatek MT7622 > > > + "mediatek,mt7623-i2c", "mediatek,mt6577-i2c": for Mediatek MT7623 > > > + "mediatek,mt8173-i2c": for Mediatek MT8173 > > > - reg: physical base address of the controller and dma base, length of memory > > > mapped region. > > > - interrupts: interrupt number to the cpu. > > > > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html