From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
chen.zhong-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
chenglin.xu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 2/9] dt-bindings: regulator: Add document for MediaTek MT6380 regulator
Date: Fri, 11 Aug 2017 14:13:38 +0800 [thread overview]
Message-ID: <1502432018.19230.29.camel@mtkswgap22> (raw)
In-Reply-To: <20170724182242.ejrobnjks3ehprpw@rob-hp-laptop>
On Mon, 2017-07-24 at 13:22 -0500, Rob Herring wrote:
> On Tue, Jul 18, 2017 at 05:49:22PM +0800, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
> > From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> >
> > add dt-binding document for MediaTek MT6380 PMIC
> >
> > Signed-off-by: Chenglin Xu <chenglin.xu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> > .../bindings/regulator/mt6380-regulator.txt | 90 ++++++++++++++++++++++
> > 1 file changed, 90 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> > new file mode 100644
> > index 0000000..2a559f0
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> > @@ -0,0 +1,90 @@
> > +MediaTek MT6380 Regulator Driver
>
> Bindings don't describe drivers.
>
will fix it.
> > +
> > +All voltage regulators are defined as subnodes of the regulators node. A list
>
> What's the regulators node a child of?
>
this two line i felt are a little confusion, i will change them into "
all voltage regulators provided by the MT6380 PMIC are described as the
subnodes of the mt6380regulators node "
> > +of regulators provided by this controller are defined as subnodes of the
> > +PMIC's node. Each regulator is named according to its regulator type,
> > +buck-<name> and ldo-<name>. The definition for each of these nodes is defined
> > +using the standard binding for regulators at
> > +Documentation/devicetree/bindings/regulator/regulator.txt.
> > +
> > +The valid names for regulators are:
> > +BUCK:
> > + buck-core1, buck-vcore, buck-vrf
> > +LDO:
> > + ldo-vm ,ldo-va , ldo-vphy, ldo-vddr, ldo-vt
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-11 6:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 9:49 [PATCH v2 0/9] Add PMIC support to MediaTek MT7622 SoC sean.wang
2017-07-18 9:49 ` [PATCH v2 1/9] dt-bindings: arm: mediatek: add MT7622 string to the PMIC wrapper doc sean.wang
2017-07-18 16:01 ` Yingjoe Chen
2017-07-19 2:54 ` Sean Wang
2017-07-18 9:49 ` [PATCH v2 2/9] dt-bindings: regulator: Add document for MediaTek MT6380 regulator sean.wang
[not found] ` <fef9412087f3961e03b77c067e227a31860a1417.1500368529.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-07-24 18:22 ` Rob Herring
2017-08-11 6:13 ` Sean Wang [this message]
[not found] ` <cover.1500368529.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-07-18 9:49 ` [PATCH v2 3/9] regulator: mt6380: Add support for MT6380 sean.wang-NuS5LvNUpcJWk0Htik3J/w
[not found] ` <0cd2be9a7058bb51fbbc7cc96101cba44fc081f6.1500368529.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-07-18 13:31 ` Mark Brown
[not found] ` <20170718133136.xodadxf2crkcuhze-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-08-11 3:11 ` Sean Wang
2017-08-09 9:22 ` Yingjoe Chen
2017-08-11 3:12 ` Sean Wang
2017-07-18 9:49 ` [PATCH v2 4/9] soc: mediatek: pwrap: add pwrap_read32 for reading in 32-bit mode sean.wang-NuS5LvNUpcJWk0Htik3J/w
2017-07-18 9:49 ` [PATCH v2 5/9] soc: mediatek: pwrap: add pwrap_write32 for writing " sean.wang
2017-07-18 9:49 ` [PATCH v2 6/9] soc: mediatek: pwrap: update pwrap_init without slave programming sean.wang
2017-07-18 9:49 ` [PATCH v2 7/9] soc: mediatek: pwrap: add MediaTek MT6380 as one slave of pwrap sean.wang
2017-07-18 9:49 ` [PATCH v2 8/9] soc: mediatek: pwrap: add support for MT7622 SoC sean.wang
2017-07-18 9:49 ` [PATCH v2 9/9] soc: mediatek: pwrap: fixup warnings from coding style sean.wang
2017-07-18 16:23 ` Yingjoe Chen
[not found] ` <568c3b518b70a0af17cbef1223721b68448a8ac6.1500368529.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-07-18 16:26 ` Yingjoe Chen
2017-07-18 16:31 ` Joe Perches
2017-08-01 16:53 ` [PATCH v2 0/9] Add PMIC support to MediaTek MT7622 SoC Sean Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502432018.19230.29.camel@mtkswgap22 \
--to=sean.wang-nus5lvnupcjwk0htik3j/w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=chen.zhong-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=chenglin.xu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).